From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 191FBC2D0CE for ; Mon, 30 Dec 2019 12:55:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E366420718 for ; Mon, 30 Dec 2019 12:55:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="R6qv7Pwa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E366420718 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D4qKSB4K+nCRtEGziLj34AlwaasbA9nVRNTUVXpT5Jw=; b=R6qv7PwaRpL5Bw MUuNToOwah8KQpRVpsbw6omgXb4AgA2qac5GitI8jeIpEnV38ghZyl1srlQiQhgZ2JO291+SxOR+q hjNI9i402RcCaOeSNY3pV0aPwg+2pR7jCsHtMFtmFHDhca4NL76H+Dt3jUe3Y7E1PX56Oyv/HbuOy VV8nPV6a341SA6hSGG1BaSTo1KLkw1yaKvl/Qm7tqeo34wRIiQBNvf591T2EkAAP0R4Kw8PzGHlkG EYKeyphNDkE6gkvY58NYEgAFCxD8ns9xU12iN5xGKNTpaegwzuZQ5vFOnZgnP7yt+hWTcnlXltJlq Hs8LDXOgLPIv+NH/qulw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iluZc-0007fu-7T; Mon, 30 Dec 2019 12:55:04 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iluZY-0007Qn-8c for linux-arm-kernel@lists.infradead.org; Mon, 30 Dec 2019 12:55:01 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iluZU-0001GO-4J; Mon, 30 Dec 2019 13:54:56 +0100 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1iluZS-0005OH-BM; Mon, 30 Dec 2019 13:54:54 +0100 Date: Mon, 30 Dec 2019 13:54:54 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Anson Huang Subject: Re: [PATCH] pwm: imx27: Eliminate error message for defer probe Message-ID: <20191230125454.7i4dahdc3wclpkgz@pengutronix.de> References: <1577674960-12011-1-git-send-email-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1577674960-12011-1-git-send-email-Anson.Huang@nxp.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191230_045500_305768_FA6C93AA X-CRM114-Status: GOOD ( 14.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, thierry.reding@gmail.com, Linux-imx@nxp.com, kernel@pengutronix.de, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 30, 2019 at 11:02:40AM +0800, Anson Huang wrote: > For defer probe error, no need to output error message which > will cause confusion. > = > Signed-off-by: Anson Huang > --- > drivers/pwm/pwm-imx27.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > = > diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c > index 59d8b12..35a7ac42 100644 > --- a/drivers/pwm/pwm-imx27.c > +++ b/drivers/pwm/pwm-imx27.c > @@ -319,9 +319,13 @@ static int pwm_imx27_probe(struct platform_device *p= dev) > = > imx->clk_ipg =3D devm_clk_get(&pdev->dev, "ipg"); > if (IS_ERR(imx->clk_ipg)) { > - dev_err(&pdev->dev, "getting ipg clock failed with %ld\n", > - PTR_ERR(imx->clk_ipg)); > - return PTR_ERR(imx->clk_ipg); > + int ret =3D PTR_ERR(imx->clk_ipg); > + > + if (ret !=3D -EPROBE_DEFER) > + dev_err(&pdev->dev, > + "getting ipg clock failed with %d\n", > + ret); While you touch this part, you could convert to %pe to get a more expressive error message. But even independent of this the patch is fine, so Acked-by: Uwe Kleine-K=F6nig Best regards Uwe -- = Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel