From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD22CC32771 for ; Tue, 7 Jan 2020 02:37:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AFEF6206E6 for ; Tue, 7 Jan 2020 02:37:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tdIQZARv"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="dgkNIwEX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AFEF6206E6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ipJfYO7zeX9yDHlwe60/jm37/QdF7UwmbvFp+98pIlk=; b=tdIQZARvpHJyaq ZrgOfhPb29jEIyAtNg7t38mYI+SBw6U80mraZZgthK0nvZLEAqiwVl6luaeVdYuUhuy/TMZTOLHMw cejI5CJusQlH4A9XvIqAbBNRFpb5mDt77izvSTNQzrl66lpEVD6ubljvIQigtK+jHdNEQ8oP0W2Z+ QWLIn4WURxhje8FQTNBo5wsfiOg7KgtUfMXy28pNKmCl5lZh09/sF4eeLafWVCWHg6z3L86S+NPlY 5DjRcrPugI22WBaG1YPzfeMIuQ2rqgJgBlDllPSkDP4oWPZQelkJmdeotpYu8gUT40n/bVk5D2zu5 oh4iBQXpGOu8+iVLdNqQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ioekY-0004F7-9v; Tue, 07 Jan 2020 02:37:42 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ioekU-0004EA-Gj; Tue, 07 Jan 2020 02:37:40 +0000 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7BA5252F; Tue, 7 Jan 2020 03:37:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1578364651; bh=MBDwBfB1yvrUNnyLXlcyy033c7X1+3QQ5e/fUKD3MKE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dgkNIwEXqZQBu93oKiUijThMtexXm7eh/FkOhKVRu7MS7FF9Z+Sh7w7iMfaXM4MIe AArZP3HEFWe7Ccmi40N5Rkrsbv/FH0LioCZ6g+mJAlUoGcJpuxPYlIpiRR+YFwUtkA gBJGUambx7da7F87o1LtzkVfs/TBk+XufHVdpXz4= Date: Tue, 7 Jan 2020 04:37:21 +0200 From: Laurent Pinchart To: Ezequiel Garcia Subject: Re: [PATCH v12 09/11] media: staging: dt-bindings: add Rockchip MIPI RX D-PHY yaml bindings Message-ID: <20200107023721.GG22189@pendragon.ideasonboard.com> References: <20191227200116.2612137-1-helen.koike@collabora.com> <20191227200116.2612137-10-helen.koike@collabora.com> <20200107001055.GE22189@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200106_183738_866900_B75BFE5C X-CRM114-Status: GOOD ( 24.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, eddie.cai.linux@gmail.com, kernel@collabora.com, heiko@sntech.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tfiga@chromium.org, linux-rockchip@lists.infradead.org, Helen Koike , robh+dt@kernel.org, hans.verkuil@cisco.com, linux-arm-kernel@lists.infradead.org, sakari.ailus@linux.intel.com, joacim.zetterling@gmail.com, mchehab@kernel.org, andrey.konovalov@linaro.org, jacob-chen@iotwrt.com, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 06, 2020 at 11:06:12PM -0300, Ezequiel Garcia wrote: > On Tue, 2020-01-07 at 02:10 +0200, Laurent Pinchart wrote: > > Hi Helen, > > > > Thank you for the patch. > > > > On Fri, Dec 27, 2019 at 05:01:14PM -0300, Helen Koike wrote: > > > Add yaml DT bindings for Rockchip MIPI D-PHY RX > > > > > > This was tested and verified with: > > > mv drivers/staging/media/phy-rockchip-dphy/Documentation/devicetree/bindings/phy/rockchip-mipi-dphy.yaml Documentation/devicetree/bindings/phy/ > > > make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/phy/rockchip-mipi-dphy.yaml > > > make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/phy/rockchip-mipi-dphy.yaml > > > > > > Signed-off-by: Helen Koike > > > > > > --- > > > > > > Changes in v12: > > > - The commit replaces the following commit in previous series named > > > media: staging: dt-bindings: Document the Rockchip MIPI RX D-PHY bindings > > > This new patch adds yaml binding and was verified with > > > make dtbs_check and make dt_binding_check > > > > > > Changes in v11: None > > > Changes in v10: > > > - unsquash > > > > > > Changes in v9: > > > - fix title division style > > > - squash > > > - move to staging > > > > > > Changes in v8: None > > > Changes in v7: > > > - updated doc with new design and tested example > > > > > > .../bindings/phy/rockchip-mipi-dphy.yaml | 75 +++++++++++++++++++ > > > 1 file changed, 75 insertions(+) > > > create mode 100644 drivers/staging/media/phy-rockchip-dphy/Documentation/devicetree/bindings/phy/rockchip-mipi-dphy.yaml > > > > > > diff --git a/drivers/staging/media/phy-rockchip-dphy/Documentation/devicetree/bindings/phy/rockchip-mipi-dphy.yaml b/drivers/staging/media/phy- > > > rockchip-dphy/Documentation/devicetree/bindings/phy/rockchip-mipi-dphy.yaml > > > new file mode 100644 > > > index 000000000000..af97f1b3e005 > > > --- /dev/null > > > +++ b/drivers/staging/media/phy-rockchip-dphy/Documentation/devicetree/bindings/phy/rockchip-mipi-dphy.yaml > > > @@ -0,0 +1,75 @@ > > > +# SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/phy/rockchip-mipi-dphy.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Rockchip SoC MIPI RX0 D-PHY Device Tree Bindings > > > > Should this be s/RX0/RX/ ? Or do you expect different bindings for RX1 ? > > The driver currently only supports RX0, but I think you are right, > it should say RX here. This binding could be extended for RX1. > > > Looking at the PHY driver, it seems to handle all PHYs with a single > > struct device. Should we thus use #phy-cells = <1> to select the PHY ? > > I am not following this. The driver handles just one PHY. Each PHY > should have its own node. Looking at the registers, it seems that the different PHYs are intertwined and we would could have trouble handling the different PHYs with different DT nodes and thus struct device instances. > > > + > > > +maintainers: > > > + - Helen Koike > > > + - Ezequiel Garcia > > > + > > > +description: | > > > + The Rockchip SoC has a MIPI D-PHY bus with an RX0 entry which connects to > > > + the ISP1 (Image Signal Processing unit v1.0) for CSI cameras. > > > + > > > +properties: > > > + compatible: > > > + const: rockchip,rk3399-mipi-dphy > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + clocks: > > > + items: > > > + - description: Mipi d-phy ref clock > > > + - description: Mipi d-phy rx0 cfg clock > > > > s/Mipi d-phy/MIPI D-PHY/ > > Yep. > > > > + - description: Video in/out general register file clock > > > + > > > + clock-names: > > > + items: > > > + - const: dphy-ref > > > + - const: dphy-cfg > > > + - const: grf > > > + > > > + '#phy-cells': > > > + const: 0 > > > + > > > + power-domains: > > > + description: Video in/out power domain. > > > + maxItems: 1 > > > + > > > +required: > > > + - compatible > > > + - clocks > > > + - clock-names > > > + - '#phy-cells' > > > + - power-domains > > > + > > > +additionalProperties: false > > > + > > > +examples: > > > + - | > > > + > > > + /* > > > + * MIPI RX D-PHY use registers in "general register files", it > > > + * should be a child of the GRF. > > > + * > > > + * grf: syscon@ff770000 { > > > + * compatible = "rockchip,rk3399-grf", "syscon", "simple-mfd"; > > > + * ... > > > > missing > > > > * }; > > OK. > > > > + */ > > > + > > > + #include > > > + #include > > > + > > > + dphy: mipi-dphy { > > > + compatible = "rockchip,rk3399-mipi-dphy"; > > > + clocks = <&cru SCLK_MIPIDPHY_REF>, > > > + <&cru SCLK_DPHY_RX0_CFG>, > > > + <&cru PCLK_VIO_GRF>; > > > + clock-names = "dphy-ref", "dphy-cfg", "grf"; > > > + power-domains = <&power RK3399_PD_VIO>; > > > + #phy-cells = <0>; > > > + }; -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel