From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4813C282DD for ; Fri, 10 Jan 2020 14:59:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A60620721 for ; Fri, 10 Jan 2020 14:59:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AoZj0VpC"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="VSQn0Ttt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A60620721 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FnxUtRnu6QWaKG2fLqVYZbTWPhvmHcBdfi+ohfH9Mq4=; b=AoZj0VpCZavgwR d2o4vvO4RTCwWYGnluR9tT/W6AD0e9xfFTWxONL8s6MmAHE1L+p1kU4dLZx7J+xlfdxP/i5lznEUk lj/43ceGR2HAWrlvC4WS6U4kI2Zn3ErmmSXwCIO2/ep4dBoIbWwPCdbD0ULxjlQTDHHL0Ho1GI2wB /gim/GJlZKSVr3LpxJsBfDeE/aK1CwhbYXzl2ia2uOZ5aNdPT577/7LDNM4D8X0cZ81O49uQ9DoMM Gw4X+n7RfOAHqTADMhjZOCQvs0jjLG5/MtuLZyNoZTKBU3e4vL9YVgcWjtEerZBG73Q+Fm62RbA0G +IvF3wf/gDO5VkDC0O3w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipvky-0000uC-Ky; Fri, 10 Jan 2020 14:59:24 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipvku-0000mO-67 for linux-arm-kernel@lists.infradead.org; Fri, 10 Jan 2020 14:59:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=KcB+0FZvEwMSZ71K+kCoZ9X5u6DRQpvD2AQdpGnKqKU=; b=VSQn0TttzYKM/CdTWxnCb9SAK 98MKbpP1VXCI0Wb/ur9FQV6efmKh98+5V8KPBvOrOfxB7IrgR05Ta3vlsVkBS618/wkR/PkF8y4f3 9rX0rXKOOIac1MIFCacPThgaz4YTylyoGIYqIOzwsN7VjtDB57lpecTA+jJoaRUPUpmBVqjLnuepN yP+TmIC7pPvUW5xAl5K7439M3ROyOI9TB3VDgrofXb84No5s41VboEGKCVgNbHnOSADnNtsrbQ4TV CHjv74Fj6rjhDsWFYY47kXdsbHAN3nkCSjgGVFDIUhyo8I+KhX8UEtmC0LtaI/D1YDzXTd8TXOgSC tbRk2znsQ==; Received: from shell.armlinux.org.uk ([2001:4d48:ad52:3201:5054:ff:fe00:4ec]:53122) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ipvkU-0003i1-OE; Fri, 10 Jan 2020 14:58:54 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1ipvkP-0001aZ-ER; Fri, 10 Jan 2020 14:58:49 +0000 Date: Fri, 10 Jan 2020 14:58:49 +0000 From: Russell King - ARM Linux admin To: Andre Przywara Subject: Re: [PATCH 07/14] net: axienet: Fix SGMII support Message-ID: <20200110145849.GC25745@shell.armlinux.org.uk> References: <20200110115415.75683-1-andre.przywara@arm.com> <20200110115415.75683-8-andre.przywara@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200110115415.75683-8-andre.przywara@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200110_065920_237176_75E10D00 X-CRM114-Status: UNSURE ( 9.71 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, Radhey Shyam Pandey , Michal Simek , linux-kernel@vger.kernel.org, Robert Hancock , "David S . Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 10, 2020 at 11:54:08AM +0000, Andre Przywara wrote: > With SGMII, the MAC and the PHY can negotiate the link speed between > themselves, without the host needing to mediate between them. > Linux recognises this, and will call phylink's mac_config with the speed > member set to SPEED_UNKNOWN (-1). I wonder whether you have read the documentation for the phylink mac_config() method (if not, please read it, it contains some very important information about what mac_config() should do.) When operating in SGMII in-band mode, state->speed and state->duplex are not actually valid. You'll probably want to submit a better patch after reading the documentation. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel