From: Viresh Kumar <viresh.kumar@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: peng.fan@nxp.com, Jassi Brar <jassisinghbrar@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
cristian.marussi@arm.com, Sudeep Holla <sudeep.holla@arm.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2] firmware: arm_scmi: Make scmi core independent of transport type
Date: Tue, 14 Jan 2020 16:41:10 +0530 [thread overview]
Message-ID: <20200114111110.jhkj2y47ncp5233r@vireshk-i7> (raw)
In-Reply-To: <CAK8P3a0jXyJArzQFd+u68iRvXNnXb_oHbWF9-abvvFuqhpi-NA@mail.gmail.com>
On 14-01-20, 10:56, Arnd Bergmann wrote:
> My point was that you cannot mix __iomem accesses with pointer
> accesses. As I understood it, the current version uses a pointer to a
The current version is stupid as I misunderstood the whole __iomem
thing and just dropped it :)
> hardware mailbox with structured data, so you have to use ioremap()
> to get a token you can pass into ioread(), but (some of) the new
> transport types would just be backed by regular RAM, on which this
> is not a well-defined operation and you have to use memremap()
> and memcpy() instead.
Okay, I think I understand that a bit now. So here are the things
which I may need to do now:
- Maybe move payload to struct scmi_mailbox structure, as that is the
transport dependent structure..
- Do ioremap, etc in mailbox.c only instead of driver.c
- Provide more ops in struct scmi_transport_ops to provide read/write
helpers to the payload and implement the ones based on
ioread/iowrite in mailbox.c ..
Am I thinking in the right direction now ?
--
viresh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-14 11:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 9:43 [PATCH V2] firmware: arm_scmi: Make scmi core independent of transport type Viresh Kumar
2020-01-10 11:15 ` Arnd Bergmann
2020-01-13 6:41 ` Viresh Kumar
2020-01-13 11:36 ` Arnd Bergmann
2020-01-14 9:26 ` Viresh Kumar
2020-01-14 9:56 ` Arnd Bergmann
2020-01-14 11:11 ` Viresh Kumar [this message]
2020-01-14 11:17 ` Arnd Bergmann
2020-01-14 17:41 ` Sudeep Holla
2020-01-15 8:20 ` Peng Fan
2020-01-15 19:37 ` peter.hilber
2020-01-14 11:03 ` Sudeep Holla
2020-01-15 8:53 ` Peng Fan
2020-01-15 14:33 ` Sudeep Holla
2020-01-17 2:26 ` Peng Fan
2020-01-16 15:21 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200114111110.jhkj2y47ncp5233r@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=arnd@arndb.de \
--cc=cristian.marussi@arm.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).