From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46ABDC33CB1 for ; Wed, 15 Jan 2020 07:18:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1B57B2084D for ; Wed, 15 Jan 2020 07:18:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="j6JoMlR2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B57B2084D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OYGtLmNyJwn0ggObrT+bhY0ZMVlpfxDO427RW0q/KOs=; b=j6JoMlR27VnNyB 0l0SLjKovzjwzEOiwBNLedg1K+ChPZMtHJxs7DnW6DwnJYsx1n8oQ3IzZDwEl820d75sg6YaRLLry w9jLck3nH7pY9qp5ilnFcZQNOEVgGB2SjA3/cgNINQYRWh/47pG7QZ2SYN1o7TH3iNbpjTih3/jtB ZGP4AazHKHv0mmO5mWi95chMwhZyNWkU+q4ej8Lh6ucJ12v+49cHYbR6PCH1QtrwluvhFRPn48omw yzefilKIc7zgSpzdubPnRwyom38BjcY3Rm09gF9XetDZBlaxkjuoKasL1yH0+Alm13zYdW54OeF43 iBpJBrAjsaYHrTJc5YGg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ircwR-0000kA-7W; Wed, 15 Jan 2020 07:18:15 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ircwL-0000j4-5o for linux-arm-kernel@lists.infradead.org; Wed, 15 Jan 2020 07:18:12 +0000 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ircwC-0004eU-FT; Wed, 15 Jan 2020 08:18:00 +0100 Received: from mfe by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1ircw9-0007ei-NA; Wed, 15 Jan 2020 08:17:57 +0100 Date: Wed, 15 Jan 2020 08:17:57 +0100 From: Marco Felsch To: Anson Huang Subject: Re: [PATCH V3 2/3] dt-bindings: pinctrl: Convert i.MX8MM to json-schema Message-ID: <20200115071757.bmblie3skdswuj2r@pengutronix.de> References: <1579051845-30378-1-git-send-email-Anson.Huang@nxp.com> <1579051845-30378-2-git-send-email-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1579051845-30378-2-git-send-email-Anson.Huang@nxp.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 08:16:59 up 60 days, 22:35, 54 users, load average: 0.02, 0.06, 0.03 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200114_231809_222620_066C62CA X-CRM114-Status: GOOD ( 20.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: aisheng.dong@nxp.com, mark.rutland@arm.com, devicetree@vger.kernel.org, festevam@gmail.com, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, stefan@agner.ch, linux-gpio@vger.kernel.org, robh+dt@kernel.org, Linux-imx@nxp.com, kernel@pengutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Anson, On 20-01-15 09:30, Anson Huang wrote: > Convert the i.MX8MM pinctrl binding to DT schema format using json-schema > > Signed-off-by: Anson Huang > --- > Change since V2: > - the lisence should be GPL-2.0 > --- > .../bindings/pinctrl/fsl,imx8mm-pinctrl.txt | 36 ----------- > .../bindings/pinctrl/fsl,imx8mm-pinctrl.yaml | 69 ++++++++++++++++++++++ > 2 files changed, 69 insertions(+), 36 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imx8mm-pinctrl.txt > create mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imx8mm-pinctrl.yaml > > diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,imx8mm-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/fsl,imx8mm-pinctrl.txt > deleted file mode 100644 > index e4e01c0..0000000 > --- a/Documentation/devicetree/bindings/pinctrl/fsl,imx8mm-pinctrl.txt > +++ /dev/null > @@ -1,36 +0,0 @@ > -* Freescale IMX8MM IOMUX Controller > - > -Please refer to fsl,imx-pinctrl.txt and pinctrl-bindings.txt in this directory > -for common binding part and usage. > - > -Required properties: > -- compatible: "fsl,imx8mm-iomuxc" > -- reg: should contain the base physical address and size of the iomuxc > - registers. > - > -Required properties in sub-nodes: > -- fsl,pins: each entry consists of 6 integers and represents the mux and config > - setting for one pin. The first 5 integers - input_val> are specified using a PIN_FUNC_ID macro, which can be found in > - . The last integer CONFIG is > - the pad setting value like pull-up on this pin. Please refer to i.MX8M Mini > - Reference Manual for detailed CONFIG settings. > - > -Examples: > - > -&uart1 { > - pinctrl-names = "default"; > - pinctrl-0 = <&pinctrl_uart1>; > -}; > - > -iomuxc: pinctrl@30330000 { > - compatible = "fsl,imx8mm-iomuxc"; > - reg = <0x0 0x30330000 0x0 0x10000>; > - > - pinctrl_uart1: uart1grp { > - fsl,pins = < > - MX8MM_IOMUXC_UART1_RXD_UART1_DCE_RX 0x140 > - MX8MM_IOMUXC_UART1_TXD_UART1_DCE_TX 0x140 > - >; > - }; > -}; > diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,imx8mm-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/fsl,imx8mm-pinctrl.yaml > new file mode 100644 > index 0000000..8b2de93 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pinctrl/fsl,imx8mm-pinctrl.yaml > @@ -0,0 +1,69 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pinctrl/fsl,imx8mm-pinctrl.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale IMX8MM IOMUX Controller > + > +maintainers: > + - Anson Huang > + > +description: > + Please refer to fsl,imx-pinctrl.txt and pinctrl-bindings.txt in this directory > + for common binding part and usage. > + > +properties: > + compatible: > + const: fsl,imx8mm-iomuxc > + > + reg: > + maxItems: 1 > + > +# Client device subnode's properties > +patternProperties: > + 'grp$': > + type: object > + description: > + Pinctrl node's client devices use subnodes for desired pin configuration. > + Client device subnodes use below standard properties. > + > + properties: > + fsl,pins: > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32-array > + description: > + each entry consists of 6 integers and represents the mux and config > + setting for one pin. The first 5 integers + mux_val input_val> are specified using a PIN_FUNC_ID macro, which can > + be found in . The last > + integer CONFIG is the pad setting value like pull-up on this pin. Please > + refer to i.MX8M Mini Reference Manual for detailed CONFIG settings. > + > + required: > + - fsl,pins > + > + additionalProperties: false > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + # Pinmux controller node > + - | > + iomuxc: pinctrl@30330000 { > + compatible = "fsl,imx8mm-iomuxc"; > + reg = <0x30330000 0x10000>; > + > + pinctrl_uart2: uart2grp { > + fsl,pins = < > + 0x23C 0x4A4 0x4FC 0x0 0x0 0x140 Why we can't use the pinctrl defines like MX8MM_IOMUXC_UART1_RXD_UART1_DCE_RX anymore? Regards, Marco > + 0x240 0x4A8 0x000 0x0 0x0 0x140 > + >; > + }; > + }; > + > +... > -- > 2.7.4 > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel