Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] ARM: dts: stm32: Add missing ETHCK clock to ethernet node
@ 2020-01-15  9:46 Marek Vasut
  2020-01-15 16:45 ` Patrick DELAUNAY
  0 siblings, 1 reply; 4+ messages in thread
From: Marek Vasut @ 2020-01-15  9:46 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Marek Vasut, Christophe ROULLIER, Patrick Delaunay, Patrice Chotard

Add missing 'eth-ck' clock to the ethernet node. These clock are used to
generate external clock signal for the PHY in case 'st,eth_ref_clk_sel'
is specified.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Christophe ROULLIER <christophe.roullier@st.com>
Cc: Patrice Chotard <patrice.chotard@st.com>
Cc: Patrick Delaunay <patrick.delaunay@st.com>
---
 arch/arm/boot/dts/stm32mp151.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/stm32mp151.dtsi b/arch/arm/boot/dts/stm32mp151.dtsi
index fb41d0778b00..e0ecc5ee7d83 100644
--- a/arch/arm/boot/dts/stm32mp151.dtsi
+++ b/arch/arm/boot/dts/stm32mp151.dtsi
@@ -1369,10 +1369,12 @@ ethernet0: ethernet@5800a000 {
 			clock-names = "stmmaceth",
 				      "mac-clk-tx",
 				      "mac-clk-rx",
+				      "eth-ck",
 				      "ethstp";
 			clocks = <&rcc ETHMAC>,
 				 <&rcc ETHTX>,
 				 <&rcc ETHRX>,
+				 <&rcc ETHCK_K>,
 				 <&rcc ETHSTP>;
 			st,syscon = <&syscfg 0x4>;
 			snps,mixed-burst;
-- 
2.24.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH] ARM: dts: stm32: Add missing ETHCK clock to ethernet node
  2020-01-15  9:46 [PATCH] ARM: dts: stm32: Add missing ETHCK clock to ethernet node Marek Vasut
@ 2020-01-15 16:45 ` Patrick DELAUNAY
  2020-01-17 12:50   ` Marek Vasut
  0 siblings, 1 reply; 4+ messages in thread
From: Patrick DELAUNAY @ 2020-01-15 16:45 UTC (permalink / raw)
  To: Marek Vasut, linux-arm-kernel, mcoquelin.stm32, Alexandre TORGUE
  Cc: linux-stm32, Christophe ROULLIER, Patrice CHOTARD

Hi Marek;

Add the Linux Maintainers for STM32M linux patch:

M:	Maxime Coquelin <mcoquelin.stm32@gmail.com>
M:	Alexandre Torgue <alexandre.torgue@st.com>
L:	linux-stm32@st-md-mailman.stormreply.com (moderated for non-subscribers)
L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)


Hi Alexandre,

Can you review this patch.

Regards

Patrick

> From: Marek Vasut <marex@denx.de>
> Sent: mercredi 15 janvier 2020 10:46
> 
> Add missing 'eth-ck' clock to the ethernet node. These clock are used to generate
> external clock signal for the PHY in case 'st,eth_ref_clk_sel'
> is specified.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Christophe ROULLIER <christophe.roullier@st.com>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Patrick Delaunay <patrick.delaunay@st.com>
> ---
>  arch/arm/boot/dts/stm32mp151.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/stm32mp151.dtsi
> b/arch/arm/boot/dts/stm32mp151.dtsi
> index fb41d0778b00..e0ecc5ee7d83 100644
> --- a/arch/arm/boot/dts/stm32mp151.dtsi
> +++ b/arch/arm/boot/dts/stm32mp151.dtsi
> @@ -1369,10 +1369,12 @@ ethernet0: ethernet@5800a000 {
>  			clock-names = "stmmaceth",
>  				      "mac-clk-tx",
>  				      "mac-clk-rx",
> +				      "eth-ck",
>  				      "ethstp";
>  			clocks = <&rcc ETHMAC>,
>  				 <&rcc ETHTX>,
>  				 <&rcc ETHRX>,
> +				 <&rcc ETHCK_K>,
>  				 <&rcc ETHSTP>;
>  			st,syscon = <&syscfg 0x4>;
>  			snps,mixed-burst;
> --
> 2.24.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: stm32: Add missing ETHCK clock to ethernet node
  2020-01-15 16:45 ` Patrick DELAUNAY
@ 2020-01-17 12:50   ` Marek Vasut
  2020-01-17 16:59     ` Alexandre Torgue
  0 siblings, 1 reply; 4+ messages in thread
From: Marek Vasut @ 2020-01-17 12:50 UTC (permalink / raw)
  To: Patrick DELAUNAY, linux-arm-kernel, mcoquelin.stm32, Alexandre TORGUE
  Cc: linux-stm32, Christophe ROULLIER, Patrice CHOTARD

On 1/15/20 5:45 PM, Patrick DELAUNAY wrote:
> Hi Marek;

Hi,

> Add the Linux Maintainers for STM32M linux patch:

Added, if there is a need for V2.
[...]
> 
> Hi Alexandre,
> 
> Can you review this patch.
> 
> Regards
> 
> Patrick
> 
>> From: Marek Vasut <marex@denx.de>
>> Sent: mercredi 15 janvier 2020 10:46
>>
>> Add missing 'eth-ck' clock to the ethernet node. These clock are used to generate
>> external clock signal for the PHY in case 'st,eth_ref_clk_sel'
>> is specified.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Christophe ROULLIER <christophe.roullier@st.com>
>> Cc: Patrice Chotard <patrice.chotard@st.com>
>> Cc: Patrick Delaunay <patrick.delaunay@st.com>
>> ---
>>  arch/arm/boot/dts/stm32mp151.dtsi | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/stm32mp151.dtsi
>> b/arch/arm/boot/dts/stm32mp151.dtsi
>> index fb41d0778b00..e0ecc5ee7d83 100644
>> --- a/arch/arm/boot/dts/stm32mp151.dtsi
>> +++ b/arch/arm/boot/dts/stm32mp151.dtsi
>> @@ -1369,10 +1369,12 @@ ethernet0: ethernet@5800a000 {
>>  			clock-names = "stmmaceth",
>>  				      "mac-clk-tx",
>>  				      "mac-clk-rx",
>> +				      "eth-ck",
>>  				      "ethstp";
>>  			clocks = <&rcc ETHMAC>,
>>  				 <&rcc ETHTX>,
>>  				 <&rcc ETHRX>,
>> +				 <&rcc ETHCK_K>,
>>  				 <&rcc ETHSTP>;
>>  			st,syscon = <&syscfg 0x4>;
>>  			snps,mixed-burst;
>> --
>> 2.24.1
> 


-- 
Best regards,
Marek Vasut

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: stm32: Add missing ETHCK clock to ethernet node
  2020-01-17 12:50   ` Marek Vasut
@ 2020-01-17 16:59     ` Alexandre Torgue
  0 siblings, 0 replies; 4+ messages in thread
From: Alexandre Torgue @ 2020-01-17 16:59 UTC (permalink / raw)
  To: Marek Vasut, Patrick DELAUNAY, linux-arm-kernel, mcoquelin.stm32
  Cc: linux-stm32, Christophe ROULLIER, Patrice CHOTARD

Hi Marek

On 1/17/20 1:50 PM, Marek Vasut wrote:
> On 1/15/20 5:45 PM, Patrick DELAUNAY wrote:
>> Hi Marek;
> 
> Hi,
> 
>> Add the Linux Maintainers for STM32M linux patch:
> 
> Added, if there is a need for V2.
> [...]
>>
>> Hi Alexandre,
>>
>> Can you review this patch.
>>
>> Regards
>>
>> Patrick
>>
>>> From: Marek Vasut <marex@denx.de>
>>> Sent: mercredi 15 janvier 2020 10:46
>>>
>>> Add missing 'eth-ck' clock to the ethernet node. These clock are used to generate
>>> external clock signal for the PHY in case 'st,eth_ref_clk_sel'
>>> is specified.
>>>

Just indicate in commit title that this commit is done for stm32mp15 
family. Otherwise it looks good.

Thanks
Alex

>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>> Cc: Christophe ROULLIER <christophe.roullier@st.com>
>>> Cc: Patrice Chotard <patrice.chotard@st.com>
>>> Cc: Patrick Delaunay <patrick.delaunay@st.com>
>>> ---
>>>   arch/arm/boot/dts/stm32mp151.dtsi | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/stm32mp151.dtsi
>>> b/arch/arm/boot/dts/stm32mp151.dtsi
>>> index fb41d0778b00..e0ecc5ee7d83 100644
>>> --- a/arch/arm/boot/dts/stm32mp151.dtsi
>>> +++ b/arch/arm/boot/dts/stm32mp151.dtsi
>>> @@ -1369,10 +1369,12 @@ ethernet0: ethernet@5800a000 {
>>>   			clock-names = "stmmaceth",
>>>   				      "mac-clk-tx",
>>>   				      "mac-clk-rx",
>>> +				      "eth-ck",
>>>   				      "ethstp";
>>>   			clocks = <&rcc ETHMAC>,
>>>   				 <&rcc ETHTX>,
>>>   				 <&rcc ETHRX>,
>>> +				 <&rcc ETHCK_K>,
>>>   				 <&rcc ETHSTP>;
>>>   			st,syscon = <&syscfg 0x4>;
>>>   			snps,mixed-burst;
>>> --
>>> 2.24.1
>>
> 
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-15  9:46 [PATCH] ARM: dts: stm32: Add missing ETHCK clock to ethernet node Marek Vasut
2020-01-15 16:45 ` Patrick DELAUNAY
2020-01-17 12:50   ` Marek Vasut
2020-01-17 16:59     ` Alexandre Torgue

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org
	public-inbox-index linux-arm-kernel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git