From: Will Deacon <will@kernel.org>
To: Vladimir Murzin <vladimir.murzin@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/2] arm64: Simplify gas LSE support detection
Date: Wed, 15 Jan 2020 12:51:10 +0000 [thread overview]
Message-ID: <20200115125109.GH21692@willie-the-truck> (raw)
In-Reply-To: <df4eda09-3234-8e32-6ea3-6fc6628cae05@arm.com>
On Wed, Jan 15, 2020 at 12:49:17PM +0000, Vladimir Murzin wrote:
> On 1/15/20 11:30 AM, Catalin Marinas wrote:
> > Version two of the patch series moving the LSE assembler support
> > detection from Makefile to Kconfig.
> >
> > Changes since v1 [1]:
> >
> > - Re-introduce the Makefile warning if the .config contains
> > CONFIG_ARM64_USE_LSE_ATOMICS but the assembler does not support the
> > feature, disabling CONFIG_ARM64_LSE_ATOMICS.
> >
> > [1] http://lkml.kernel.org/r/20200109174948.48211-1-catalin.marinas@arm.com
> >
> > Catalin Marinas (2):
> > kbuild: Add support for 'as-instr' to be used in Kconfig files
> > arm64: Move the LSE gas support detection to Kconfig
> >
> > arch/arm64/Kconfig | 5 +++++
> > arch/arm64/Makefile | 11 ++++-------
> > arch/arm64/include/asm/atomic_ll_sc.h | 2 +-
> > arch/arm64/include/asm/lse.h | 6 +++---
> > arch/arm64/kernel/cpufeature.c | 4 ++--
> > scripts/Kconfig.include | 4 ++++
> > 6 files changed, 19 insertions(+), 13 deletions(-)
> >
> >
>
> with
>
> aarch64-linux-gnu-gcc (crosstool-NG linaro-1.13.1-4.9-2014.09 - Linaro GCC 4.9-2014.09) 4.9.2 20140904 (prerelease)
>
> I see (among other warnings)
>
> arch/arm64/Makefile:35: LSE atomics not supported by binutils
>
> while with
>
> aarch64-none-linux-gnu-gcc (GNU Toolchain for the A-profile Architecture 9.2-2019.12 (arm-9.10)) 9.2.1 20191025
>
> warning disappears.
>
>
> FWIW:
>
> Reviewed-by: Vladimir Murzin <vladimir.murzin@arm.com>
> Tested-by: Vladimir Murzin <vladimir.murzin@arm.com>
Cheers, I've queued the patches with your tags.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-15 12:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 11:30 [PATCH v2 0/2] arm64: Simplify gas LSE support detection Catalin Marinas
2020-01-15 11:30 ` [PATCH v2 1/2] kbuild: Add support for 'as-instr' to be used in Kconfig files Catalin Marinas
2020-01-15 11:30 ` [PATCH v2 2/2] arm64: Move the LSE gas support detection to Kconfig Catalin Marinas
2020-01-15 12:49 ` [PATCH v2 0/2] arm64: Simplify gas LSE support detection Vladimir Murzin
2020-01-15 12:51 ` Will Deacon [this message]
2020-01-15 12:59 ` Vladimir Murzin
2020-01-15 13:24 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200115125109.GH21692@willie-the-truck \
--to=will@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=vladimir.murzin@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).