Re: [PATCH v5 06/12] arm64: elf: Enable BTI at exec based on ELF program properties

From: kbuild test robot <lkp@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Paul Elliott" <paul.elliott@arm.com>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Andrew Jones" <drjones@redhat.com>,
	"Amit Kachhap" <amit.kachhap@arm.com>,
	"Vincenzo Frascino" <vincenzo.frascino@arm.com>,
	"Will Deacon" <will@kernel.org>,
	linux-arch@vger.kernel.org, "Marc Zyngier" <maz@kernel.org>,
	"Eugene Syromiatnikov" <esyr@redhat.com>,
	"Szabolcs Nagy" <szabolcs.nagy@arm.com>,
	"Dave Martin" <Dave.Martin@arm.com>,
	"H . J . Lu" <hjl.tools@gmail.com>,
	"Yu-cheng Yu" <yu-cheng.yu@intel.com>,
	"Kees Cook" <keescook@chromium.org>,
	"Arnd Bergmann" <arnd@arndb.de>, "Jann Horn" <jannh@google.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Kristina Martšenko" <kristina.martsenko@arm.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Alexander Viro" <viro@zeniv.linux.org.uk>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	"Florian Weimer" <fweimer@redhat.com>,
	kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	"Sudakshina Das" <sudi.das@arm.com>
Subject: Re: [PATCH v5 06/12] arm64: elf: Enable BTI at exec based on ELF program properties
Date: Sat, 25 Jan 2020 03:12:56 +0800	[thread overview]
Message-ID: <202001250302.Pb0vnMSr%lkp@intel.com> (raw)
In-Reply-To: <20200122212144.6409-7-broonie@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 4182 bytes --]

Hi Mark,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on asm-generic/master]
[also build test ERROR on kvmarm/next linus/master v5.5-rc7]
[cannot apply to arm64/for-next/core arm-perf/for-next/perf next-20200124]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Mark-Brown/arm64-ARMv8-5-A-Branch-Target-Identification-support/20200124-203746
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git master
config: arm64-allnoconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/module.h:18:0,
                    from include/linux/kallsyms.h:13,
                    from include/linux/ftrace.h:11,
                    from include/linux/perf_event.h:49,
                    from include/kvm/arm_pmu.h:10,
                    from arch/arm64/include/asm/kvm_host.h:37,
                    from include/linux/kvm_host.h:36,
                    from arch/arm64/kernel/asm-offsets.c:14:
>> include/linux/elf.h:79:19: error: redefinition of 'arch_parse_elf_property'
    static inline int arch_parse_elf_property(u32 type, const void *data,
                      ^~~~~~~~~~~~~~~~~~~~~~~
   In file included from include/linux/elf.h:6:0,
                    from include/linux/module.h:18,
                    from include/linux/kallsyms.h:13,
                    from include/linux/ftrace.h:11,
                    from include/linux/perf_event.h:49,
                    from include/kvm/arm_pmu.h:10,
                    from arch/arm64/include/asm/kvm_host.h:37,
                    from include/linux/kvm_host.h:36,
                    from arch/arm64/kernel/asm-offsets.c:14:
   arch/arm64/include/asm/elf.h:241:19: note: previous definition of 'arch_parse_elf_property' was here
    static inline int arch_parse_elf_property(u32 type, const void *data,
                      ^~~~~~~~~~~~~~~~~~~~~~~
   make[2]: *** [arch/arm64/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [prepare0] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [sub-make] Error 2
   115 real  3 user  4 sys  7.44% cpu 	make prepare

vim +/arch_parse_elf_property +79 include/linux/elf.h

efb25e29b815dd Dave Martin 2020-01-22  77  
efb25e29b815dd Dave Martin 2020-01-22  78  #ifndef CONFIG_ARCH_USE_GNU_PROPERTY
efb25e29b815dd Dave Martin 2020-01-22 @79  static inline int arch_parse_elf_property(u32 type, const void *data,
efb25e29b815dd Dave Martin 2020-01-22  80  					  size_t datasz, bool compat,
efb25e29b815dd Dave Martin 2020-01-22  81  					  struct arch_elf_state *arch)
efb25e29b815dd Dave Martin 2020-01-22  82  {
efb25e29b815dd Dave Martin 2020-01-22  83  	return 0;
efb25e29b815dd Dave Martin 2020-01-22  84  }
efb25e29b815dd Dave Martin 2020-01-22  85  #else
efb25e29b815dd Dave Martin 2020-01-22  86  extern int arch_parse_elf_property(u32 type, const void *data, size_t datasz,
efb25e29b815dd Dave Martin 2020-01-22  87  				   bool compat, struct arch_elf_state *arch);
efb25e29b815dd Dave Martin 2020-01-22  88  #endif
efb25e29b815dd Dave Martin 2020-01-22  89  

:::::: The code at line 79 was first introduced by commit
:::::: efb25e29b815ddf0dd1bbe3728659da08c80fa14 ELF: Add ELF program property parsing support

:::::: TO: Dave Martin <Dave.Martin@arm.com>
:::::: CC: 0day robot <lkp@intel.com>

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 8020 bytes --]

[-- Attachment #3: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel