From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A79FC352A3 for ; Thu, 6 Feb 2020 20:45:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 49B4921775 for ; Thu, 6 Feb 2020 20:45:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AUQ0M7YW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 49B4921775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=53Glr5DdD2hIRS3btg1Pq5ksyOSErx0wSAHojsS6p6A=; b=AUQ0M7YWtoT7wK q2jSwPy3E6qyyMQZf/P92G8IZo7Zwv4aPfDgwpzBmXJ+N352ULtV0iTMqcQ4QDfWns+mvT+Dv/xbf nOXx8qW+vtFZG1juP+8envRzIP4xenlCRAfDta1XidcAcrTtKZdMYDIkosj7f43nG3Ebzn0vI7eOM sNvAjKr5mwshGFzYMezUX6DldFPdNq0czq6y8Yjcktje/vfo0+zxZF8wLHBUyvqBwiCgrzEhDVahZ sa89xd6SDSzGbE83j6YYTfd8zZyh8xjbwod9gkZDDuaBgH5zApYOQdPfh+gckyHzM1Cs3Nhek/UWb jZfJQCYErZtHooaKC0lw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1izo23-0007iZ-M2; Thu, 06 Feb 2020 20:45:51 +0000 Received: from mail-pj1-f66.google.com ([209.85.216.66]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1izo1u-0007Ya-7s for linux-arm-kernel@lists.infradead.org; Thu, 06 Feb 2020 20:45:47 +0000 Received: by mail-pj1-f66.google.com with SMTP id f2so655321pjq.1 for ; Thu, 06 Feb 2020 12:45:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=JQfj0uzbhk9PL5wqDoKeIBKd41MQ1h8voivIlPs9HKc=; b=TP0shqLendq3ZKMaOEL4oPkiAp/AoqYQ5grHYwGPeMsfYjJp23eb5YfzDdYn07EmBz xG7R6/Wk85lTP/01RgLc4lgPzuM1ylb7xT2LorlWT4NWEsiUwDAQCxxGKUS/vEDK5M6L fgZ7zLwRRiwZoN4TddkZQk81okfV4DAmOkV042WT4WAIYFs02+ZXxbxuyEbQXlTgzP7b m7FA1/8vzvZtSUfn5ADE6nnoWpWsVmboRWVp+PhpoFcEai5+Rmz/GNhjUf0DxqMlDuCM Fd/Vi9jhMl9K9kkoKxrA5EUqw1rhtOg79Xk2JR/YNmprJFIBMoe5xgrn2koKSYHNFPj8 HbtA== X-Gm-Message-State: APjAAAWk4nYJ+gigbmu3nCEce3DW9X4YM6NT/+cX8ewcfPdA/KdvsTLS EFgeH2lXH0DEGBWxGwURYg9RYlXOmw== X-Google-Smtp-Source: APXvYqzSMACQuqwX22lBn2rt4IX37CGDwizLP6s5gsYe5polHbDhnFefNbnnYKXjV0FMspaifpEDqg== X-Received: by 2002:a17:90a:35e6:: with SMTP id r93mr6788847pjb.44.1581021940411; Thu, 06 Feb 2020 12:45:40 -0800 (PST) Received: from rob-hp-laptop (63-158-47-182.dia.static.qwest.net. [63.158.47.182]) by smtp.gmail.com with ESMTPSA id 4sm284539pfn.90.2020.02.06.12.45.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2020 12:45:39 -0800 (PST) Received: (nullmailer pid 24630 invoked by uid 1000); Thu, 06 Feb 2020 17:54:58 -0000 Date: Thu, 6 Feb 2020 17:54:58 +0000 From: Rob Herring To: Kunihiko Hayashi Subject: Re: [PATCH v2 1/2] dt-bindings: dmaengine: Add UniPhier external DMA controller bindings Message-ID: <20200206175458.GA12845@bogus> References: <1580362048-28455-1-git-send-email-hayashi.kunihiko@socionext.com> <1580362048-28455-2-git-send-email-hayashi.kunihiko@socionext.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1580362048-28455-2-git-send-email-hayashi.kunihiko@socionext.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200206_124542_302284_68671070 X-CRM114-Status: GOOD ( 18.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Masami Hiramatsu , Jassi Brar , linux-kernel@vger.kernel.org, Masahiro Yamada , Vinod Koul , dmaengine@vger.kernel.org, Dan Williams , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 30, 2020 at 02:27:27PM +0900, Kunihiko Hayashi wrote: > Add devicetree binding documentation for external DMA controller > implemented on Socionext UniPhier SoCs. > > Signed-off-by: Kunihiko Hayashi > --- > .../bindings/dma/socionext,uniphier-xdmac.yaml | 57 ++++++++++++++++++++++ > 1 file changed, 57 insertions(+) > create mode 100644 Documentation/devicetree/bindings/dma/socionext,uniphier-xdmac.yaml > > diff --git a/Documentation/devicetree/bindings/dma/socionext,uniphier-xdmac.yaml b/Documentation/devicetree/bindings/dma/socionext,uniphier-xdmac.yaml > new file mode 100644 > index 00000000..32abf18 > --- /dev/null > +++ b/Documentation/devicetree/bindings/dma/socionext,uniphier-xdmac.yaml > @@ -0,0 +1,57 @@ > +# SPDX-License-Identifier: GPL-2.0 Dual license new bindings: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/dma/socionext,uniphier-xdmac.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Socionext UniPhier external DMA controller > + > +description: | > + This describes the devicetree bindings for an external DMA engine to perform > + memory-to-memory or peripheral-to-memory data transfer capable of supporting > + 16 channels, implemented in Socionext UniPhier SoCs. > + > +maintainers: > + - Kunihiko Hayashi > + > +allOf: > + - $ref: "dma-controller.yaml#" > + > +properties: > + compatible: > + items: > + - const: socionext,uniphier-xdmac You can drop 'items' for a single item. > + > + reg: > + minItems: 1 > + maxItems: 2 You need to say what each entry is: items: - description: ... - description: ... > + > + interrupts: > + maxItems: 1 > + > + "#dma-cells": > + const: 2 > + description: | > + DMA request from clients consists of 2 cells: > + 1. Channel index > + 2. Transfer request factor number, If no transfer factor, use 0. > + The number is SoC-specific, and this should be specified with > + relation to the device to use the DMA controller. > + > +required: > + - compatible > + - reg > + - interrupts > + - "#dma-cells" Add: additionalProperties: false > + > +examples: > + - | > + xdmac: dma-controller@5fc10000 { > + compatible = "socionext,uniphier-xdmac"; > + reg = <0x5fc10000 0x1000>, <0x5fc20000 0x800>; > + interrupts = <0 188 4>; > + #dma-cells = <2>; > + dma-channels = <16>; Not documented. You need at least 'dma-channels: true' to indicate you're using this. But you should be able to have some constraints such as 'maximum: 16'. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel