From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A573C2BA83 for ; Fri, 14 Feb 2020 08:44:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E0A2622314 for ; Fri, 14 Feb 2020 08:44:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aWDM9Qzq"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PPZBvwha" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E0A2622314 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WGoCMdWR7I3OWSOdxpUzh73Vfrty2oz6GP22dqGXrOQ=; b=aWDM9Qzqd1uq4h YGDdzZImOYgQi7sTDAfKScQMoCgrDkPH+NWYnrZ4WYv9Gi1KTO5hcvr5d4aAJ2N4Cbn1CC9Ukqpuo WVxTVKLgQkzwBoM8AWZMKOXRJ17mvK7vcBtWOej3An1PoNmhKCGljK5EGzSfB4g7yLr9HhxruNPlc PBtdb+SuY/SFBYZW7N05U9yt4jUivuB5b44oSYB89U/08NESR/CA6rsuZIzF1X7+u7Y3ouMsoq5ii xO1by036QhbPpUbmsuo0sSfUWWiCp4rjE8T6jDgwL8KB3HewuZPYZi+sDVJqAG+E6SbLeQwswf8oB ylOweDfy1gtBYBTwQUlg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2Wa0-0006UQ-3i; Fri, 14 Feb 2020 08:44:08 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2WZv-0006Tn-TX for linux-arm-kernel@lists.infradead.org; Fri, 14 Feb 2020 08:44:06 +0000 Received: by mail-wr1-x443.google.com with SMTP id g3so9901592wrs.12 for ; Fri, 14 Feb 2020 00:44:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZXq1qTTEJGxPRttgekd5c81xjN3eOF8wuB+0NRpZEVw=; b=PPZBvwhalZ1ByZiC5h4/2jZ0bic0Xxq4NIJxlOqDuxVEzVLkWTlypUMH4BF2ZY1GhA YLQwvs062k26eMuXSkUoQEdIVSVJ+yA++89VxJW8rgY7d/YRrOrwGpJ5JGEWLotutAF0 cv4LS6M2UJOxvrkh/m6bOuIhPrL+dg6Wa9Pl7kV/9INMi9GrszTM0RU1ujwB5hp4cFR6 0FmHv3z51S3uElm0MyKZQ+R1wXGCf9AARlEJyczDobDoX8oU2r+G1PMVbsa1WLCxMZpU gVnPfJ/OVnWYLH/ApiOs8J74UEMIyBostXo+Jot0rNsM16fieYijlHv8+zTU/6b1mdZy U2Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZXq1qTTEJGxPRttgekd5c81xjN3eOF8wuB+0NRpZEVw=; b=T+/rtlP3dPEMX6OkUjzdtK79DjkI5gzfuNEhO3AbCbUoG26mguUP1kWf6CGDooAPkU gf1QbZSP4M8f3QAUYtWlILmboCt6Tk9i2rgujRY4WS8PKuozzjvIZ5Ja0I8z1QPGj+bC 6ANH5OpZ85ZY1KDAm246bmTsrxW3cx8ukbfuVj0mWBsPzGjeN23h2UqehDdmoDByUOku 1N5f+EPRRNCjL49dvAP2clfnKDq12SWZMJIUk4mgPlZUN3P2VvDnCuJUlhBv6CODjhJ3 grvGJWBhfznPWRitAsyavoI/rYdEGN7hnjMeX0YkEm3X5MoueA/XUo5hadgfq+72+9bO s2Dg== X-Gm-Message-State: APjAAAVNmjS89CZCRHjbByVG5mmOKvbRaCIonSvUyZH31anWG/aZhAe7 6CW33At15VE8fJg9BWBoUlA= X-Google-Smtp-Source: APXvYqxS/TScRSLlqJlyhr//zA4jaFbzxneoXDXkbl4duj/BRqbmb25+lDDvv1nUh4I6g8T3WVp2Cw== X-Received: by 2002:a5d:4e0a:: with SMTP id p10mr2868980wrt.229.1581669841655; Fri, 14 Feb 2020 00:44:01 -0800 (PST) Received: from kedthinkpad ([213.197.144.54]) by smtp.gmail.com with ESMTPSA id s139sm6677722wme.35.2020.02.14.00.44.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Feb 2020 00:44:00 -0800 (PST) Date: Fri, 14 Feb 2020 10:43:58 +0200 From: Andrey Lebedev To: Maxime Ripard Subject: Re: [PATCH v2 2/2] ARM: sun7i: dts: Add LVDS panel support on A20 Message-ID: <20200214084358.GA25266@kedthinkpad> References: <20200210195633.GA21832@kedthinkpad> <20200212222355.17141-2-andrey.lebedev@gmail.com> <20200213094304.hf3glhgmquypxpyf@gilmour.lan> <20200213200823.GA28336@kedthinkpad> <20200214075218.huxdhmd4qfoakat2@gilmour.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200214075218.huxdhmd4qfoakat2@gilmour.lan> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200214_004403_978785_309FB511 X-CRM114-Status: GOOD ( 15.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrey Lebedev , wens@csie.org, daniel@ffwll.ch, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 14, 2020 at 08:52:18AM +0100, Maxime Ripard wrote: > > > This will create a spurious warning message for TCON1, since we > > > adjusted the driver to tell it supports LVDS, but there's no LVDS > > > reset line, so we need to make it finer grained. > > > > Yes, I can attribute two of the messages in my dmesg log [1] to this > > ("Missing LVDS properties" and "LVDS output disabled". "sun4i-tcon > > 1c0d000.lcd-controller" is indeed tcon1). And yes, I can see how they > > can be confusing to someone. > > > > I'd need some pointers on how to deal with that though (if we want to do > > it in this scope). > > Like I was mentionning, you could introduce a new compatible for each > TCON (tcon0 and tcon1) and only set the support_lvds flag for tcon0 Can you give me an idea how that compatible might look like? tcon0: lcd-controller@1c0c000 { compatible = "allwinner,sun7i-a20-tcon", "allwinner,lvds"; or tcon0: lcd-controller@1c0c000 { compatible = "allwinner,sun7i-a20-tcon", "allwinner,tcon0"; ? Or something completely different? -- Andrey Lebedev aka -.- . -.. -.. . .-. Software engineer Homepage: http://lebedev.lt/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel