From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Calvin Johnson <calvin.johnson@nxp.com>,
stuyoder@gmail.com, nleeder@codeaurora.org,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Cristi Sovaiala <cristian.sovaiala@nxp.com>,
Hanjun Guo <guohanjun@huawei.com>, Will Deacon <will@kernel.org>,
Pankaj Bansal <pankaj.bansal@nxp.com>,
jon@solid-run.com, Russell King <linux@armlinux.org.uk>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Len Brown <lenb@kernel.org>, Jason Cooper <jason@lakedaemon.net>,
Andy Wang <Andy.Wang@arm.com>,
Makarand Pawagi <makarand.pawagi@nxp.com>,
Varun Sethi <V.Sethi@nxp.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Laurentiu Tudor <laurentiu.tudor@nxp.com>,
Paul Yang <Paul.Yang@arm.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
netdev@vger.kernel.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: [EXT] Re: [PATCH] bus: fsl-mc: Add ACPI support for fsl-mc
Date: Mon, 17 Feb 2020 16:26:26 +0000 [thread overview]
Message-ID: <20200217162604.GA24829@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <384eb5378ee2b240d6ab7d89aef2d5c7@kernel.org>
On Mon, Feb 17, 2020 at 03:35:01PM +0000, Marc Zyngier wrote:
> On 2020-02-17 15:25, Lorenzo Pieralisi wrote:
> > On Mon, Feb 17, 2020 at 12:35:12PM +0000, Pankaj Bansal wrote:
>
> Hi Lorenzo,
>
> [...]
>
> > > > Side note: can you explain to me please how the MSI allocation flow
> > > > and kernel data structures/drivers are modeled in DT ? I had a quick
> > > > look at:
> > > >
> > > > drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c
> > > >
> > > > and to start with, does that code imply that we create a
> > > > DOMAIN_BUS_FSL_MC_MSI on ALL DT systems with an ITS device node ?
> > >
> > > Yes. It's being done for all DT systems having ITS node.
> >
> > This does not seem correct to me, I will let Marc comment on
> > the matter.
>
> Unfortunately, there isn't a very good way to avoid that ATM,
> other than defering the registration of the irqdomain until
> we know that a particular bus (for example a PCIe RC) is registered.
>
> I started working on that at some point, and ended up nowhere because
> no bus (PCI, FSL, or anything else) really give us the right information
> when it is actually required (when a device starts claiming interrupts).
>
> I *think* we could try a defer it until a bus root is found, and that
> this bus has a topological link to an ITS. probably invasive though,
> as you would need a set of "MSI providers" for each available irqchip
> node.
Yes I see, it is not trivial - I just raised the point while reading the
code to understand how the IRQ domain structures are connected in the DT
bootstrap case, I don't think that's an urgent issue to solve, just
noticed and reported it to make sure you are aware.
Thanks !
Lorenzo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-17 16:26 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 8:08 [PATCH] bus: fsl-mc: Add ACPI support for fsl-mc Makarand Pawagi
2020-01-28 10:58 ` Marc Zyngier
2020-01-28 11:09 ` Lorenzo Pieralisi
2020-01-31 10:35 ` [EXT] " Makarand Pawagi
2020-01-31 11:06 ` Lorenzo Pieralisi
2020-01-31 11:06 ` Marc Zyngier
2020-01-31 12:01 ` Ard Biesheuvel
2020-01-31 12:28 ` Jon Nettleton
2020-01-31 12:48 ` Robin Murphy
2020-01-31 13:11 ` Jon Nettleton
2020-01-31 13:29 ` Ard Biesheuvel
2020-01-31 13:39 ` Robin Murphy
2020-01-31 14:29 ` Andrew Lunn
2020-01-31 14:47 ` Will Deacon
2020-01-31 15:09 ` Andrew Lunn
2020-01-31 15:14 ` Jon Nettleton
2020-01-31 15:41 ` Andrew Lunn
2020-01-31 15:39 ` Russell King - ARM Linux admin
2020-01-31 15:15 ` Russell King - ARM Linux admin
2020-01-31 15:40 ` Jakub Kicinski
2020-02-01 11:49 ` Russell King - ARM Linux admin
2020-02-01 17:36 ` Jakub Kicinski
2020-02-14 15:05 ` Pankaj Bansal
2020-02-14 15:54 ` Marc Zyngier
2020-02-14 15:58 ` Pankaj Bansal
2020-02-14 16:19 ` Lorenzo Pieralisi
2020-02-14 16:35 ` Pankaj Bansal
2020-02-14 17:49 ` Lorenzo Pieralisi
2020-02-17 12:35 ` Pankaj Bansal
2020-02-17 15:25 ` Lorenzo Pieralisi
2020-02-17 15:35 ` Marc Zyngier
2020-02-17 16:26 ` Lorenzo Pieralisi [this message]
2020-02-18 8:02 ` Pankaj Bansal (OSS)
2020-02-14 16:29 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200217162604.GA24829@e121166-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=Andy.Wang@arm.com \
--cc=Paul.Yang@arm.com \
--cc=V.Sethi@nxp.com \
--cc=ard.biesheuvel@linaro.org \
--cc=calvin.johnson@nxp.com \
--cc=cristian.sovaiala@nxp.com \
--cc=guohanjun@huawei.com \
--cc=ioana.ciornei@nxp.com \
--cc=jason@lakedaemon.net \
--cc=jon@solid-run.com \
--cc=laurentiu.tudor@nxp.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=makarand.pawagi@nxp.com \
--cc=maz@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nleeder@codeaurora.org \
--cc=pankaj.bansal@nxp.com \
--cc=rjw@rjwysocki.net \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=stuyoder@gmail.com \
--cc=sudeep.holla@arm.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).