Hi Andre, On Fri, Feb 14, 2020 at 06:04:04PM +0000, Andre Przywara wrote: > > The commit c35a516a4618 ("arm64: dts: allwinner: H5: Add PMU node") > > introduced support for the PMU found on the Allwinner H5. However, the > > binding only allows for a single compatible, while the patch was adding > > two. > > Maxime, thanks for bringing this up, was that found by some > validation tool? Indeed. > And while this is true, I wonder if this was intentional? Either the YAML file: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/arm/pmu.yaml Or the text file that was there before it: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/arm/pmu.txt?id=v5.0 Make it pretty clear that only a single entry is expected > I see several other combinations of PMU compatibles in the tree. I've probably sent around 50-100 patches for DT not following the binding on Allwinner platforms alone, so it doesn't really surprise me :) Maxime