From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 516D8C34022 for ; Mon, 17 Feb 2020 17:49:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA8C120725 for ; Mon, 17 Feb 2020 17:49:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FjWD4g53"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="sxGKXCRg"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="CMKt3Dui" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA8C120725 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OxDXG16UQzR53pZKSvsHuuyP0nasvSZYrsR3J5AGenA=; b=FjWD4g536i9LVEnj8j36WQO3R 3qUO136QpNfgpt3FFrjTIJmPKC6QRW1IXBRam1RIj9UheQY3WFCS9fmnB24Vyiqulh7UJwMjV4zUN Fu03yIDqWI02unfBSNRRclymLQeUT1/uN61WaAmTX6gxlarNSU/tVK2i53xC9a8BcWmH3gJJRbezu tuEciUeDVobZ8pIJSuyEEmf4Ii//zZDiH+nF1D12Tndr8FBG5KFDxEilvU67FcGhMLxISqFMD3kzr 6Sl+JqZ+3G1l3ovvIIlzTUCsWkH007+N+6ow7SLLHosE80blrkSeC4M5I5NZmExu+FMz1h+dgqNIv 1pUOWtU2A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j3kW9-0005nH-3Z; Mon, 17 Feb 2020 17:49:13 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j3kW6-0005mw-Fi for linux-arm-kernel@lists.infradead.org; Mon, 17 Feb 2020 17:49:12 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 4EF1221E56; Mon, 17 Feb 2020 12:49:09 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 17 Feb 2020 12:49:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=aLY1NrmQJPoUslUzbJ+X7y8IPiy s7wcvOuraTt/YeSU=; b=sxGKXCRgfb1Q1zrqloCKK1VIj9L6Cs9adJQpyX+ZeJQ 0nUe+5QT5LZGFYqt19+GqOezQQYcEmx/ojmBw0nWZN4/sK5Pi6NoYIQtimKw3ISv lh1OTY6HaXUt1qGqAtTpLwj9WKnNLcVmo9HStdktVrv0PSMjI4ZlCox8uhUeXKLe EZ5MLFPgWcEI5q0tn6HAcCiqp/N1EdUno46O5va4lAAa04n7WD6I6WQK8Jy1l8h5 5/pKQTMUgXI7QTbtpyO4I1TGMeqnvjI/O611TvYVaGX1G/xTIgJc/utza1+hb+Kr O/9dhcwAxDakpPcPbkOCiI8G71Z74y4XlElFK18wCXg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=aLY1Nr mQJPoUslUzbJ+X7y8IPiys7wcvOuraTt/YeSU=; b=CMKt3DuiEdi5KHl9voHhn0 eT3qgQrkcKHVxRPCFXHzuEsLCwbV6tS8CLmLiBjvcTc9K5cf2PwgGKDgtR3DueWI VfhukW8p88oLrlFKjk0ro2XsALXKRinx1dRUjlhyYdrnq+68+XM3jIweX0dSf8g9 YLCN5KIPvFBRkFjQwbwO9f0nI9EkYBWwtWVoveUMAQa5Awn41mFgcAj+bROjTXQR SGxEdAQqQWULM7VMKj9/Qj48UGnF2tQAPJ8ngHDtpoROSfRz1DnIAanyE7mf1Q9K YPBw2yrix4oLCnmUnF5a0UH6zOvZ3so+jDG6/Qa6ZgIjc252SQDvEOoZuFYBKROA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrjeeigddutdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuffhomhgrih hnpehkvghrnhgvlhdrohhrghenucfkphepledtrdekledrieekrdejieenucevlhhushht vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrh hnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 656203280059; Mon, 17 Feb 2020 12:49:08 -0500 (EST) Date: Mon, 17 Feb 2020 18:49:06 +0100 From: Maxime Ripard To: Andre Przywara Subject: Re: [PATCH 1/2] arm64: dts: allwinner: h5: Fix PMU compatible Message-ID: <20200217174906.ecvsonprelrbvyv2@gilmour.lan> References: <20200210095600.77894-1-maxime@cerno.tech> <20200214180404.24d67f86@donnerap.cambridge.arm.com> MIME-Version: 1.0 In-Reply-To: <20200214180404.24d67f86@donnerap.cambridge.arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200217_094910_663720_D4B4BF7F X-CRM114-Status: GOOD ( 11.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Rob Herring , Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============5296927445010230644==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5296927445010230644== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ly4wtj2ngmgrqaqo" Content-Disposition: inline --ly4wtj2ngmgrqaqo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Andre, On Fri, Feb 14, 2020 at 06:04:04PM +0000, Andre Przywara wrote: > > The commit c35a516a4618 ("arm64: dts: allwinner: H5: Add PMU node") > > introduced support for the PMU found on the Allwinner H5. However, the > > binding only allows for a single compatible, while the patch was adding > > two. > > Maxime, thanks for bringing this up, was that found by some > validation tool? Indeed. > And while this is true, I wonder if this was intentional? Either the YAML file: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/arm/pmu.yaml Or the text file that was there before it: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/arm/pmu.txt?id=v5.0 Make it pretty clear that only a single entry is expected > I see several other combinations of PMU compatibles in the tree. I've probably sent around 50-100 patches for DT not following the binding on Allwinner platforms alone, so it doesn't really surprise me :) Maxime --ly4wtj2ngmgrqaqo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXkrSEgAKCRDj7w1vZxhR xThLAQDnsWgfmovYHrdmkXsc+Wa8vvVBbhF1zQCBy0o0szpUYgD/ZdyA1cOdqjCP X0EoJYp+mspfcofpzzGIrBsvWa9uwQM= =GNkn -----END PGP SIGNATURE----- --ly4wtj2ngmgrqaqo-- --===============5296927445010230644== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5296927445010230644==--