From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C985C34031 for ; Wed, 19 Feb 2020 00:59:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1EFA72173E for ; Wed, 19 Feb 2020 00:59:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rWGU022h"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="IzhUosfr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1EFA72173E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=J5HEEu01KDazPjrmDeGJ4C/svzUkffe6qW9C8qwU/rU=; b=rWGU022ht9MQCA nN06vDVmgLy+XbFoWtG0urpWRmS5DN+ywqYXNxWZVi4shHKDTrb0PU8XJIKTCwMGJhd71ZXB/EHDR uaaSzXNUH+3B6taNWkcGBtE+0s2wFgE8EmCS+GAj/iD85DSqkbhQAfZQY896k08s/kDRuPR6fw6Zg zKKGAJMAvUNGgJWJruldPIljW//sPU+/Cl0pQOE4x0PmVjqcTgE2FswJ5+o7ckyMOKx/IlLoiCvz8 x+Qmkr67/7US1t/XU74IoO9TZSueTN118CBrkiVW7VHpDUBVbkg6I+Wld+BtiQUgXC+Or0qX6U/E9 oRzJiIoU2WR0dFiPQ/sQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4Dhe-0003X8-Ks; Wed, 19 Feb 2020 00:59:02 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4Dhb-0003VG-ER for linux-arm-kernel@lists.infradead.org; Wed, 19 Feb 2020 00:59:00 +0000 Received: by mail-pl1-x643.google.com with SMTP id g6so8823502plt.2 for ; Tue, 18 Feb 2020 16:58:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=gnHrGjs2d4rz7O5tZjdzLtL+/TxZSgxldIF3J/GkKZs=; b=IzhUosfrcEGWqNX3mEcMBIr1zOOchilV9ewuFD+HoG5ciFAxqXbB4J+beO2BpkVdd2 SpEpavUmfa3Uu83TMZyvYqjzM1rYC38XzZ6PgxBVtweceDQ65TXzBQcjSOeXX0zJL559 DAcpGs9S0QzkDBHDXRYSuTfPTPAw54Oj19kC8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=gnHrGjs2d4rz7O5tZjdzLtL+/TxZSgxldIF3J/GkKZs=; b=SP/ulmqZsXKmt0uT1srt2IwMw6mzne8Ogcu+Auaw12nQYEzTCF+l+ZGk1ZRmrz5oT/ qRLHK953wJEnqvDDmUgri4pl1EfGQXc7kwskROa3c8Y5m+PFVy06jUBc0gpChHE8KSXf kQyEqXuVJIzEjeMssq+XKqiZ8VTa8tvWG959u/rfl1K6FvfqTRqGOKCvhPvVn7rB3JFe 4Xz1HjBQMfLs+oLWMPSGbAYp81vD08ery5DNs2/J5dDg8dwZVPIQbi8Zz26nfpw+vLex 9HurvhWYWVR769UDIMtygTnszmK+a+uQ4Ce9OFE5+8tPNiRtE+uCpuk3L2DKRoODGVsj FsDQ== X-Gm-Message-State: APjAAAXttNZQ3y9OMgwgvOr8Ys7CMXv1BPlVW1HtozT0bj2ErauWOXgx 7tNG4k/pJHHRNe6GUigMAjdPLA== X-Google-Smtp-Source: APXvYqyyUVqi0udPEq0kk+xXnOiXAZrDL6nmRuPiWdSBtQVB+Zr5mfeTFPLXXkm6NSzwKNuLtifp4A== X-Received: by 2002:a17:902:7244:: with SMTP id c4mr21514780pll.49.1582073937923; Tue, 18 Feb 2020 16:58:57 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id m18sm155133pgd.39.2020.02.18.16.58.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2020 16:58:57 -0800 (PST) Date: Tue, 18 Feb 2020 16:58:56 -0800 From: Kees Cook To: Sami Tolvanen Subject: Re: [PATCH v8 12/12] efi/libstub: disable SCS Message-ID: <202002181658.45F66E21F@keescook> References: <20191018161033.261971-1-samitolvanen@google.com> <20200219000817.195049-1-samitolvanen@google.com> <20200219000817.195049-13-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200219000817.195049-13-samitolvanen@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200218_165859_485876_F3B09207 X-CRM114-Status: GOOD ( 14.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , clang-built-linux@googlegroups.com, Ard Biesheuvel , Masahiro Yamada , Catalin Marinas , Jann Horn , Nick Desaulniers , linux-kernel@vger.kernel.org, Steven Rostedt , Miguel Ojeda , james.morse@arm.com, Masami Hiramatsu , Marc Zyngier , kernel-hardening@lists.openwall.com, Laura Abbott , Will Deacon , Dave Martin , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 18, 2020 at 04:08:17PM -0800, Sami Tolvanen wrote: > Disable SCS for the EFI stub and allow x18 to be used. > > Suggested-by: James Morse > Signed-off-by: Sami Tolvanen Reviewed-by: Kees Cook -Kees > --- > drivers/firmware/efi/libstub/Makefile | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/firmware/efi/libstub/Makefile b/drivers/firmware/efi/libstub/Makefile > index 98a81576213d..dff9fa5a3f1c 100644 > --- a/drivers/firmware/efi/libstub/Makefile > +++ b/drivers/firmware/efi/libstub/Makefile > @@ -30,6 +30,9 @@ KBUILD_CFLAGS := $(cflags-y) -DDISABLE_BRANCH_PROFILING \ > $(call cc-option,-fno-stack-protector) \ > -D__DISABLE_EXPORTS > > +# remove SCS flags from all objects in this directory > +KBUILD_CFLAGS := $(filter-out -ffixed-x18 $(CC_FLAGS_SCS), $(KBUILD_CFLAGS)) > + > GCOV_PROFILE := n > KASAN_SANITIZE := n > UBSAN_SANITIZE := n > -- > 2.25.0.265.gbab2e86ba0-goog > -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel