From: Sebastian Reichel <sre@kernel.org>
To: Tony Lindgren <tony@atomide.com>
Cc: daniel.thompson@linaro.org, mpartap@gmx.net,
jingoohan1@gmail.com, merlijn@wizzup.org,
kernel list <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org, martin_rysavy@centrum.cz,
nekit1000@gmail.com, tomi.valkeinen@ti.com,
Pavel Machek <pavel@ucw.cz>,
jjhiblot@ti.com, linux-omap@vger.kernel.org,
Lee Jones <lee.jones@linaro.org>,
agx@sigxcpu.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] backlight: add led-backlight driver
Date: Thu, 20 Feb 2020 00:44:37 +0100 [thread overview]
Message-ID: <20200219234437.l6ac7usebu7rnzsy@earth.universe> (raw)
In-Reply-To: <20200219194540.GD37466@atomide.com>
[-- Attachment #1.1: Type: text/plain, Size: 4820 bytes --]
On Wed, Feb 19, 2020 at 11:45:40AM -0800, Tony Lindgren wrote:
> * Pavel Machek <pavel@ucw.cz> [200219 19:15]:
> > From: Tomi Valkeinen <tomi.valkeinen@ti.com>
> >
> > This patch adds a led-backlight driver (led_bl), which is similar to
> > pwm_bl except the driver uses a LED class driver to adjust the
> > brightness in the HW. Multiple LEDs can be used for a single backlight.
> >
> > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> > Acked-by: Pavel Machek <pavel@ucw.cz>
> > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> > Acked-by: Lee Jones <lee.jones@linaro.org>
> > Acked-by: Tony Lindgren <tony@atomide.com>
> > Tested-by: Tony Lindgren <tony@atomide.com>
> > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > ---
> > drivers/video/backlight/Kconfig | 7 ++
> > drivers/video/backlight/Makefile | 1 +
> > drivers/video/backlight/led_bl.c | 260 +++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 268 insertions(+)
> > create mode 100644 drivers/video/backlight/led_bl.c
> >
> > Hi!
> >
> > Here's the version of the driver I have. AFAICT
> > default-brightness-level handling is ok, so does not need to be
> > changed.
> >
> > Lee, it would be easiest for me if you could apply it to your tree and
> > push, but given enough time I can push it to Linus, too.
>
> Oh you're using quoted-printable for patches.. Got it applied now,
> and it still works. Below is also the related dts change that
> I tested with.
>
> Feel free to pick the dts change too, naturally that should
> not be applied before the driver.
>
> If you guys instead want me to pick these both into my fixes
> branch, just let me know and I'll do the explaining why these
> are needed as fixes. Basically we no longer have a way to enable
> the LCD backlight for droid4 manually starting with v5.6-rc1
> unlike earlier.
>
> Regards,
>
> Tony
>
> 8< ------------------
> From tony Mon Sep 17 00:00:00 2001
> From: Tony Lindgren <tony@atomide.com>
> Date: Wed, 19 Feb 2020 11:25:27 -0800
> Subject: [PATCH] ARM: dts: droid4: Configure LED backlight for lm3532
>
> With the LED backlight changes merged, we still need the dts configured
> to have backlight working for droid4. Based on an earlier patch from
> Pavel Machek <pavel@ucw.cz>, let's configure the backlight but update
> the value range to be more usable.
>
> We have a range of 256 register values split into 8 steps, so we can
> generate the brightness levels backwards with:
>
> $ for i in 0 1 2 3 4 5 6 7; do echo "255 - ${i} * (256 / 8)" | bc; done
>
> To avoid more confusion why the LCD backlight is still not on, let's
> also enable LED backlight as a loadable module for omap2plus_defconfig.
>
> Cc: Merlijn Wajer <merlijn@wizzup.org>
> Cc: Pavel Machek <pavel@ucw.cz>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> arch/arm/boot/dts/motorola-mapphone-common.dtsi | 13 +++++++++++--
> arch/arm/configs/omap2plus_defconfig | 1 +
> 2 files changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/motorola-mapphone-common.dtsi b/arch/arm/boot/dts/motorola-mapphone-common.dtsi
> --- a/arch/arm/boot/dts/motorola-mapphone-common.dtsi
> +++ b/arch/arm/boot/dts/motorola-mapphone-common.dtsi
> @@ -182,6 +182,14 @@ vibrator {
> pwm-names = "enable", "direction";
> direction-duty-cycle-ns = <10000000>;
> };
> +
> + backlight: backlight {
> + compatible = "led-backlight";
> +
> + leds = <&backlight_led>;
> + brightness-levels = <31 63 95 127 159 191 223 255>;
> + default-brightness-level = <6>;
> + };
> };
>
> &dss {
> @@ -205,6 +213,8 @@ lcd0: display {
> vddi-supply = <&lcd_regulator>;
> reset-gpios = <&gpio4 5 GPIO_ACTIVE_HIGH>; /* gpio101 */
>
> + backlight = <&backlight>;
> +
> width-mm = <50>;
> height-mm = <89>;
>
> @@ -393,12 +403,11 @@ led-controller@38 {
> ramp-up-us = <1024>;
> ramp-down-us = <8193>;
>
> - led@0 {
> + backlight_led: led@0 {
> reg = <0>;
> led-sources = <2>;
> ti,led-mode = <0>;
> label = ":backlight";
> - linux,default-trigger = "backlight";
> };
>
> led@1 {
> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> --- a/arch/arm/configs/omap2plus_defconfig
> +++ b/arch/arm/configs/omap2plus_defconfig
> @@ -375,6 +375,7 @@ CONFIG_BACKLIGHT_GENERIC=m
> CONFIG_BACKLIGHT_PWM=m
> CONFIG_BACKLIGHT_PANDORA=m
> CONFIG_BACKLIGHT_GPIO=m
> +CONFIG_BACKLIGHT_LED=m
> CONFIG_FRAMEBUFFER_CONSOLE=y
> CONFIG_FRAMEBUFFER_CONSOLE_ROTATION=y
> CONFIG_LOGO=y
Finally :)
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
-- Sebastian
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-19 23:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 19:14 [PATCH] backlight: add led-backlight driver Pavel Machek
2020-02-19 19:45 ` Tony Lindgren
2020-02-19 20:53 ` Pavel Machek
2020-02-19 21:15 ` Tony Lindgren
2020-02-19 23:54 ` Pavel Machek
2020-02-19 23:44 ` Sebastian Reichel [this message]
2020-02-20 14:54 ` Tony Lindgren
2020-02-20 7:48 ` Lee Jones
2020-02-20 15:09 ` Tony Lindgren
2020-02-20 8:29 ` Guido Günther
2020-02-20 23:41 ` Camera LED on Librem 5 was " Pavel Machek
2020-08-14 17:23 ` Guido Günther
2020-08-23 21:22 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219234437.l6ac7usebu7rnzsy@earth.universe \
--to=sre@kernel.org \
--cc=agx@sigxcpu.org \
--cc=daniel.thompson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=jjhiblot@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=martin_rysavy@centrum.cz \
--cc=merlijn@wizzup.org \
--cc=mpartap@gmx.net \
--cc=nekit1000@gmail.com \
--cc=pavel@ucw.cz \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).