From: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: devicetree@vger.kernel.org,
Philipp Zabel <p.zabel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
lukas@mntmn.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Laurentiu Palcu <laurentiu.palcu@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
agx@sigxcpu.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 3/4] dt-bindings: display: imx: add bindings for DCSS
Date: Wed, 26 Feb 2020 09:58:23 +0200 [thread overview]
Message-ID: <20200226075823.rxaw75gsnpbrcalf@fsr-ub1864-141> (raw)
In-Reply-To: <7716263db71ca07a52e5a562882f0ae7f35fee48.camel@pengutronix.de>
Hi Lucas,
On Mon, Feb 24, 2020 at 06:21:57PM +0100, Lucas Stach wrote:
> On Fr, 2019-12-06 at 11:52 +0200, Laurentiu Palcu wrote:
> > Add bindings for iMX8MQ Display Controller Subsystem.
> >
> > Signed-off-by: Laurentiu Palcu <laurentiu.palcu@nxp.com>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > ---
> > .../bindings/display/imx/nxp,imx8mq-dcss.yaml | 86 ++++++++++++++++++++++
> > 1 file changed, 86 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/display/imx/nxp,imx8mq-dcss.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/display/imx/nxp,imx8mq-dcss.yaml b/Documentation/devicetree/bindings/display/imx/nxp,imx8mq-dcss.yaml
> > new file mode 100644
> > index 00000000..efd2494
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/imx/nxp,imx8mq-dcss.yaml
> > @@ -0,0 +1,86 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +# Copyright 2019 NXP
> > +%YAML 1.2
> > +---
> > +$id: "http://devicetree.org/schemas/display/imx/nxp,imx8mq-dcss.yaml#"
> > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> > +
> > +title: iMX8MQ Display Controller Subsystem (DCSS)
> > +
> > +maintainers:
> > + - Laurentiu Palcu <laurentiu.palcu@nxp.com>
> > +
> > +description:
> > +
> > + The DCSS (display controller sub system) is used to source up to three
> > + display buffers, compose them, and drive a display using HDMI 2.0a(with HDCP
> > + 2.2) or MIPI-DSI.
>
> HDMI 2.0a and MIPI_DSI are not really properties of the DCSS, but
> rather the connected bridges. Maybe just drop them here?
I'm a bit confused... Drop what here?
>
> > The DCSS is intended to support up to 4kp60 displays. HDR10
> > + image processing capabilities are included to provide a solution capable of
> > + driving next generation high dynamic range displays.
> > +
> > +properties:
> > + compatible:
> > + const: nxp,imx8mq-dcss
> > +
> > + reg:
> > + maxItems: 2
> > +
> > + interrupts:
> > + maxItems: 3
> > + items:
> > + - description: Context loader completion and error interrupt
> > + - description: DTG interrupt used to signal context loader trigger time
> > + - description: DTG interrupt for Vblank
> > +
> > + interrupt-names:
> > + maxItems: 3
> > + items:
> > + - const: ctx_ld
>
> Can we make this just "ctxld" for a bit more consistency with the name
> below?
Fair enough. Will change.
>
> > + - const: ctxld_kick
> > + - const: vblank
> > +
> > + clocks:
> > + maxItems: 5
> > + items:
> > + - description: Display APB clock for all peripheral PIO access interfaces
> > + - description: Display AXI clock needed by DPR, Scaler, RTRAM_CTRL
> > + - description: RTRAM clock
> > + - description: Pixel clock, can be driver either by HDMI phy clock or MIPI
> > + - description: DTRC clock, needed by video decompressor
> > +
> > + clock-names:
> > + items:
> > + - const: apb
> > + - const: axi
> > + - const: rtrm
> > + - const: pix
> > + - const: dtrc
> > +
> > + port@0:
> > + type: object
> > + description: A port node pointing to a hdmi_in or mipi_in port node.
>
> "A port node pointing to the input port of a HDMI/DP or MIPI display
> bridge".
Okay, your description's sounds better. I'll add it in the next revision.
Thanks,
laurentiu
>
> > +
> > +examples:
> > + - |
> > + dcss: display-controller@32e00000 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + compatible = "nxp,imx8mq-dcss";
> > + reg = <0x32e00000 0x2d000>, <0x32e2f000 0x1000>;
> > + interrupts = <6>, <8>, <9>;
> > + interrupt-names = "ctx_ld", "ctxld_kick", "vblank";
> > + interrupt-parent = <&irqsteer>;
> > + clocks = <&clk 248>, <&clk 247>, <&clk 249>,
> > + <&clk 254>,<&clk 122>;
> > + clock-names = "apb", "axi", "rtrm", "pix", "dtrc";
> > + assigned-clocks = <&clk 107>, <&clk 109>, <&clk 266>;
> > + assigned-clock-parents = <&clk 78>, <&clk 78>, <&clk 3>;
> > + assigned-clock-rates = <800000000>,
> > + <400000000>;
> > + port@0 {
> > + dcss_out: endpoint {
> > + remote-endpoint = <&hdmi_in>;
> > + };
> > + };
> > + };
> > +
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Laurentiu
NXP
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-26 7:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 9:52 [PATCH v3 0/4] Add support for iMX8MQ Display Controller Subsystem Laurentiu Palcu
2019-12-06 9:52 ` [PATCH v3 3/4] dt-bindings: display: imx: add bindings for DCSS Laurentiu Palcu
2020-02-24 17:21 ` Lucas Stach
2020-02-26 7:58 ` Laurentiu Palcu [this message]
2020-02-27 11:52 ` Philipp Zabel
2019-12-06 9:52 ` [PATCH v3 4/4] arm64: dts: imx8mq: add DCSS node Laurentiu Palcu
2020-02-24 17:23 ` Lucas Stach
2020-02-26 8:02 ` Laurentiu Palcu
2020-02-21 12:15 ` [PATCH v3 0/4] Add support for iMX8MQ Display Controller Subsystem Guido Günther
[not found] ` <1575625964-27102-3-git-send-email-laurentiu.palcu@nxp.com>
2020-02-24 17:27 ` [PATCH v3 2/4] drm/imx: Add initial support for DCSS on iMX8MQ Lucas Stach
2020-02-26 7:52 ` Laurentiu Palcu
[not found] ` <03b551925d079fcc151239afa735562332cfd557.camel@pengutronix.de>
[not found] ` <20200306095830.sa5eig67phngr3fa@fsr-ub1864-141>
2020-03-06 10:20 ` Philipp Zabel
2020-03-06 11:12 ` Laurentiu Palcu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226075823.rxaw75gsnpbrcalf@fsr-ub1864-141 \
--to=laurentiu.palcu@oss.nxp.com \
--cc=agx@sigxcpu.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=laurentiu.palcu@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@mntmn.com \
--cc=p.zabel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).