From: afzal mohammed <afzal.mohd.ma@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>,
Lubomir Rintel <lkundrak@v3.sk>,
Russell King <linux@armlinux.org.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Enrico Weigelt <info@metux.net>,
Kate Stewart <kstewart@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: afzal mohammed <afzal.mohd.ma@gmail.com>
Subject: [PATCH v3] ARM: mmp: replace setup_irq() by request_irq()
Date: Sun, 1 Mar 2020 17:52:41 +0530 [thread overview]
Message-ID: <20200301122243.4129-1-afzal.mohd.ma@gmail.com> (raw)
request_irq() is preferred over setup_irq(). Invocations of setup_irq()
occur after memory allocators are ready.
Per tglx[1], setup_irq() existed in olden days when allocators were not
ready by the time early interrupts were initialized.
Hence replace setup_irq() by request_irq().
[1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos
Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com>
---
Hi sub-arch maintainers,
If the patch is okay, please take it thr' your tree.
Regards
afzal
v3:
* Split out from series, also split out from ARM patch to subarch level
as Thomas suggested to take it thr' respective maintainers
* Modify string displayed in case of error as suggested by Thomas
* Re-arrange code as required to improve readability
* Remove irrelevant parts from commit message & improve
v2:
* Replace pr_err("request_irq() on %s failed" by
pr_err("%s: request_irq() failed"
* Commit message massage
arch/arm/mach-mmp/time.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/arch/arm/mach-mmp/time.c b/arch/arm/mach-mmp/time.c
index c65cfc1ad99b..049a65f47b42 100644
--- a/arch/arm/mach-mmp/time.c
+++ b/arch/arm/mach-mmp/time.c
@@ -175,13 +175,6 @@ static void __init timer_config(void)
__raw_writel(0x2, mmp_timer_base + TMR_CER);
}
-static struct irqaction timer_irq = {
- .name = "timer",
- .flags = IRQF_TIMER | IRQF_IRQPOLL,
- .handler = timer_interrupt,
- .dev_id = &ckevt,
-};
-
void __init mmp_timer_init(int irq, unsigned long rate)
{
timer_config();
@@ -190,7 +183,9 @@ void __init mmp_timer_init(int irq, unsigned long rate)
ckevt.cpumask = cpumask_of(0);
- setup_irq(irq, &timer_irq);
+ if (request_irq(irq, timer_interrupt, IRQF_TIMER | IRQF_IRQPOLL,
+ "timer", &ckevt))
+ pr_err("Failed to request irq %d (timer)\n", irq);
clocksource_register_hz(&cksrc, rate);
clockevents_config_and_register(&ckevt, rate, MIN_DELTA, MAX_DELTA);
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2020-03-01 12:23 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-01 12:22 afzal mohammed [this message]
2020-03-08 14:53 ` [PATCH v3] ARM: mmp: replace setup_irq() by request_irq() afzal mohammed
[not found] ` <20200308161903.GA156645@furthur.local>
2020-03-01 12:22 ` [PATCH v3] ARM: iop32x: " afzal mohammed
2020-03-09 12:19 ` [PATCH v3] ARM: mmp: " afzal mohammed
-- strict thread matches above, loose matches on Subject: below --
2020-03-01 12:23 [PATCH v3] ARM: orion: " afzal mohammed
2020-03-01 15:44 ` Andrew Lunn
2020-03-08 14:37 ` afzal mohammed
2020-03-09 16:17 ` Gregory CLEMENT
2020-03-13 20:39 ` Gregory CLEMENT
2020-03-01 12:23 [PATCH v3] ARM: spear: " afzal mohammed
2020-03-02 3:17 ` Viresh Kumar
2020-03-01 12:21 [PATCH v3] ARM: ep93xx: Replace " afzal mohammed
2020-03-01 16:21 ` Alexander Sverdlin
2020-03-01 12:19 [PATCH v3] ARM: OMAP: replace " afzal mohammed
2020-03-04 16:34 ` Tony Lindgren
2020-03-13 15:45 ` [PATCH v3] ARM: " afzal mohammed
2020-03-17 4:37 ` afzal mohammed
2020-03-25 11:43 ` afzal mohammed
2020-03-27 10:46 ` afzal mohammed
2020-03-27 10:55 ` Arnd Bergmann
2020-03-27 11:10 ` afzal mohammed
2020-03-27 11:29 ` afzal mohammed
2020-03-27 11:58 ` Arnd Bergmann
2020-03-27 12:41 ` [PATCH v4 1/5] ARM: ep93xx: Replace " afzal mohammed
2020-03-27 12:44 ` [PATCH v4 2/5] ARM: spear: replace " afzal mohammed
2020-03-27 12:44 ` [PATCH v4 3/5] ARM: cns3xxx: " afzal mohammed
2020-03-27 12:44 ` [PATCH v4 4/5] ARM: mmp: " afzal mohammed
2020-03-27 12:44 ` [PATCH v4 5/5] ARM: iop32x: " afzal mohammed
2020-03-27 12:53 ` [PATCH v3] ARM: " afzal mohammed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200301122243.4129-1-afzal.mohd.ma@gmail.com \
--to=afzal.mohd.ma@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=info@metux.net \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lkundrak@v3.sk \
--cc=tglx@linutronix.de \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).