From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD50FC3F2CD for ; Sun, 1 Mar 2020 15:44:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AFC7221D56 for ; Sun, 1 Mar 2020 15:44:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aIB4bCI6"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="1nqV04ey" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AFC7221D56 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8ul5axNCctzYt6reHmbEinehJNmSxwfIwnMR5PgPwdQ=; b=aIB4bCI6IV3Klo CUgHMrwITm2hWAJg5XsB0Xgplu6FfciZkYpD9f8tOV87T3pvGLDWSudwLWk1kBned5KQWxnNzV8Bd SbyRt34WjM4pfyp2dR282Rc/+SarszL0d9WQtiUcwprSpWuVjz5zEuFU7VCEgHnJ8zwJ0JoAIyFxT vnjmTVxmmgr8Ak3x3Y2358UpIMWj3urQLuiJRbaeNjpnMoe/uzFkNCyxczurEie7oydacRopuOQOs mYskpkc7iEsCyfHK72bksfIyxqBT9Mps4vQEXEXu0RkGQLeEEVQ2AUaqiA3yNwIbq1RuguEEATcCE q7l02fva8ACKuczl84HA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j8Qlv-0005TR-DL; Sun, 01 Mar 2020 15:44:51 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j8Qls-0005Ry-2S for linux-arm-kernel@lists.infradead.org; Sun, 01 Mar 2020 15:44:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=IlyHdjJVYeiY6SHvj+K0w+uik9xmnYdyhX7pDileyQA=; b=1nqV04eyIoqa16ayNQlmYccMVX P53vQGdhvx3HAy8mDTKpKokOwRTeZolJeTKDv4Zry9y/OyydKcnT6u+YvuvVduBiG+GwRlj/FEqlg egYaQVIdCQTq1hx9fxVjgoVivm6qy8svOrbKYGFurPXoBcBVvIQV82C5/Rd04OwoOnjo=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1j8Qlf-00082z-TY; Sun, 01 Mar 2020 16:44:35 +0100 Date: Sun, 1 Mar 2020 16:44:35 +0100 From: Andrew Lunn To: afzal mohammed Subject: Re: [PATCH v3] ARM: orion: replace setup_irq() by request_irq() Message-ID: <20200301154435.GJ6305@lunn.ch> References: <20200301122330.4296-1-afzal.mohd.ma@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200301122330.4296-1-afzal.mohd.ma@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200301_074448_114332_5772D851 X-CRM114-Status: UNSURE ( 7.20 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Cooper , Viresh Kumar , Gregory Clement , Russell King , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Mar 01, 2020 at 05:53:30PM +0530, afzal mohammed wrote: > request_irq() is preferred over setup_irq(). Invocations of setup_irq() > occur after memory allocators are ready. > > Per tglx[1], setup_irq() existed in olden days when allocators were not > ready by the time early interrupts were initialized. > > Hence replace setup_irq() by request_irq(). > > [1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos > > Signed-off-by: afzal mohammed Reviewed-by: Andrew Lunn Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel