From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F43BC3F2D1 for ; Wed, 4 Mar 2020 05:22:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3ECC920842 for ; Wed, 4 Mar 2020 05:22:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Jx4RcrhH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3ECC920842 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Qu8pu5EoBz+b/3iSAWTsxb/TqAdr8yaYNKWovedYo/k=; b=Jx4RcrhHrFE4ru ig3EaQBiyngnbdGUpgTxgpaHKKxQSpDYX908cuUv4UTT4/1QqzK7Iu5H2RInHdPQvqqUEQ8m6LuH0 5oNMD4C01xqFugi4EoBi5E2T668IpeLwjolGrUThMgMLnyFAvW38eYhKcxAX10lsVyEk/k+CjO0JI hOCWAAhxF3yM4h/UfYaNNo0bTa/omDBAEE0e6GUwkD1Vg0VylXilvAgrEn3QxRYfSQeI2F202hEZY Mpz2pw76bOGUfhSZYMH8ABWXpcs0kL6eNjP1bsVKqqwZ4CnYVn/DEo7ZVvdfcSh520IbMU/NEnEFK KMvvBaMhvn8+N6MGjrTA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j9MUU-0005gT-M0; Wed, 04 Mar 2020 05:22:42 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j9MUQ-0005fy-Qv for linux-arm-kernel@lists.infradead.org; Wed, 04 Mar 2020 05:22:40 +0000 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j9MUO-0005cz-Uc; Wed, 04 Mar 2020 06:22:36 +0100 Received: from ore by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1j9MUN-0005kn-F5; Wed, 04 Mar 2020 06:22:35 +0100 Date: Wed, 4 Mar 2020 06:22:35 +0100 From: Oleksij Rempel To: Biwen Li Subject: Re: [EXT] Re: [v6] i2c: imx: support slave mode for imx I2C driver Message-ID: <20200304052235.mvpjqa2u56joew3r@pengutronix.de> References: <20191203114809.21226-1-biwen.li@nxp.com> <20191204100005.r56huywxa7h3c6zr@pengutronix.de> <9a1a00c1-e9fa-36a1-0e79-3492d9b98d9f@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 06:19:12 up 109 days, 20:37, 124 users, load average: 0.07, 0.06, 0.02 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200303_212238_874017_FA17B2F8 X-CRM114-Status: GOOD ( 28.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aisheng Dong , "linux-kernel@vger.kernel.org" , "wsa@the-dreams.de" , "festevam@gmail.com" , Sascha Hauer , Xiaobo Xie , Leo Li , "linux-i2c@vger.kernel.org" , Clark Wang , dl-linux-imx , "kernel@pengutronix.de" , Jiafei Pan , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" , Laurentiu Tudor Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Biwen, On Wed, Mar 04, 2020 at 04:13:03AM +0000, Biwen Li wrote: > Hi Wolfram, > > Any comments? Wolfram is waiting until you react to our comments. Until this is not happened, I will not ACK this patch and Wolfram will not take it. regards, Oleksij > Best Regards, > Biwen Li > > > > > Hi, > > > > On 04.12.19 11:00, Sascha Hauer wrote: > > > Hi, > > > > > > The patch looks ok to me now, but I still do not like the #ifdeffery > > > around CONFIG_I2C_SLAVE. With the patch I just sent (You are on Cc:) > > > we could apply the following on your patch which makes it more > > > readable and increases compile coverage. > > > > > > Wolfram, Biwen, what do you think? > > > > > > RCAR depends on slave: > > config I2C_RCAR > > > > tristate "Renesas R-Car I2C Controller" > > > > depends on ARCH_RENESAS || COMPILE_TEST > > > > select I2C_SLAVE > > see: > > drivers/i2c/busses/i2c-rcar.c > > > > So, I would suggest to do the same in imx. > > > > So far, I tested this patch on iMX6S. It works in one board (i2c-gpio + i2c-imx) > > and two board (i2c-imx + i2c-imx) configuration. > > Tested-by: Oleksij Rempel > > > > > > > > > > Sascha > > > > > > ---------------------------8<------------------------------ > > > > > > From 52f7c2bf59db61d4b27b59ca6404136e3ed77310 Mon Sep 17 > > 00:00:00 > > > 2001 > > > From: Sascha Hauer > > > Date: Wed, 4 Dec 2019 10:56:34 +0100 > > > Subject: [PATCH] fixup! i2c: imx: support slave mode for imx I2C > > > driver > > > > > > --- > > > drivers/i2c/busses/i2c-imx.c | 21 ++++++++++----------- > > > 1 file changed, 10 insertions(+), 11 deletions(-) > > > > > > diff --git a/drivers/i2c/busses/i2c-imx.c > > > b/drivers/i2c/busses/i2c-imx.c index 40ccfca600bf..c5d9ae8226cd 100644 > > > --- a/drivers/i2c/busses/i2c-imx.c > > > +++ b/drivers/i2c/busses/i2c-imx.c > > > @@ -203,9 +203,7 @@ struct imx_i2c_struct { > > > struct pinctrl_state *pinctrl_pins_gpio; > > > > > > struct imx_i2c_dma *dma; > > > -#if IS_ENABLED(CONFIG_I2C_SLAVE) > > > struct i2c_client *slave; > > > -#endif > > > }; > > > > > > static const struct imx_i2c_hwdata imx1_i2c_hwdata = { @@ -913,12 > > > +911,10 @@ static int i2c_imx_xfer(struct i2c_adapter *adapter, > > > > > > dev_dbg(&i2c_imx->adapter.dev, "<%s>\n", __func__); > > > > > > -#if IS_ENABLED(CONFIG_I2C_SLAVE) > > > if (i2c_imx->slave) { > > > dev_err(&i2c_imx->adapter.dev, "Please not do operations > > of master mode in slave mode"); > > > return -EBUSY; > > > } > > > -#endif > > > > > > result = pm_runtime_get_sync(i2c_imx->adapter.dev.parent); > > > if (result < 0) > > > @@ -1068,7 +1064,6 @@ static u32 i2c_imx_func(struct i2c_adapter > > *adapter) > > > | I2C_FUNC_SMBUS_READ_BLOCK_DATA; > > > } > > > > > > -#if IS_ENABLED(CONFIG_I2C_SLAVE) > > > static int i2c_imx_slave_init(struct imx_i2c_struct *i2c_imx) > > > { > > > int temp; > > > @@ -1159,6 +1154,10 @@ static int i2c_imx_reg_slave(struct i2c_client > > *client) > > > { > > > struct imx_i2c_struct *i2c_imx = i2c_get_adapdata(client->adapter); > > > int ret; > > > + > > > + if (!IS_ENABLED(CONFIG_I2C_SLAVE)) > > > + return -EINVAL; > > > + > > > if (i2c_imx->slave) > > > return -EBUSY; > > > > > > @@ -1173,6 +1172,9 @@ static int i2c_imx_unreg_slave(struct i2c_client > > *client) > > > { > > > struct imx_i2c_struct *i2c_imx = > > > i2c_get_adapdata(client->adapter); > > > > > > + if (!IS_ENABLED(CONFIG_I2C_SLAVE)) > > > + return -EINVAL; > > > + > > > if (!i2c_imx->slave) > > > return -EINVAL; > > > > > > @@ -1188,15 +1190,12 @@ static int i2c_imx_unreg_slave(struct > > > i2c_client *client) > > > > > > return 0; > > > } > > > -#endif > > > > > > static const struct i2c_algorithm i2c_imx_algo = { > > > .master_xfer = i2c_imx_xfer, > > > .functionality = i2c_imx_func, > > > -#if IS_ENABLED(CONFIG_I2C_SLAVE) > > > .reg_slave = i2c_imx_reg_slave, > > > .unreg_slave = i2c_imx_unreg_slave, > > > -#endif > > > }; > > > > > > static irqreturn_t i2c_imx_isr(int irq, void *dev_id) @@ -1208,10 > > > +1207,10 @@ static irqreturn_t i2c_imx_isr(int irq, void *dev_id) > > > > > > if (status & I2SR_IIF) { > > > i2c_imx_clr_if_bit(status, i2c_imx); -#if > > > IS_ENABLED(CONFIG_I2C_SLAVE) > > > - if (i2c_imx->slave) > > > + > > > + if (IS_ENABLED(CONFIG_I2C_SLAVE) && i2c_imx->slave) > > > return i2c_imx_slave_isr(i2c_imx); -#endif > > > + > > > i2c_imx->i2csr = status; > > > return i2c_imx_master_isr(i2c_imx); > > > } > > > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel