From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B3B8C3F2D2 for ; Thu, 5 Mar 2020 20:30:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3AD9620848 for ; Thu, 5 Mar 2020 20:30:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CqXNEbM6"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="x19KiQKq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3AD9620848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uwEUuCltstju352omM67c1Qm8pNDlpQuxVPJRRZasEc=; b=CqXNEbM6nMNo7U cFOXFetib0TINfjSvLMxD/wuQTpqhwcX69+Qq5ensaeKO6JsZmGHMcKAKPOHkPnvaQ1n5OzdHqEZl cRVLoMTJCCxESWMtcLTFzVc/veaTFut2PMUR3fYyAeBzXXywiYo0qvK0fB/8DOn64b0/IfGlIamy8 MiRGawOjLHUVl1lexQtW1CSNG3Md+1N7KPUsJiHzIXRZ/h2Rk+5ECrVE4mrf3XA0Q5HPOy4mcPpB3 KLLw55rBHeZ35HQzwluee1ZiovGKPRrEuAveu8JPX0TEwnvy66Heaqov7hh4+xs2IWVtG6MbKoe0x 5XRoeRUClXQT9Nqt/VIQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j9x8Z-00006Y-RR; Thu, 05 Mar 2020 20:30:31 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j9x8X-00005N-3O for linux-arm-kernel@lists.infradead.org; Thu, 05 Mar 2020 20:30:30 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ED451207FD; Thu, 5 Mar 2020 20:30:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583440225; bh=gt/le5mO5Xx1BfHObBoqvmbUMLMKT8Q0XK7Pu9v9giM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=x19KiQKqY1X1+7kf1D81rS5DbRwJtIuzhyAipxD6PRmdNJWI4hFTrw769XrdCnI8S YMBwlil2x3oNO/cG5Tc5EihKx2lcNz47jeu1sHJRQkAmsh8YnfhyRa92JND6d1nMq8 PFefMILxla0/vm6nqCMvCqVAf4AhDbepZRRH3BMw= Date: Thu, 5 Mar 2020 20:30:21 +0000 From: Will Deacon To: Mark Rutland Subject: Re: [PATCH] arm64: entry: unmask IRQ in el0_sp() Message-ID: <20200305203021.GA29446@willie-the-truck> References: <20200228145942.10675-1-mark.rutland@arm.com> <2680f3b0-a457-ba9f-322c-2c6e9f079e87@arm.com> <20200228160809.GK36089@lakrids.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200228160809.GK36089@lakrids.cambridge.arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200305_123029_166084_115DCC07 X-CRM114-Status: GOOD ( 12.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , James Morse , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 28, 2020 at 04:08:09PM +0000, Mark Rutland wrote: > On Fri, Feb 28, 2020 at 03:37:46PM +0000, James Morse wrote: > > On 28/02/2020 14:59, Mark Rutland wrote: > > > Let's do so now, and make it interruptible as with most other > > > synchronous exception handlers. > > > > I think you want: > > Fixes: bfe298745afc9548 ("arm64: entry-common: don't touch daif before bp-hardening") > > > > on this as, bfe298745afc9548 changed the behaviour: local_daif_restore(DAIF_PROCCTX) was > > called before arm64_notify_die(), now its not. > > > > With that, > > Reviewed-by: James Morse > > Ah; I missed that subtlety. > > I assume that Catalin can fold those in when applying. Otherwise I'll > add them for a v2. If you want v2 to go in as a fix, please can you explain why this is a problem (beyond disabling interrupts for longer than necessary) in the commit message? Cheers, Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel