From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDC59C10F27 for ; Wed, 11 Mar 2020 10:50:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B0D6120848 for ; Wed, 11 Mar 2020 10:50:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AJJ+iGFX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B0D6120848 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ICXq176Rsa3B6BD9xzL4/gHRci+MBPf5tBF7OgLBxgg=; b=AJJ+iGFXF8cHwd AO4nj+Pbp7LMu1QDHu9L5ZiCQSPNRXeGRAKvxGgie1aOrCWcWJErxXnuhI2lICy/0r0ItMuwCGTGS lSkHAqcCwSgjNonTeuXbZgWb8peddwZh9tAgbxEwY4jWz/qlm9wIIBbpSBNBlGqF887Y4D6sxTxxR 0zCVd88a/+ulq6N7NdhkmoLZXbzateH6du7YDdT0Gs47CVKdZkfdNnQoMdYh/F5TORCPUSVR+/NNn C5hV80iVHSaiD94zufHH/FAzRILSX9PlRS+cGwnkfbylDFjOOglDV2Ce+5VeWpypdo86R+ofiAqt0 QmcJilqTKWkOqBZSH/bA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBywY-00081m-1s; Wed, 11 Mar 2020 10:50:30 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBywU-00081O-G2 for linux-arm-kernel@lists.infradead.org; Wed, 11 Mar 2020 10:50:28 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CBB891FB; Wed, 11 Mar 2020 03:50:23 -0700 (PDT) Received: from arrakis.emea.arm.com (arrakis.cambridge.arm.com [10.1.196.71]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2E9303F6CF; Wed, 11 Mar 2020 03:50:22 -0700 (PDT) Date: Wed, 11 Mar 2020 10:50:20 +0000 From: Catalin Marinas To: Amit Kachhap Subject: Re: [PATCH v6 07/18] arm64: cpufeature: Move cpu capability helpers inside C file Message-ID: <20200311105020.GA3216816@arrakis.emea.arm.com> References: <1583476525-13505-1-git-send-email-amit.kachhap@arm.com> <1583476525-13505-8-git-send-email-amit.kachhap@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200311_035026_580926_F57FE5C0 X-CRM114-Status: GOOD ( 16.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kees Cook , Suzuki K Poulose , Kristina Martsenko , Dave Martin , Mark Brown , James Morse , Ramana Radhakrishnan , Vincenzo Frascino , Will Deacon , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 10, 2020 at 06:23:15PM +0530, Amit Kachhap wrote: > On 3/10/20 5:50 PM, Vincenzo Frascino wrote: > > On 3/6/20 6:35 AM, Amit Daniel Kachhap wrote: > > > > [...] > > > > > -static inline bool > > > -cpucap_late_cpu_optional(const struct arm64_cpu_capabilities *cap) > > > -{ > > > - return !!(cap->type & ARM64_CPUCAP_OPTIONAL_FOR_LATE_CPU); > > > -} > > > - > > > -static inline bool > > > -cpucap_late_cpu_permitted(const struct arm64_cpu_capabilities *cap) > > > -{ > > > - return !!(cap->type & ARM64_CPUCAP_PERMITTED_FOR_LATE_CPU); > > > -} > > > - > > > /* > > > * Generic helper for handling capabilties with multiple (match,enable) pairs > > > * of call backs, sharing the same capability bit. > > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > > > index b12e386..865dce6 100644 > > > --- a/arch/arm64/kernel/cpufeature.c > > > +++ b/arch/arm64/kernel/cpufeature.c > > > @@ -1363,6 +1363,19 @@ static bool can_use_gic_priorities(const struct arm64_cpu_capabilities *entry, > > > } > > > #endif > > > +/* Internal helper functions to match cpu capability type */ > > > +static bool > > > +cpucap_late_cpu_optional(const struct arm64_cpu_capabilities *cap) > > > +{ > > > + return !!(cap->type & ARM64_CPUCAP_OPTIONAL_FOR_LATE_CPU); > > > +} > > > + > > > +static bool > > > +cpucap_late_cpu_permitted(const struct arm64_cpu_capabilities *cap) > > > +{ > > > + return !!(cap->type & ARM64_CPUCAP_PERMITTED_FOR_LATE_CPU); > > > +} > > > + > > > static const struct arm64_cpu_capabilities arm64_features[] = { > > > { > > > .desc = "GIC system register CPU interface", > > > > > > > Seems that the signature of the functions above is changed during the migration. > > In particular you dropped "inline". Is there any specific reason? > > Earlier Catalin pointed me here [1]. I guess its not a hot-path function. > > [1]: https://www.spinics.net/lists/arm-kernel/msg789696.html Indeed, it had to be static inline in a header but not anymore in a .c file. Also if it's really essential to be inlined and the compiler doesn't do this automatically, use __always_inline. But my preference is not to bother unless you back it up by numbers. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel