From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3176FC10F27 for ; Wed, 11 Mar 2020 10:59:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF6102146E for ; Wed, 11 Mar 2020 10:59:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PBU75AH8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF6102146E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=daa/oJh6NxMfJC2Czs9DsDTcmTCGDR4Kuo/hjVlNe0c=; b=PBU75AH8xKRWj6 42tKb3tjsENJORyPLDm/VwiYEDDapxM1F0tCWmeDNE0DWDq5V8xBFqeNs9HAt6GnSA/dmyYBWjPCO miiKBQxL8ORKk1+s6WsSMdeziUlNHJxfzgigMFednrYsvgiXTpBqKalNvHmE13G6zffUFnGrz4IK7 kz9Fb98ooELC1FBTYl1QQw2lVI82UVZR1pqC7Nl65i5AzKfZVsj4NuRDEuCiII17oCcloS1yLGL0x UibiWpq9+VDZW8hTVm7UCaSEOO5RYT0y8Uy63+tkkB1N0/PoXSYHpbbX+V5Lu+ObiW9Iou7Ynh94q 1jvVmeuW+Qd1M590zUZA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBz5e-0003oD-7i; Wed, 11 Mar 2020 10:59:54 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBz5b-0003nb-05 for linux-arm-kernel@lists.infradead.org; Wed, 11 Mar 2020 10:59:52 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 147311FB; Wed, 11 Mar 2020 03:59:50 -0700 (PDT) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 335663F6CF; Wed, 11 Mar 2020 03:59:49 -0700 (PDT) Date: Wed, 11 Mar 2020 10:59:37 +0000 From: Andre Przywara To: Chen-Yu Tsai Subject: Re: [PATCH 1/3] ARM: dts: sun8i: r40: Move AHCI device node based on address order Message-ID: <20200311105937.040cd947@donnerap.cambridge.arm.com> In-Reply-To: <20200310174709.24174-2-wens@kernel.org> References: <20200310174709.24174-1-wens@kernel.org> <20200310174709.24174-2-wens@kernel.org> Organization: ARM X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200311_035951_084199_4B02E761 X-CRM114-Status: GOOD ( 16.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Chen-Yu Tsai , linux-kernel@vger.kernel.org, Maxime Ripard Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 11 Mar 2020 01:47:07 +0800 Chen-Yu Tsai wrote: > From: Chen-Yu Tsai > > When the AHCI device node was added, it was added in the wrong location > in the device tree file. The device nodes should be sorted by register > address. > > Move the device node to before EHCI1, where it belongs. > > Fixes: 41c64d3318aa ("ARM: dts: sun8i: r40: add sata node") > Signed-off-by: Chen-Yu Tsai > --- > arch/arm/boot/dts/sun8i-r40.dtsi | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/arch/arm/boot/dts/sun8i-r40.dtsi b/arch/arm/boot/dts/sun8i-r40.dtsi > index d5442b5b6fd2..b278686d0c22 100644 > --- a/arch/arm/boot/dts/sun8i-r40.dtsi > +++ b/arch/arm/boot/dts/sun8i-r40.dtsi > @@ -307,6 +307,17 @@ crypto: crypto@1c15000 { > resets = <&ccu RST_BUS_CE>; > }; > > + ahci: sata@1c18000 { > + compatible = "allwinner,sun8i-r40-ahci"; > + reg = <0x01c18000 0x1000>; > + interrupts = ; > + clocks = <&ccu CLK_BUS_SATA>, <&ccu CLK_SATA>; > + resets = <&ccu RST_BUS_SATA>; > + reset-names = "ahci"; > + status = "disabled"; > + Did this empty line serve any particular purpose before? If not, you could remove it on the way. With that fixed: Reviewed-by: Andre Przywara Thanks, Andre. > + }; > + > ehci1: usb@1c19000 { > compatible = "allwinner,sun8i-r40-ehci", "generic-ehci"; > reg = <0x01c19000 0x100>; > @@ -733,17 +744,6 @@ spi3: spi@1c0f000 { > #size-cells = <0>; > }; > > - ahci: sata@1c18000 { > - compatible = "allwinner,sun8i-r40-ahci"; > - reg = <0x01c18000 0x1000>; > - interrupts = ; > - clocks = <&ccu CLK_BUS_SATA>, <&ccu CLK_SATA>; > - resets = <&ccu RST_BUS_SATA>; > - reset-names = "ahci"; > - status = "disabled"; > - > - }; > - > gmac: ethernet@1c50000 { > compatible = "allwinner,sun8i-r40-gmac"; > syscon = <&ccu>; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel