From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8C1AC5ACBF for ; Fri, 13 Mar 2020 21:20:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A961120767 for ; Fri, 13 Mar 2020 21:20:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CdOTThec"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="M810FBkQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A961120767 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PUfKLIftRmOm0hPb2wo+HvmS4ZftYB3MC7fmeGYtJ/U=; b=CdOTThec6KT55z 7pfoZMzBaTqCKF5KDGy4lNWvsWanGTY1ntZZph8dwBTlrvvZ7Ejy9vSasnkuzeQbbWnYery/fbBN+ +dV7HRyPOC+3G3d+J0VvVb4H2ILm+CHXGXNYq4MuLX1jIq/I3RmHvYQDsVEic2V6VUefh7BO+Pagv NCFYd1345nGBHT5wyTRGTOwQ/dPDFIdwsKJp/F9V9VnBlHVlPkxcCINF0Mef9Rm+060jPLZEUZtGx 50+j2z32tKwkHjoDJQr4ojdREUI9JLPvH59t0e0IXYyO0jStVEkx1h6erm/IO63jpzkMyHz8rshaK bav/yjI6BPCo9fNpd5gw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCrjB-0003Co-Vo; Fri, 13 Mar 2020 21:20:21 +0000 Received: from perceval.ideasonboard.com ([2001:4b98:dc2:55:216:3eff:fef7:d647]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCrj8-0003CH-AS for linux-arm-kernel@lists.infradead.org; Fri, 13 Mar 2020 21:20:19 +0000 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 74DEC2D6; Fri, 13 Mar 2020 22:20:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1584134416; bh=rbPOZUZr8TzKPMaBhelegUMRi4yJvmaHj4VSA2yR9ts=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=M810FBkQMGJkbsHLRGM5Yk4qMYoxUHx4+3mMrw/PFRkDpuIMNbSWojeQiL2c4bqPx 4gtv30a6xpxu3wAnT2Te+bwW5mEaQpQRFAY98wYHeXEMVpeQXEOddq5+61wuRa2x/V MjcuyEIPTPrT+2zHAhb0p2Ioc+FnxbpH0pNEwh+4= Date: Fri, 13 Mar 2020 23:20:12 +0200 From: Laurent Pinchart To: Lad Prabhakar Subject: Re: [PATCH v3 1/4] media: dt-bindings: media: i2c: Switch to assigned-clock-rates Message-ID: <20200313212012.GL4751@pendragon.ideasonboard.com> References: <1584133954-6953-1-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> <1584133954-6953-2-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1584133954-6953-2-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200313_142018_513095_F6921796 X-CRM114-Status: GOOD ( 17.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Fabio Estevam , Sakari Ailus , Ezequiel Garcia , Sascha Hauer , Magnus Damm , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Rob Herring , Geert Uytterhoeven , NXP Linux Team , Pengutronix Kernel Team , Mauro Carvalho Chehab , Shawn Guo , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Prabhakar, Thank you for the patch. On Fri, Mar 13, 2020 at 09:12:31PM +0000, Lad Prabhakar wrote: > Use assigned-clock-rates to specify the clock rate. Also mark > clock-frequency property as deprecated. I would phrase it the other way around, this patch mainly deprecates clock-frequency, and as a side effect recommends usage of assigned-clock-rates. "Deprecate usage of the clock-frequency propertly. The preferred method to set clock rates is to use assigned-clock-rates." > Signed-off-by: Lad Prabhakar > --- > Documentation/devicetree/bindings/media/i2c/ov5645.txt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/ov5645.txt b/Documentation/devicetree/bindings/media/i2c/ov5645.txt > index 72ad992..e62fe82 100644 > --- a/Documentation/devicetree/bindings/media/i2c/ov5645.txt > +++ b/Documentation/devicetree/bindings/media/i2c/ov5645.txt > @@ -8,7 +8,7 @@ Required Properties: > - compatible: Value should be "ovti,ov5645". > - clocks: Reference to the xclk clock. > - clock-names: Should be "xclk". > -- clock-frequency: Frequency of the xclk clock. > +- clock-frequency (deprecated): Frequency of the xclk clock. I would drop this completely. Drivers need to ensure backward compatibility, but DT bindings should only document the latest version, the history is available in git. Reviewed-by: Laurent Pinchart While at it, can I enlist you to convert these bindings to yaml ? :-) > - enable-gpios: Chip enable GPIO. Polarity is GPIO_ACTIVE_HIGH. This corresponds > to the hardware pin PWDNB which is physically active low. > - reset-gpios: Chip reset GPIO. Polarity is GPIO_ACTIVE_LOW. This corresponds to > @@ -37,7 +37,8 @@ Example: > > clocks = <&clks 200>; > clock-names = "xclk"; > - clock-frequency = <24000000>; > + assigned-clocks = <&clks 200>; > + assigned-clock-rates = <24000000>; > > vdddo-supply = <&camera_dovdd_1v8>; > vdda-supply = <&camera_avdd_2v8>; -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel