From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 083ECC0044D for ; Sat, 14 Mar 2020 07:41:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D068D20665 for ; Sat, 14 Mar 2020 07:41:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pl1DBFV7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D068D20665 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w1ZWADv9LXFxlyu/4SXqrNm92aRzoMxbDARx8YfJxhE=; b=pl1DBFV7WCnlA0 NfXdH4e2Bw7JWnO5gWvh7Dtd7wnMf6AgnjtIWHuzySf4wgp0zYlQlEqyKwl0HYFZrDXFAot3tBSLE A3LzgqydcZarOMWWaYhNb/8EmbhRyXJwwJeC08by2lDWoykJpJiZ5R5cD9sLlDz9ZgOw3zXlRylGt 4I9owRSAwKE+8axL30x3D58XL9nDtOUhtIwyuBMjw22M68SfNJtUYvPPLL2oHpP/h3NfccBp6O84A qzbZ+kevYCT+lKNa2sSQKbIkjfoCTRT81iJ4QCGVMMPUh086N4FwoZGGkHvE3DFBLW/0sT8FfSBe0 ptSFqG6Yi1UpP3QpEZkA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jD1QR-0003Xr-HG; Sat, 14 Mar 2020 07:41:39 +0000 Received: from asavdk4.altibox.net ([109.247.116.15]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jD1QN-0003XA-2q for linux-arm-kernel@lists.infradead.org; Sat, 14 Mar 2020 07:41:37 +0000 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 2594B80501; Sat, 14 Mar 2020 08:41:19 +0100 (CET) Date: Sat, 14 Mar 2020 08:41:18 +0100 From: Sam Ravnborg To: Icenowy Zheng Subject: Re: [PATCH 2/5] dt-bindings: panel: add binding for Xingbangda XBD599 panel Message-ID: <20200314074118.GD5783@ravnborg.org> References: <20200311163329.221840-1-icenowy@aosc.io> <20200311163329.221840-3-icenowy@aosc.io> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200311163329.221840-3-icenowy@aosc.io> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=XpTUx2N9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=gEfo2CItAAAA:8 a=NVUcaYqSR25QaaNNWYIA:9 a=CjuIK1q_8ugA:10 a=sptkURWiP4Gy88Gu7hUp:22 a=pHzHmUro8NiASowvMSCR:22 a=nt3jZW36AmriUCFCBwmW:22 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200314_004135_308233_0C5EA152 X-CRM114-Status: GOOD ( 15.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ondrej Jirman , devicetree@vger.kernel.org, linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , Chen-Yu Tsai , Thierry Reding , Maxime Ripard , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Icenowy A few comment below. Sam On Thu, Mar 12, 2020 at 12:33:26AM +0800, Icenowy Zheng wrote: > Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI LCD panel. > > Add its device tree binding. > > Signed-off-by: Icenowy Zheng > --- > .../display/panel/xingbangda,xbd599.yaml | 50 +++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/xingbangda,xbd599.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/xingbangda,xbd599.yaml b/Documentation/devicetree/bindings/display/panel/xingbangda,xbd599.yaml > new file mode 100644 > index 000000000000..62816b34de31 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/xingbangda,xbd599.yaml > @@ -0,0 +1,50 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/xingbangda,xbd599.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Xingbangda XBD599 5.99in MIPI-DSI LCD panel > + > +maintainers: > + - Icenowy Zheng > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: xingbangda,xbd599 > + reg: true > + backlight: true > + reset-gpios: true > + vcc-supply: > + description: regulator that supplies the VCC voltage Fix indent - two chars, not three > + iovcc-supply: > + description: regulator that supplies the IOVCC voltage Same here > + > +required: > + - compatible > + - reg > + - backlight > + - vcc-supply > + - iovcc-supply > + > +additionalProperties: false > + > +examples: > + - | > + &dsi { Remove '&' - dt_binding_check will fail otherwise > + #address-cells = <1>; > + #size-cells = <0>; > + > + panel@0 { > + compatible = "xingbangda,xbd599"; > + reg = <0>; > + backlight = <&backlight>; > + iovcc-supply = <®_dldo2>; > + vcc-supply = <®_ldo_io0>; > + }; > + }; > + > +... > -- > 2.24.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel