From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E600EC5ACD6 for ; Wed, 18 Mar 2020 12:50:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC78D20777 for ; Wed, 18 Mar 2020 12:50:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kt2RGO40"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="cIezsSKK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC78D20777 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RhFywzLe3ngrw/0eMCM0E8AUC+w3g8lqAKjxgb94TdU=; b=kt2RGO40p/X7pE la3uoxzn+E+yRi5VhH06qHGxmSYdi7hr5pAmoO6nCmmiti7gTjTmrquSTU4LYg9CzIKIawAXXdoK1 n3zF8l2Jg7klMhqh6dGjm1xxhK0vrBoYPLN/AZxYRgFGqWFTm8G/kubNVbTeyDyDCOfICnVURHqCq tU4JK3cySRvtgC351fAMDpRoF9MO0nGKIdV+Zjjg4swfrZm2ZpBUMSnZEIBLKq4O80a1b9v5zzdNe JRlUM1FiZDTDpqlIfd1MmflZ37DLL9/PRT/v9SY3Pa8ddWrHvZYq9e5JLAaXynYXVMZQhFPjl1gf8 +sO/0koZCMsoiIL5MEHw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jEY9B-00007x-B1; Wed, 18 Mar 2020 12:50:09 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jEY97-00083f-Qw for linux-arm-kernel@lists.infradead.org; Wed, 18 Mar 2020 12:50:07 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B498620772; Wed, 18 Mar 2020 12:50:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584535805; bh=4sAHYFtjA0FIdYJcOZIot3tUfnyJiT7eyznRhSXxk3Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cIezsSKKuQ3seIdtO7kKrRl5zs5TwtTF7vVaWUEN68+xXAXgxNUrLCElI6m+cYkID rfNxn+j8J42BrRHX2n2rzTy7Y2uTU9phPEFF1Ec7UzSsw+mw+iyO4ULhLtwP2kZf98 Q/l5hfHFWMk83eNAWUpAYETxHr296cWmeS/SlDSk= Date: Wed, 18 Mar 2020 13:50:03 +0100 From: Greg KH To: Rajan Vaja Subject: Re: [PATCH v3 20/24] firmware: xilinx: Add APIs to read/write GGS/PGGS registers Message-ID: <20200318125003.GA2727094@kroah.com> References: <1583538452-1992-1-git-send-email-jolly.shah@xilinx.com> <1583538452-1992-21-git-send-email-jolly.shah@xilinx.com> <20200318115141.GB2472686@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200318_055005_895723_83755880 X-CRM114-Status: GOOD ( 15.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "keescook@chromium.org" , "ard.biesheuvel@linaro.org" , "matt@codeblueprint.co.uk" , "dmitry.torokhov@gmail.com" , "linux-kernel@vger.kernel.org" , Jolly Shah , Michal Simek , "sudeep.holla@arm.com" , "mingo@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "hkallweit1@gmail.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 18, 2020 at 12:41:46PM +0000, Rajan Vaja wrote: > Hi Greg, > > Thanks for applying patches and review. > > Please see my comment inline. > > > -----Original Message----- > > From: Greg KH > > Sent: 18 March 2020 05:22 PM > > To: Jolly Shah > > Cc: ard.biesheuvel@linaro.org; mingo@kernel.org; matt@codeblueprint.co.uk; > > sudeep.holla@arm.com; hkallweit1@gmail.com; keescook@chromium.org; > > dmitry.torokhov@gmail.com; Michal Simek ; Rajan Vaja > > ; linux-arm-kernel@lists.infradead.org; linux- > > kernel@vger.kernel.org; Rajan Vaja > > Subject: Re: [PATCH v3 20/24] firmware: xilinx: Add APIs to read/write GGS/PGGS > > registers > > > > CAUTION: This message has originated from an External Source. Please use > > proper judgment and caution when opening attachments, clicking links, or > > responding to this email. > > > > > > On Fri, Mar 06, 2020 at 03:47:28PM -0800, Jolly Shah wrote: > > > --- a/include/linux/firmware/xlnx-zynqmp.h > > > +++ b/include/linux/firmware/xlnx-zynqmp.h > > > @@ -105,6 +105,10 @@ enum pm_ioctl_id { > > > IOCTL_GET_PLL_FRAC_MODE, > > > IOCTL_SET_PLL_FRAC_DATA, > > > IOCTL_GET_PLL_FRAC_DATA, > > > + IOCTL_WRITE_GGS, > > > + IOCTL_READ_GGS, > > > + IOCTL_WRITE_PGGS, > > > + IOCTL_READ_PGGS, > > > > You do not have explicit numbers here? Bold :) > [Rajan] Here new IOCTL IDs are continuous so didn't mention explicit number. Yes, but is that guaranteed by the compiler? I keep getting conflicting advice with that. > Are asking for adding numbers like below: > enum pm_ioctl_id { > ... > IOCTL_GET_PLL_FRAC_DATA = 11, > IOCTL_WRITE_GGS = 12, > .... > } Yes please, especially as your firmware is expecting the explicit values here, right? That way you _know_ everything is correct. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel