From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B419C43331 for ; Tue, 24 Mar 2020 10:19:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD71520842 for ; Tue, 24 Mar 2020 10:19:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YYdcJbis"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="XQ94ZQUD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD71520842 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AQWlUSBgqBi6ZSIQNTxTZvWdAx7rWjNJVm4U1/j2S44=; b=YYdcJbisN47I+v 5iNm+prR6vhFOgA0awWFrv5/xDrHI5jk9j78+LiwL/M8RXVwe0fRtXx0HTAOc8ac68im4riP+ogY/ zUupuF9HWNG/qg5CDXQvpOC8Q9M8+o5piBrNO5LTU54oaG2PGOkKbrJV0pAqxD367HmuynTJ6TsVu T/jrKYF09JQhrJbZFEzv8L5mSlkxof+Re7o4KUd9lPZ0kL8jK9X2SBd0QpW/Itj7t/1NcfEhm/4nf 0B1Z/z4ssJBvWnjaiSYlfgfsvh+yJjeq8Rcf0otouB24E4FIM0OjN7ShYYd1bW2MMk1WNrMBMtdyg ltahPCqk/wYq2LMq5frA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGget-0000Mv-UG; Tue, 24 Mar 2020 10:19:43 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGger-0000MZ-CU for linux-arm-kernel@lists.infradead.org; Tue, 24 Mar 2020 10:19:42 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5D0F82080C; Tue, 24 Mar 2020 10:19:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585045180; bh=q4q2MlAIz6+C/hLPcO9TRU1z0kw29IK3WElI+UFhXgg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XQ94ZQUDRRdi3qTMyMKloWf8WGl5UrXJKTuuKZYg1OZ2U3a9Osi3YQaw5Ouz8i0f7 /20hISeB3SITV1C6h5yiH3eHmg3H0lETiiiCU26eYgVEbZ3doVo+3Qn5C3PsMtviII GxB/SJyxk+IJoh1lqlXqAXs6Xh7HBTjS+rwjSl9I= Date: Tue, 24 Mar 2020 11:19:38 +0100 From: Greg Kroah-Hartman To: Eugene Syromiatnikov Subject: Re: [PATCH] coresight: do not use the BIT() macro in the UAPI header Message-ID: <20200324101938.GA2220478@kroah.com> References: <20200324042213.GA10452@asgard.redhat.com> <20200324062853.GD1977781@kroah.com> <20200324095304.GA2444@asgard.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200324095304.GA2444@asgard.redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200324_031941_446970_290DB4C6 X-CRM114-Status: GOOD ( 12.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mathieu Poirier , Alexandre Torgue , Michael Williams , linux-kernel@vger.kernel.org, Chunyan Zhang , Maxime Coquelin , "Dmitry V. Levin" , Pratik Patel , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 24, 2020 at 10:53:04AM +0100, Eugene Syromiatnikov wrote: > On Tue, Mar 24, 2020 at 07:28:53AM +0100, Greg Kroah-Hartman wrote: > > On Tue, Mar 24, 2020 at 05:22:13AM +0100, Eugene Syromiatnikov wrote: > > > The BIT() macro definition is not available for the UAPI headers > > > (moreover, it can be defined differently in the user space); replace > > > its usage with the _BITUL() macro that is defined in . > > > > Why is somehow _BITUL() ok to use here instead? > > It is provided in an UAPI header (include/uapi/linux/const.h) > and is appropriately prefixed with an underscore to avoid conflicts. Because no one uses _ in their own macros? :) Anyway, this is fine, but if it's really the way forward, I think a lot of files will end up being changed... thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel