From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A1A2C43331 for ; Wed, 25 Mar 2020 10:57:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A152206F6 for ; Wed, 25 Mar 2020 10:57:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="o/TexwV3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A152206F6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=00lhXIK0OWrn8ajx6K3ucOTx44J33bIRfOAu98GAkw4=; b=o/TexwV37DU5P9 4IiKIEvcHUe3Fd19Uf2SK36YKd6CHctP7DbdahO+rvkeemwTIObC5bFxsSDBuD6j+c1qySWgwQAtM ZvqLMR0h0+0lr+xRSXfgeJV/IRHd0BU8WnAbARd2wNfmqDcVJRppjdzpBScphhDEEVqeEYPwFPirV 3P0r0+VlNnhl7ABG6QlilXMT5CYm3BmZ5mEvwemCb4xsLkN8an+DDeVa7cPcVPIV7JgaLC04WRe11 5VAwpevmCxvv2dWAV7dDi7eYK18Pk0eH651eCfXhHezyePlRH8+6eebzd3Ab93Z3Hp61WmD7dOIlo rqo9SNzudRwX0Ufe6f+Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jH3im-0006zu-Cj; Wed, 25 Mar 2020 10:57:16 +0000 Received: from mga11.intel.com ([192.55.52.93]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jH3iH-0006XD-9f for linux-arm-kernel@lists.infradead.org; Wed, 25 Mar 2020 10:56:47 +0000 IronPort-SDR: vqoO02HGK5184HtFpl3eFrzytz+yKBt8BrAJVlRgRXVh6JxETXfvBcpZW4m5T3HVecPE5gaNrJ ElW9wdAsFk3w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2020 03:56:43 -0700 IronPort-SDR: hI+UVz3VTvOFe+u/CY5MUl6QXXQkV2G53hU1tnsEZLNE4Xnr59GuDK3nJk6lIJb8nfIXK16YNZ gm5JUtkxOl9A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,304,1580803200"; d="scan'208";a="293310039" Received: from lkp-server01.sh.intel.com (HELO lkp-server01) ([10.239.97.150]) by FMSMGA003.fm.intel.com with ESMTP; 25 Mar 2020 03:56:42 -0700 Received: from kbuild by lkp-server01 with local (Exim 4.89) (envelope-from ) id 1jH3iE-0004Qn-2J; Wed, 25 Mar 2020 18:56:42 +0800 Date: Wed, 25 Mar 2020 18:55:59 +0800 From: kbuild test robot To: Russell King Subject: [PATCH] net: fix irqf_oneshot.cocci warnings Message-ID: <20200325105559.GA4092@6d5c83dcba44> References: <202003251849.wLfJ5mOC%lkp@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <202003251849.wLfJ5mOC%lkp@intel.com> X-Patchwork-Hint: ignore User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200325_035645_461747_7F79C4F6 X-CRM114-Status: GOOD ( 12.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kbuild-all@lists.01.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: kbuild test robot drivers/net/phy/qsfp.c:1750:8-33: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci Fixes: e409cdeab751 ("net: add qsfp support [*experimental*]") Signed-off-by: kbuild test robot --- tree: git://git.armlinux.org.uk/~rmk/linux-arm.git cex7 head: 6edfcc6e759c8dd593c9079525e610919d680ae5 commit: e409cdeab75156478ac793528742274f6ad4be96 [142/143] net: add qsfp support [*experimental*] Please take the patch only if it's a positive warning. Thanks! qsfp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/net/phy/qsfp.c +++ b/drivers/net/phy/qsfp.c @@ -1748,7 +1748,8 @@ static int qsfp_probe(struct platform_de } err = devm_request_threaded_irq(qsfp->dev, qsfp->gpio_irq[i], - NULL, irq_handler, irq_flags, + NULL, irq_handler, + irq_flags | IRQF_ONESHOT, dev_name(qsfp->dev), qsfp); if (err) { qsfp->gpio_irq[i] = 0; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel