From: Rob Herring <robh@kernel.org>
To: devicetree@vger.kernel.org
Cc: Neil Armstrong <narmstrong@baylibre.com>,
linux-iio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Guillaume La Roque <glaroque@baylibre.com>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Lee Jones <lee.jones@linaro.org>,
linux-clk@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
Kevin Hilman <khilman@baylibre.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Zhang Rui <rui.zhang@intel.com>,
Brian Masney <masneyb@onstation.org>,
Michael Hennerich <michael.hennerich@analog.com>,
linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-gpio@vger.kernel.org, Mark Brown <broonie@kernel.org>,
linux-amlogic@lists.infradead.org,
Thomas Gleixner <tglx@linutronix.de>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-arm-kernel@lists.infradead.org,
Stephen Boyd <sboyd@kernel.org>,
netdev@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Hartmut Knaack <knaack.h@gmx.de>,
linux-media@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Jonathan Cameron <jic23@kernel.org>
Subject: [PATCH 2/4] dt-bindings: sram: qcom: Clean-up 'ranges' and child node names
Date: Wed, 25 Mar 2020 16:05:39 -0600 [thread overview]
Message-ID: <20200325220542.19189-3-robh@kernel.org> (raw)
In-Reply-To: <20200325220542.19189-1-robh@kernel.org>
The regex for child nodes doesn't match the example. This wasn't flagged
with 'additionalProperties: false' missing. The child node schema was also
incorrect with 'ranges' property as it applies to child nodes and should
be moved up to the parent node.
Fixes: 957fd69d396b ("dt-bindings: soc: qcom: add On Chip MEMory (OCMEM) bindings")
Cc: Brian Masney <masneyb@onstation.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: linux-arm-msm@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/sram/qcom,ocmem.yaml | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/sram/qcom,ocmem.yaml b/Documentation/devicetree/bindings/sram/qcom,ocmem.yaml
index 222990f9923c..469cec133647 100644
--- a/Documentation/devicetree/bindings/sram/qcom,ocmem.yaml
+++ b/Documentation/devicetree/bindings/sram/qcom,ocmem.yaml
@@ -43,6 +43,9 @@ properties:
'#size-cells':
const: 1
+ ranges:
+ maxItems: 1
+
required:
- compatible
- reg
@@ -51,9 +54,10 @@ required:
- clock-names
- '#address-cells'
- '#size-cells'
+ - ranges
patternProperties:
- "^.+-sram$":
+ "-sram@[0-9a-f]+$":
type: object
description: A region of reserved memory.
@@ -61,12 +65,8 @@ patternProperties:
reg:
maxItems: 1
- ranges:
- maxItems: 1
-
required:
- reg
- - ranges
examples:
- |
@@ -88,9 +88,9 @@ examples:
#address-cells = <1>;
#size-cells = <1>;
+ ranges = <0 0xfec00000 0x100000>;
gmu-sram@0 {
reg = <0x0 0x100000>;
- ranges = <0 0 0xfec00000 0x100000>;
};
};
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-25 22:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 22:05 [PATCH 0/4] dt-bindings: additionalProperties clean-up Rob Herring
2020-03-25 22:05 ` [PATCH 1/4] dt-bindings: iio/accel: Drop duplicate adi, adxl345/6 from trivial-devices.yaml Rob Herring
2020-03-26 7:57 ` Ardelean, Alexandru
2020-03-26 12:43 ` Jonathan Cameron
2020-03-27 20:21 ` Sam Ravnborg
2020-03-31 14:48 ` Rob Herring
2020-03-25 22:05 ` Rob Herring [this message]
2020-03-25 23:34 ` [PATCH 2/4] dt-bindings: sram: qcom: Clean-up 'ranges' and child node names Brian Masney
2020-03-25 22:05 ` [PATCH 3/4] dt-bindings: Clean-up schema errors due to missing 'addtionalProperties: false' Rob Herring
2020-03-26 7:58 ` Ardelean, Alexandru
2020-03-26 8:39 ` Neil Armstrong
2020-03-26 12:45 ` Jonathan Cameron
2020-03-27 8:32 ` Lee Jones
2020-03-27 9:59 ` Linus Walleij
2020-03-30 7:10 ` Masahiro Yamada
2020-03-25 22:05 ` [PATCH 4/4] dt-bindings: Add missing 'additionalProperties: false' Rob Herring
2020-03-25 22:07 ` Mark Brown
2020-03-26 8:07 ` Ardelean, Alexandru
2020-03-26 8:37 ` Neil Armstrong
2020-03-26 12:47 ` Jonathan Cameron
2020-03-26 13:27 ` Benjamin Gaignard
2020-03-27 8:31 ` Lee Jones
2020-03-30 7:09 ` Masahiro Yamada
2020-03-30 8:37 ` Masahiro Yamada
2020-03-31 14:39 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325220542.19189-3-robh@kernel.org \
--to=robh@kernel.org \
--cc=bgolaszewski@baylibre.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=glaroque@baylibre.com \
--cc=jic23@kernel.org \
--cc=khilman@baylibre.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=masneyb@onstation.org \
--cc=mchehab@kernel.org \
--cc=michael.hennerich@analog.com \
--cc=narmstrong@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=rui.zhang@intel.com \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).