* Re: [PATCH] soc: mediatek: mtk-mmsys: Export ddp_dis/connect symbols
2020-03-26 18:27 [PATCH] soc: mediatek: mtk-mmsys: Export ddp_dis/connect symbols Enric Balletbo i Serra
@ 2020-03-27 7:19 ` Anders Roxell
2020-03-27 14:22 ` Chun-Kuang Hu
2020-03-27 17:02 ` Matthias Brugger
2 siblings, 0 replies; 4+ messages in thread
From: Anders Roxell @ 2020-03-27 7:19 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: drinkcat, Linux Kernel Mailing List, linux-mediatek, hsinyi,
Matthias Brugger, Collabora Kernel ML, Linux ARM
On Thu, 26 Mar 2020 at 19:27, Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> When building on arm64 with allmodconfig or CONFIG_DRM_MEDIATEK=m we see
> the following error.
>
> ERROR: modpost: "mtk_mmsys_ddp_disconnect"
> [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined!
> ERROR: modpost: "mtk_mmsys_ddp_connect"
> [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined!
>
> Export mtk_mmsys_ddp_connect and mtk_mmsys_ddp_disconnect symbols to be
> able to be used for other modules.
>
> Fixes: 396c3fccaf03 ("soc / drm: mediatek: Move routing control to mmsys device")
> Reported-by: Anders Roxell <anders.roxell@linaro.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Tested-by: Anders Roxell <anders.roxell@linaro.org>
Cheers,
Anders
> ---
>
> drivers/soc/mediatek/mtk-mmsys.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c
> index 32a92ec447c5..05e322c9c301 100644
> --- a/drivers/soc/mediatek/mtk-mmsys.c
> +++ b/drivers/soc/mediatek/mtk-mmsys.c
> @@ -259,6 +259,7 @@ void mtk_mmsys_ddp_connect(struct device *dev,
> writel_relaxed(reg, config_regs + addr);
> }
> }
> +EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_connect);
>
> void mtk_mmsys_ddp_disconnect(struct device *dev,
> enum mtk_ddp_comp_id cur,
> @@ -279,6 +280,7 @@ void mtk_mmsys_ddp_disconnect(struct device *dev,
> writel_relaxed(reg, config_regs + addr);
> }
> }
> +EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_disconnect);
>
> static int mtk_mmsys_probe(struct platform_device *pdev)
> {
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] soc: mediatek: mtk-mmsys: Export ddp_dis/connect symbols
2020-03-26 18:27 [PATCH] soc: mediatek: mtk-mmsys: Export ddp_dis/connect symbols Enric Balletbo i Serra
2020-03-27 7:19 ` Anders Roxell
@ 2020-03-27 14:22 ` Chun-Kuang Hu
2020-03-27 17:02 ` Matthias Brugger
2 siblings, 0 replies; 4+ messages in thread
From: Chun-Kuang Hu @ 2020-03-27 14:22 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: Nicolas Boichat, Anders Roxell, linux-kernel, linux-mediatek,
hsinyi, Matthias Brugger, Collabora Kernel ML, linux-arm-kernel
Hi, Enric:
Enric Balletbo i Serra <enric.balletbo@collabora.com> 於 2020年3月27日 週五 上午2:28寫道：
>
> When building on arm64 with allmodconfig or CONFIG_DRM_MEDIATEK=m we see
> the following error.
>
> ERROR: modpost: "mtk_mmsys_ddp_disconnect"
> [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined!
> ERROR: modpost: "mtk_mmsys_ddp_connect"
> [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined!
>
> Export mtk_mmsys_ddp_connect and mtk_mmsys_ddp_disconnect symbols to be
> able to be used for other modules.
>
Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> Fixes: 396c3fccaf03 ("soc / drm: mediatek: Move routing control to mmsys device")
> Reported-by: Anders Roxell <anders.roxell@linaro.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
>
> drivers/soc/mediatek/mtk-mmsys.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c
> index 32a92ec447c5..05e322c9c301 100644
> --- a/drivers/soc/mediatek/mtk-mmsys.c
> +++ b/drivers/soc/mediatek/mtk-mmsys.c
> @@ -259,6 +259,7 @@ void mtk_mmsys_ddp_connect(struct device *dev,
> writel_relaxed(reg, config_regs + addr);
> }
> }
> +EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_connect);
>
> void mtk_mmsys_ddp_disconnect(struct device *dev,
> enum mtk_ddp_comp_id cur,
> @@ -279,6 +280,7 @@ void mtk_mmsys_ddp_disconnect(struct device *dev,
> writel_relaxed(reg, config_regs + addr);
> }
> }
> +EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_disconnect);
>
> static int mtk_mmsys_probe(struct platform_device *pdev)
> {
> --
> 2.25.1
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] soc: mediatek: mtk-mmsys: Export ddp_dis/connect symbols
2020-03-26 18:27 [PATCH] soc: mediatek: mtk-mmsys: Export ddp_dis/connect symbols Enric Balletbo i Serra
2020-03-27 7:19 ` Anders Roxell
2020-03-27 14:22 ` Chun-Kuang Hu
@ 2020-03-27 17:02 ` Matthias Brugger
2 siblings, 0 replies; 4+ messages in thread
From: Matthias Brugger @ 2020-03-27 17:02 UTC (permalink / raw)
To: Enric Balletbo i Serra, linux-kernel
Cc: drinkcat, Anders Roxell, linux-mediatek, hsinyi,
Collabora Kernel ML, linux-arm-kernel
On 26/03/2020 19:27, Enric Balletbo i Serra wrote:
> When building on arm64 with allmodconfig or CONFIG_DRM_MEDIATEK=m we see
> the following error.
>
> ERROR: modpost: "mtk_mmsys_ddp_disconnect"
> [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined!
> ERROR: modpost: "mtk_mmsys_ddp_connect"
> [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined!
>
> Export mtk_mmsys_ddp_connect and mtk_mmsys_ddp_disconnect symbols to be
> able to be used for other modules.
>
> Fixes: 396c3fccaf03 ("soc / drm: mediatek: Move routing control to mmsys device")
> Reported-by: Anders Roxell <anders.roxell@linaro.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
I squashed this into the old commit:
396c3fccaf03 ("soc / drm: mediatek: Move routing control to mmsys device")
And pushed it out to v5.6-next/soc
Thanks!
> ---
>
> drivers/soc/mediatek/mtk-mmsys.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c
> index 32a92ec447c5..05e322c9c301 100644
> --- a/drivers/soc/mediatek/mtk-mmsys.c
> +++ b/drivers/soc/mediatek/mtk-mmsys.c
> @@ -259,6 +259,7 @@ void mtk_mmsys_ddp_connect(struct device *dev,
> writel_relaxed(reg, config_regs + addr);
> }
> }
> +EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_connect);
>
> void mtk_mmsys_ddp_disconnect(struct device *dev,
> enum mtk_ddp_comp_id cur,
> @@ -279,6 +280,7 @@ void mtk_mmsys_ddp_disconnect(struct device *dev,
> writel_relaxed(reg, config_regs + addr);
> }
> }
> +EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_disconnect);
>
> static int mtk_mmsys_probe(struct platform_device *pdev)
> {
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread