From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8320C2BA19 for ; Tue, 14 Apr 2020 14:37:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CDD02064A for ; Tue, 14 Apr 2020 14:37:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="W8myZHeU"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GwPLG9Bh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CDD02064A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=T/2PL5gtTJ5kIKsJneK2I+K/4UpP+pK4lATxp6EJEOo=; b=W8myZHeUTjGAXtTJES0IGTq5u yXxV0PFYEnSMx/L8mT4VsnofKVBm7qbn2Mhq+1kDKMelvnS1GDgbWiV1s+3Id0BVNXbcvX/O5/Qoj 8Ky/WMOs8Ic84HYAy7q+flmV/wAQVnREiAYBRDiQmWte4i8TZbQa+tTy3XBrxnebGDvcEOI0Otj4c 5oOldyTiPmGtiLVnJ5L31NyG3STt6/0MN2RDx/IX44AHumBZhVG4oJ06C2YQAeW4UUuzkEb12SLBK 9x7G33QeGITmWey3jGgLQybu0F6D2T+IYMJJdBvkXQeePig58Wu0V3foouMYgFoLR5i/Rmi41yf+R jb7bB/zMA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOMgT-00051b-MY; Tue, 14 Apr 2020 14:37:05 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOMgQ-00050h-Ox for linux-arm-kernel@lists.infradead.org; Tue, 14 Apr 2020 14:37:04 +0000 Received: by mail-wm1-x342.google.com with SMTP id r26so14263105wmh.0 for ; Tue, 14 Apr 2020 07:37:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=KA4DIsropTxxePLrlrvPba68I+rBV9yWm4kCLt//0G8=; b=GwPLG9BhM6Xv1cIvRlRS/kLL1JSrcTOAnlRT73NoQiu4DKr3+DE3yjbAr9/gQJ/Pzp kHM3cwi0ZQaKX2uAMqWAkvOnw6y4dapC9GbfV2EzQ4m9zbcT70a1Y44VteFpb4RvxmVF ngkPwZ+eKgaIjYggCjVoIhtcyFeN6y1S+38DnJ6vVpiVTJ+SG3mtf5umYDdSPV+mxYjy ygGvoKQ2SCULOGGCaW7UmuUWCaD/SyCM85SvQKxRwuD2BnP5V5lywjhw/rQjRO+E9rnX snOIZJ3kXuONHaC3uM+iv3QR9ossS67ixMiiUW18MIhF3uFPbCsxYXLSQ7L7/prmZZ09 4zxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=KA4DIsropTxxePLrlrvPba68I+rBV9yWm4kCLt//0G8=; b=CoN2iElVq4vZ1rD4BSU/ARDdwi0yfPr1vEfNa42fIqTqUw2AH207c+8Roa64G8G2z2 wiiTu9nh02sDZ7GbTSnnlUBueo6enjIgDWnovJFgblXEjVIaFXDxS5WWCusrp6h/P5sk SQvWr7hUBHsvkqy6JRIzhkxGrkVxoz+ahy6nGPpt33Pnp135U3II9JYE3rmn7/fzzJ7+ wacraFno+gkljmnbQ5Vpg+N65R20eesE3HR6jaMfGbjL/on+ZtxJRwiCb7G51C/PgxGo hpEfeLHEbRzeogtoSZtBxE5gt1NlxD4aRIjM5W2ok/RGidRpgLp72vn5KkKnR0qtQNxY WLgg== X-Gm-Message-State: AGi0PuZR47p5zqSrtE2l/t4OdIPIgn1pytiQw+QijcjAM4gi5keTDJH7 YkVl75UOdZJumlAlRe97FTE= X-Google-Smtp-Source: APiQypIApqddZ8ciqzIvMTEdxD09J053jicytMvQKVner9xgHA7T1aScQ5k5I2qvUQWkROkiqs1NkQ== X-Received: by 2002:a7b:c84f:: with SMTP id c15mr170558wml.166.1586875020975; Tue, 14 Apr 2020 07:37:00 -0700 (PDT) Received: from localhost (pD9E51D62.dip0.t-ipconnect.de. [217.229.29.98]) by smtp.gmail.com with ESMTPSA id h10sm21602190wrq.33.2020.04.14.07.36.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2020 07:36:59 -0700 (PDT) Date: Tue, 14 Apr 2020 16:36:58 +0200 From: Thierry Reding To: Dmitry Osipenko Subject: Re: [PATCH v6 07/14] clk: tegra: Implement Tegra210 EMC clock Message-ID: <20200414143658.GH3593749@ulmo> References: <20200409175238.3586487-1-thierry.reding@gmail.com> <20200409175238.3586487-8-thierry.reding@gmail.com> <0e040cf9-56cf-dd44-3523-ff4c82fb1f2c@gmail.com> MIME-Version: 1.0 In-Reply-To: <0e040cf9-56cf-dd44-3523-ff4c82fb1f2c@gmail.com> User-Agent: Mutt/1.13.1 (2019-12-14) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200414_073702_808653_CCA3D11E X-CRM114-Status: GOOD ( 12.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Stephen Boyd , Michael Turquette , Jon Hunter , Rob Herring , Joseph Lo , linux-tegra@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============2777463107199963060==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2777463107199963060== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LiQwW4YX+w4axhAx" Content-Disposition: inline --LiQwW4YX+w4axhAx Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 10, 2020 at 11:49:18PM +0300, Dmitry Osipenko wrote: > 09.04.2020 20:52, Thierry Reding =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > ... > > +int tegra210_clk_emc_attach(struct clk *clk, > > + struct tegra210_clk_emc_provider *provider) > > +{ > > + struct clk_hw *hw =3D __clk_get_hw(clk); > > + struct tegra210_clk_emc *emc =3D to_tegra210_clk_emc(hw); > > + struct device *dev =3D provider->dev; > > + unsigned int i; > > + int err; > > + > > + if (!try_module_get(provider->owner)) > > + return -ENODEV; >=20 > Is the EMC driver module bumping its own refcount by itself? Hm... this doesn't really look useful in retrospect. Yes, the EMC is effectively grabbing a reference to itself. > In the other patch I already suggested that the EMC module should be > disallowed to be unloaded once it has been loaded, seems you're already > doing it. Correct? Interestingly, it all seems to work fine if I unload the module at runtime, not sure why I'm not prevented from unloading the module. Thierry --LiQwW4YX+w4axhAx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl6VyooACgkQ3SOs138+ s6F8fRAAltMFYycla8aI7eycjfxbMe6paTuQsQQyz+jPcJ+aDCABF8qrJ/fRjvBA AmzsAdBfdqmyB/Rc3h/y6yVkwn1HxakFOpPl18se88ca4dHLmjkzbFEq0Cf1zAjX EHzbheMPL4wN5EXukjpRedTg0u4TxaxpFq5YxtXqsy1JJvHrWeDszygAJTrhQi96 ly9ouXCvOtJvYnAM+6Cbu8T13m5MYYPmFTEeyx7v9ca5Lb/eYFzpDFjjY2cpfI+a 1T+Z/bT/c2ELi2n26IuPggymoXoMjDKJZVB7P8HMPAERzU7904qEhG3xIPQl/Gds lJkKAinQBWzmSUe158uzOhzWrWA+rLgB77kBU01NRt8IhaF3sLjPO+08lAfR9+8J ccFcoT8GDLE/PMipQMMWwm/kzwuTF+qTAFZDVxJgTiVyu4H7whWiCiHCEMx5KKI/ gpP9ps9jIjhWXlMgC4pnmdB8XFUzlyjYXnRhy/wYso3OZwDGqpc75TKC1sI3MUfC pS3OaFbyw73VaVgR+EZnTcyW/skXB1dOpOw/ur2npBx2Yh5gycNpxL3JrfSWXyDj V5J/how06Ci2WbIVB0wjJB7/qAafLD7OVViRC54JH48yUmtRwlF1ZF6D5dgMRU60 ffrfvRHDBhncixdMOW6dsbo+1tFjHbZA2wmCS1Ock8kqjFvYXiM= =UIdh -----END PGP SIGNATURE----- --LiQwW4YX+w4axhAx-- --===============2777463107199963060== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2777463107199963060==--