From: Krzysztof Kozlowski <krzk@kernel.org>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
"David Airlie" <airlied@linux.ie>,
"James Hogan" <jhogan@kernel.org>,
dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org,
"Paul Cercueil" <paul@crapouillou.net>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
linux-omap@vger.kernel.org, "Paul Burton" <paulburton@kernel.org>,
"Tony Lindgren" <tony@atomide.com>,
"Chen-Yu Tsai" <wens@csie.org>, "Kukjin Kim" <kgene@kernel.org>,
devicetree@vger.kernel.org,
"Benoît Cousson" <bcousson@baylibre.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
letux-kernel@openphoenux.org,
linux-arm-kernel@lists.infradead.org,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Philipp Rossak" <embed3d@gmail.com>,
openpvrsgx-devgroup@letux.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Ralf Baechle" <ralf@linux-mips.org>,
"Daniel Vetter" <daniel@ffwll.ch>,
kernel@pyra-handheld.com
Subject: Re: [PATCH v6 07/12] ARM: DTS: omap5: add sgx gpu child node
Date: Wed, 15 Apr 2020 15:47:54 +0200 [thread overview]
Message-ID: <20200415134754.GB21120@kozik-lap> (raw)
In-Reply-To: <EFA7F2F0-96EA-45D9-B8C8-00DC8C72344D@goldelico.com>
On Wed, Apr 15, 2020 at 01:46:06PM +0200, H. Nikolaus Schaller wrote:
> Hi Krzysztof,
>
> > Am 15.04.2020 um 13:38 schrieb Krzysztof Kozlowski <krzk@kernel.org>:
> >
> > On Wed, 15 Apr 2020 at 10:36, H. Nikolaus Schaller <hns@goldelico.com> wrote:
> >>
> >> and add interrupt.
> >>
> >> Tested-by: H. Nikolaus Schaller <hns@goldelico.com> # Pyra-Handheld.
> >
> > Don't add your own Tested-by tags. These are implied by authorship,
> > otherwise all patches people make should have such tag.
>
> Ok I see. AFAIR it originates in several phases of editing to report on which device it was tested.
>
> Is there a canonical way of writing "tested-on: ${HARDWARE}"?
>
> E.g. would this be ok?
>
> Signed-off: H. Nikolaus Schaller <hns@goldelico.com> # tested on Pyra-Handheld
If you think tested platform is worth mentioning in the commit msg
(it will stay there forever, ever, ever) then just add a line like:
"Add SGX GPU node. Tested on Pyra-Handheld."
From time to time we add such information to note that only one platform
was actually tested. I am not sure what benefit it brings to most
cases... but your commit msg is so short that adding one more sentence
seems reasonable. :)
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-15 13:48 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 8:35 [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more) H. Nikolaus Schaller
2020-04-15 8:35 ` [PATCH v6 01/12] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs H. Nikolaus Schaller
2020-04-15 10:12 ` [PATCH v6 01/12] dt-bindings: add img,pvrsgx.yaml " Maxime Ripard
2020-04-15 12:43 ` [PATCH v6 01/12] dt-bindings: add img, pvrsgx.yaml " H. Nikolaus Schaller
2020-04-15 12:54 ` Neil Armstrong
2020-04-15 13:17 ` H. Nikolaus Schaller
2020-04-15 14:21 ` Maxime Ripard
2020-04-15 15:09 ` H. Nikolaus Schaller
2020-04-15 16:21 ` Maxime Ripard
2020-04-15 16:42 ` H. Nikolaus Schaller
2020-04-15 17:13 ` Tony Lindgren
2020-04-17 10:25 ` Maxime Ripard
2020-04-17 12:15 ` H. Nikolaus Schaller
2020-04-18 23:02 ` Philipp Rossak
2020-04-20 8:04 ` Maxime Ripard
2020-04-16 20:41 ` [PATCH v6 01/12] dt-bindings: add img,pvrsgx.yaml " Rob Herring
2020-04-17 12:16 ` [PATCH v6 01/12] dt-bindings: add img, pvrsgx.yaml " H. Nikolaus Schaller
2020-04-21 19:02 ` Rob Herring
2020-04-15 8:35 ` [PATCH v6 02/12] ARM: DTS: am33xx: add sgx gpu child node H. Nikolaus Schaller
2020-04-15 8:35 ` [PATCH v6 03/12] ARM: DTS: am3517: " H. Nikolaus Schaller
2020-04-15 8:35 ` [PATCH v6 04/12] ARM: DTS: omap34xx: " H. Nikolaus Schaller
2020-04-15 8:35 ` [PATCH v6 05/12] ARM: DTS: omap36xx: " H. Nikolaus Schaller
2020-04-15 8:35 ` [PATCH v6 06/12] ARM: DTS: omap4: " H. Nikolaus Schaller
2020-04-15 8:35 ` [PATCH v6 07/12] ARM: DTS: omap5: " H. Nikolaus Schaller
2020-04-15 11:38 ` Krzysztof Kozlowski
2020-04-15 11:46 ` H. Nikolaus Schaller
2020-04-15 13:47 ` Krzysztof Kozlowski [this message]
2020-04-15 14:07 ` H. Nikolaus Schaller
2020-04-15 8:35 ` [PATCH v6 08/12] arm: dts: s5pv210: Add G3D node H. Nikolaus Schaller
2020-04-15 9:15 ` Sergei Shtylyov
2020-04-15 9:26 ` H. Nikolaus Schaller
2020-04-15 11:49 ` Krzysztof Kozlowski
2020-04-15 12:50 ` H. Nikolaus Schaller
2020-04-15 13:44 ` Krzysztof Kozlowski
2020-04-15 18:17 ` Jonathan Bakker
2020-04-16 8:50 ` Krzysztof Kozlowski
2020-04-17 12:15 ` H. Nikolaus Schaller
2020-04-15 8:35 ` [PATCH v6 09/12] ARM: dts: sun6i: a31: add sgx gpu child node H. Nikolaus Schaller
2020-04-15 8:35 ` [PATCH v6 10/12] ARM: dts: sun6i: a31s: " H. Nikolaus Schaller
2020-04-15 8:35 ` [PATCH v6 11/12] ARM: dts: sun8i: a83t: " H. Nikolaus Schaller
2020-04-15 8:35 ` [PATCH v6 12/12] MIPS: DTS: jz4780: add sgx gpu node H. Nikolaus Schaller
2020-04-15 10:10 ` [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more) Maxime Ripard
2020-04-15 12:41 ` H. Nikolaus Schaller
2020-04-15 12:46 ` Daniel Vetter
2020-04-15 13:02 ` Maxime Ripard
2020-04-15 13:04 ` H. Nikolaus Schaller
2020-04-17 12:09 ` Philipp Rossak
2020-04-20 7:38 ` Maxime Ripard
2020-04-21 9:57 ` Philipp Rossak
2020-04-21 11:21 ` Maxime Ripard
2020-04-21 14:15 ` Tony Lindgren
2020-04-21 17:29 ` H. Nikolaus Schaller
2020-04-21 17:39 ` Tony Lindgren
2020-04-21 17:46 ` Tony Lindgren
2020-04-22 6:58 ` Maxime Ripard
2020-04-22 7:10 ` H. Nikolaus Schaller
2020-04-22 15:13 ` Maxime Ripard
2020-04-22 16:09 ` H. Nikolaus Schaller
2020-04-23 15:00 ` Neil Armstrong
2020-04-23 15:45 ` H. Nikolaus Schaller
2020-04-23 20:36 ` Maxime Ripard
2020-04-24 9:51 ` H. Nikolaus Schaller
2020-04-21 16:42 ` Philipp Rossak
2020-04-23 20:37 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415134754.GB21120@kozik-lap \
--to=krzk@kernel.org \
--cc=airlied@linux.ie \
--cc=bcousson@baylibre.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=embed3d@gmail.com \
--cc=hns@goldelico.com \
--cc=jhogan@kernel.org \
--cc=kernel@pyra-handheld.com \
--cc=kgene@kernel.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=openpvrsgx-devgroup@letux.org \
--cc=paul@crapouillou.net \
--cc=paulburton@kernel.org \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
--cc=tsbogend@alpha.franken.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).