From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 167D2C2BB85 for ; Thu, 16 Apr 2020 08:51:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DDCF320784 for ; Thu, 16 Apr 2020 08:51:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="P4p9b9ep" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DDCF320784 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rQn6yVgF3j2fKKtLLB3RJ9ZYOEQAe1y3S/M0/xfHq+c=; b=P4p9b9eptEFUAC RbKOA4nhrwJx4pg6TXhWEweLC94rwkW0ab17tv3B5AfsZt0lBTExUGbi/VYDtTNYp1KXzSs8RHII+ s/T8LgpbJPevwHUoAX+D5mQdQEu2BEnt0hSOJxHPHOTv7gAtLIubZuRM767fASRNDSAqR9taMGmJG wQX7PFKZt53JoZmb9U6ffxrllXVINTM0urfHHJOV5NCJV9YnYTP8j6TPojlJBgklXL+UZvzsjtDlK IaBxk4GwPhUej5ivBrtmUeWZj8nyDEZB/wiCBe7opfifgyzw5toDVqIxg5EhnWl9GpiioD4+8h4Cn uL844C5rO+6xz36iMIdw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP0Em-0003Ap-KN; Thu, 16 Apr 2020 08:51:08 +0000 Received: from mail-ed1-f65.google.com ([209.85.208.65]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP0Ef-0002yo-Q7 for linux-arm-kernel@lists.infradead.org; Thu, 16 Apr 2020 08:51:06 +0000 Received: by mail-ed1-f65.google.com with SMTP id f12so4240736edn.12 for ; Thu, 16 Apr 2020 01:51:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=612iSfEdCExrydRb4c/BtgR5OtI+RlzyNcwVt1HFejQ=; b=FKTVJYSIq+L+FcIILXKICBC2Z1sfRMGwUVPrcWh4+5ED1QYemGg++l8TUGm5pVUQWT esVptbKuOeE0mqC7qUOzs6SLH/bYA9sZ/RpO+Yd66tXHt3i9HEVUUIjcr4aSVC5zuVld SaRcw2wDlrsp8deG6dqP3ySLw1qtfwNnPzesUotb2VftKzteVqtmdvHRFWqR/v/PKItq T9pIKggdvZqBe4TSGXSC4Xci33O306cOx/43kbN/6GCAHFlB/DpLVQS402mR06GlXhII mXswliL3N6UFkUlL4qsUDpnSo99VuxiDe5TsAIZLuE6rz5mpmdBLE34Au87BL/VHpptq DJZg== X-Gm-Message-State: AGi0PuYGMClVRKCR+SMta8uYUBNu5MXhsJF20Fo/zDDMF8nqElNoVLHX jizUtu53Wn5i8KpCzf0Tf48= X-Google-Smtp-Source: APiQypLBJohNWBf8al3U6Nm7wdqmu7TVhKtwUuNuYqABpoxhkFpKFPfFew2b9nU4yPhd8D2/wycwag== X-Received: by 2002:aa7:d1d6:: with SMTP id g22mr7466242edp.36.1587027059468; Thu, 16 Apr 2020 01:50:59 -0700 (PDT) Received: from kozik-lap ([194.230.155.125]) by smtp.googlemail.com with ESMTPSA id b15sm2495600edn.69.2020.04.16.01.50.54 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 Apr 2020 01:50:58 -0700 (PDT) Date: Thu, 16 Apr 2020 10:50:49 +0200 From: Krzysztof Kozlowski To: Jonathan Bakker Subject: Re: [PATCH v6 08/12] arm: dts: s5pv210: Add G3D node Message-ID: <20200416085049.GA7193@kozik-lap> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200416_015101_874867_8CF1FEE9 X-CRM114-Status: GOOD ( 14.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , David Airlie , "H. Nikolaus Schaller" , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, Paul Cercueil , "linux-samsung-soc@vger.kernel.org" , linux-omap@vger.kernel.org, Paul Burton , Tony Lindgren , Chen-Yu Tsai , Kukjin Kim , James Hogan , devicetree@vger.kernel.org, =?utf-8?Q?Beno=C3=AEt?= Cousson , Maxime Ripard , Rob Herring , letux-kernel@openphoenux.org, linux-arm-kernel@lists.infradead.org, Thomas Bogendoerfer , Philipp Rossak , openpvrsgx-devgroup@letux.org, "linux-kernel@vger.kernel.org" , Ralf Baechle , Daniel Vetter , kernel@pyra-handheld.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 15, 2020 at 11:17:16AM -0700, Jonathan Bakker wrote: > >> > >>> + > >>> + assigned-clocks = <&clocks MOUT_G3D>, <&clocks DOUT_G3D>; > >>> + assigned-clock-rates = <0>, <66700000>; > >>> + assigned-clock-parents = <&clocks MOUT_MPLL>; > >> > >> Probably this should have status disabled because you do not set > >> regulator supply. > > I don't believe there is a regulator on s5pv210, if there is, then it is a > fixed regulator with no control on both s5pv210 devices that I have. > > The vendor driver did use the regulator framework for its power domain > implementation, but that definitely shouldn't be upstreamed. Starting with Exynos4210 usually they have separate regulator from PMIC but maybe S5Pv210 indeed is different. Leave it then without it. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel