From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AFFEC54FD0 for ; Mon, 27 Apr 2020 17:02:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B40220738 for ; Mon, 27 Apr 2020 17:02:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Xiy0DjuZ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="dNZ6aoSE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B40220738 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zTRShkaBUTB2JmN+u6hu6kR/lsF9TowQ48ezw7nuJ4s=; b=Xiy0DjuZq3TjlN VRq1+4xeAl1CQhpXW2i5zgSBTxt14jzo+dqKnVtwHUQ9pTdNAFb4iR3RFeLLjpcjH0aChKrQQ7gNN txpqDeJI+ibSrnWOWyBsm9rkbEjV6+2q0NCplFMWY51kflI4zcSmcLt+vji9kkR5dUuUmagANG0mc Wkr6Wkub8c+TpPeiDkR9CRzRCTJcLvzBW4hxVG5cYfYgFeUaXu6HclJKrsVJCy3CRd0LpLq35RPac CvzQ/Os3MrQhFQYz+qbVWFHBOH3Va7FJxVBGHUAqoAmwmgtuy6LiWAYB2JRe5ZAURKrkehWglPj/k gVNi3fyERWTTsokR2kEg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jT793-0001Qx-Lp; Mon, 27 Apr 2020 17:02:13 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jT790-0001Fu-5J for linux-arm-kernel@lists.infradead.org; Mon, 27 Apr 2020 17:02:11 +0000 Received: by mail-pl1-x644.google.com with SMTP id v2so7204008plp.9 for ; Mon, 27 Apr 2020 10:02:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fz5fzGKUkYrlo1H6ujT5iT4E+OF3TxaMGxP6KIooVcQ=; b=dNZ6aoSEy7Lz5a9sDdJ7hoFwM3Ioe/buqvUh/XzcOLY+v/Lj94eIQWHMKCREcj9j0q VCEnS2J43l5VzkT6kYl5Lodvz+2yqryKx8JCo2k3IUPXzq9UL6+x1YRvrD55F0DkiUw6 BWD6qzEghGEYP92HnzMEuDuwjNjpiqR6vQaXrrvJnSsqLbA4PltvdNA/bnVU3ZaxDzsa clII1ZYGWxtBmLwk7/Fts+qQwzHD6kf05CCyDbWN3aEoNbULRWN6lTw+CKZbeZCkwewA shL7BDdzLmw5o3aYNX8tt+Tr7sx4NJn08ejwFkm18Anpj9zq4Uf4rjnt8W1VFY+TVN0X qY9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fz5fzGKUkYrlo1H6ujT5iT4E+OF3TxaMGxP6KIooVcQ=; b=SihGJy7enFx2++3cb7w7UyybojhVWmZcWgxde53CsAMjKAVX95DtvOuGQh6Rx4IJT0 eu/BZ8h2quQ0wTJEnUlIK9SGCnaS6SwYm8Ux8iu5o2qzfnaeq0bZFVZw34Fl02s3QxxU iO1u3tv4TW0Yiw8M6OA0mtaH+iZYnIk/eZXGRcYX/ANbJuRhUdrlxDB31ZOnDxmuZdvY vgopL8na+MS0p1CLPdEoHjLF6CRDc7a9CkaUxxiZkn07CNGXRPbW7ZUgq207aifok5iI ZHFeVVgMNEN8A/mhzmFf1uzzhl+sYx4FHseuufwjSb24wD1a/sLtEM0sX7mqXXG0/Gvc YHoQ== X-Gm-Message-State: AGi0PuaSclJ4ZwfiWVoS1PyzJ3t0CePQkKgKJ43gt0PLiEi1SZlc+nOo HLFEYHxu/C89i3f2BsEP/gJKzA== X-Google-Smtp-Source: APiQypKpBJKrBpCU7oIXdhxhHbwoBTjqAi/2yT3gZcDS9xuBm1ijzttixQqfK4ktRUyLkm9P3o0Fcg== X-Received: by 2002:a17:90a:9b82:: with SMTP id g2mr25145882pjp.72.1588006926605; Mon, 27 Apr 2020 10:02:06 -0700 (PDT) Received: from google.com ([2620:15c:201:2:ce90:ab18:83b0:619]) by smtp.gmail.com with ESMTPSA id c14sm11299278pgi.54.2020.04.27.10.02.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2020 10:02:05 -0700 (PDT) Date: Mon, 27 Apr 2020 10:01:59 -0700 From: Sami Tolvanen To: Miguel Ojeda Subject: Re: [PATCH v13 01/12] add support for Clang's Shadow Call Stack (SCS) Message-ID: <20200427170159.GA236495@google.com> References: <20191018161033.261971-1-samitolvanen@google.com> <20200427160018.243569-1-samitolvanen@google.com> <20200427160018.243569-2-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200427_100210_232724_483F7437 X-CRM114-Status: GOOD ( 12.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Juri Lelli , Kernel Hardening , Peter Zijlstra , Catalin Marinas , Will Deacon , Marc Zyngier , Masahiro Yamada , clang-built-linux , Ingo Molnar , Laura Abbott , Dave Martin , Kees Cook , Jann Horn , Steven Rostedt , Linux ARM , Michal Marek , Ard Biesheuvel , Nick Desaulniers , linux-kernel , James Morse , Masami Hiramatsu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 27, 2020 at 06:48:49PM +0200, Miguel Ojeda wrote: > On Mon, Apr 27, 2020 at 6:00 PM Sami Tolvanen wrote: > > > > diff --git a/include/linux/compiler-clang.h b/include/linux/compiler-clang.h > > index 333a6695a918..18fc4d29ef27 100644 > > --- a/include/linux/compiler-clang.h > > +++ b/include/linux/compiler-clang.h > > @@ -42,3 +42,9 @@ > > * compilers, like ICC. > > */ > > #define barrier() __asm__ __volatile__("" : : : "memory") > > + > > +#if __has_feature(shadow_call_stack) > > +# define __noscs __attribute__((__no_sanitize__("shadow-call-stack"))) > > +#else > > +# define __noscs > > +#endif > > Can we remove the `#else` branch? compiler_types.h [*] has to care > anyway about that case for other compilers anyway, no? Yes, it's unnecessary. I'll remove this in the next version. Thanks! Sami _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel