From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C6E0C4724C for ; Thu, 30 Apr 2020 16:09:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 702692082E for ; Thu, 30 Apr 2020 16:09:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="b1ePWSf1"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="aiFJ0XD1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 702692082E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qEy7Rj5VYTOri9RPvkOuY1Fptdts3HY/2c1XLmUeq1E=; b=b1ePWSf1Wx2wOO VbvfwsdsqevyS/QfgTaz9WzPkeQSJweIzLgwO67g7GaM2nYexd8THJN1nVUQPUuKwCPUi1VdswrBq lGqIFEPgHmEMwhMPz4CfZ3a44sPPMxVPs1tAXWc7aOVWZDmLyrzr9o3jTiC4NJhS05+ol9ovjMGCR kE3Z5i7M4btVBDj6RGX6VIRVUxGfMIJJMN2V662bnp1aNsy6OQqFqDG7NCA697U7wdL0oszWImdyc gYWyV55FL1shTXUDxH1dbNBOK5jYMCqaaUuhoS4vMrlsSOvXd6Wt7XLo0lpc+/QQdgXR72Z//hq8K 1npGKzet40S4MQmLvr2g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jUBkm-0003ck-0e; Thu, 30 Apr 2020 16:09:36 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jUBkj-0003c9-6z for linux-arm-kernel@lists.infradead.org; Thu, 30 Apr 2020 16:09:34 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3F8C320775; Thu, 30 Apr 2020 16:09:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588262972; bh=r/iZ/ACtDDImq1DylZtdIeixMKUgzwer84XJj3ATOII=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aiFJ0XD1fLfjJ9034IuQo29241bs9BEG42V84VnmUDzlMwsR3BujtJ/LAjm+5RJa8 3ohSoAfHqJwCQOZAzldvBYuftcxLnD6fpByo4gpKL+DscJdlYZxw0bG72qMMIaQE2+ NdjcY/cKvhJP2AJzGtVfQUNEdOLI52lorPkPaw+w= Date: Thu, 30 Apr 2020 17:09:29 +0100 From: Will Deacon To: Mark Brown Subject: Re: [PATCH v2 3/3] arm64: insn: Report PAC and BTI instructions as NOPs Message-ID: <20200430160928.GD25258@willie-the-truck> References: <20200428172433.48830-1-broonie@kernel.org> <20200428172433.48830-4-broonie@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200428172433.48830-4-broonie@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200430_090933_274960_07625C9C X-CRM114-Status: GOOD ( 14.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 28, 2020 at 06:24:33PM +0100, Mark Brown wrote: > In order to allow probing of PAC and BTI instructions without more > specialized support recognize them as NOPs. > > Signed-off-by: Mark Brown > Acked-by: Catalin Marinas > --- > arch/arm64/kernel/insn.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm64/kernel/insn.c b/arch/arm64/kernel/insn.c > index fd77cdd87c47..82afc582d29a 100644 > --- a/arch/arm64/kernel/insn.c > +++ b/arch/arm64/kernel/insn.c > @@ -57,7 +57,27 @@ bool __kprobes aarch64_insn_is_nop(u32 insn) > if (!aarch64_insn_is_hint(insn)) > return false; > > + /* > + * The PAC and BTI instructons are not strictly NOPs but until > + * better support is added we can treat them as such. > + */ > switch (insn & 0xFE0) { Are you deliberately omitting XPACLRI? If so, maybe add a comment to say why, since it looks a bit weird without it. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel