From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AD67C3A5A9 for ; Mon, 4 May 2020 12:09:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E4052073B for ; Mon, 4 May 2020 12:09:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pPo5TYIn"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="J+utQvjN"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="2k6ruSzK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E4052073B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iT7BD7vYOkNG422CEuS+iswlOH2hM954NIj7c7Y4eTE=; b=pPo5TYInrDoXDx2w6jtPKPGGX LwbCzosu8/BFF7+HfvagA50HqlJpJ5hOQaGM0ly9EHd+pw71wcIcQ4XtS3tR0rx7k6Kdeq8p+grHs vlMCIv/MjfrqN/7xtrDXCQeoGMSbI34HM+6Q6LZWLoCg0cRWc6gQo7eqZ7CAMN6xU+DHr+WCEjHhT fqvSZeVXNws3qwgITdzorGJRIDjYlP3nSa4SM8L0ZEpZ6zSWSr8JNfb3UwlMyyxchWKlUemeYPQtS eIjwM07FuVdWdpnU878U2tfh2gzFWgnEjbvCZCET/+39N5yx0TxyYoaRJ2I8KbDUdAmtQHJ1kuBVM 4RktF167w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVZuy-0003qM-N8; Mon, 04 May 2020 12:09:52 +0000 Received: from wnew3-smtp.messagingengine.com ([64.147.123.17]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVZuv-0003pi-9D for linux-arm-kernel@lists.infradead.org; Mon, 04 May 2020 12:09:51 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.west.internal (Postfix) with ESMTP id 8B7A64FE; Mon, 4 May 2020 08:09:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 04 May 2020 08:09:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=oIv7cAOaUdM7aBwNjylFjp/ACiL s4UI3J+tfLDmHYdY=; b=J+utQvjNQnsvwqzGAhL4HuZL6/tUBeLevzWMkpvOb3F /x/oGFPIAzF9G5oTMnpoh4E55Titshs3p1X4IDefQlVo634I8OzmhJ3OKVXZ4o+l fp5oO5kcwGbl2kZ9nanR0zA3MRVwyNwvpHqUW2rqwlehidEj5lNJ4lUbphUCzI5F y2O3FN/lepFcaaf9Rr3SjlQyVh01NRnhZREvrqgmHqyCIhfdgk18PgsxBgs5b/e/ le3YczrRmE0H72QJFIrlrRuQWsJtCD1whQUtpHYmzuCvk86msFVusnaNL3i/5JOP RG9criY3nTwsprI9FAijlScLa8Nrfeuer2Ug2/NwEsw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=oIv7cA OaUdM7aBwNjylFjp/ACiLs4UI3J+tfLDmHYdY=; b=2k6ruSzKSFiqGFUIu0QbTd if6kMGa4t1N2y05XOVFlw1KczfXrL9iwtj8Bfu1duoQME8A8QgHQet7gCXbyyofV rqwrAqmJbl5/cC07D0UAQU5cP+Czp20tsUH7Ee3YAzu96E1SHZhsHndA7xVd6XXK 60Yy+wW4vcbaVSCH7d7+7K0HWnxjWv7VjO7CfVrXMcUa+8XczyTARKVRytnmEj8x h26USvVAu9IiQX9kqPm21ddO1cTEb0NZ1gkvr2Qsu2/r+qL8c3q2hAifduxwLR/q d1vR3LWUisjKlKkvlC1PfRtpjzbHSmM+cdCkDxNfmlPEj0xEKv9ZBK5B0UEC2eqA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrjeeggdeggecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtudenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeejkeekffdtfffhhfevvddutefgtdeljeevffevvddvteegledtgfeghfehvdei ffenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecukfhppeeltddrkeelrdeikedrje einecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgr gihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 391CC3280065; Mon, 4 May 2020 08:09:45 -0400 (EDT) Date: Mon, 4 May 2020 14:09:42 +0200 From: Maxime Ripard To: =?utf-8?B?Q2zDqW1lbnQgUMOpcm9u?= Subject: Re: [PATCH v3 3/7] ASoC: sun4i-i2s: Add support for H6 I2S Message-ID: <20200504120942.lnrxnnmykqnvw3fb@gilmour.lan> References: <20200426104115.22630-1-peron.clem@gmail.com> <20200426104115.22630-4-peron.clem@gmail.com> <20200428081321.ht3el26yqhsnyfm4@gilmour.lan> <20200429123529.y24dpy63wxq7uvkt@gilmour.lan> <20200430084600.samghw4zxb5zdbez@gilmour.lan> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200504_050949_615962_BE6BC9EE X-CRM114-Status: GOOD ( 26.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Linux-ALSA , linux-kernel , Jernej Skrabec , Takashi Iwai , Rob Herring , Liam Girdwood , Marcus Cooper , Chen-Yu Tsai , Mark Brown , Jaroslav Kysela , linux-arm-kernel Content-Type: multipart/mixed; boundary="===============3179878356431296660==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3179878356431296660== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="m7fwqhxu5jri276t" Content-Disposition: inline --m7fwqhxu5jri276t Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Clement, On Thu, Apr 30, 2020 at 04:00:14PM +0200, Cl=E9ment P=E9ron wrote: > On Thu, 30 Apr 2020 at 10:46, Maxime Ripard wrote: > > On Wed, Apr 29, 2020 at 06:33:00PM +0200, Cl=E9ment P=E9ron wrote: > > > On Wed, 29 Apr 2020 at 14:35, Maxime Ripard wrote: > > > > > > > > On Tue, Apr 28, 2020 at 10:55:47AM +0200, Cl=E9ment P=E9ron wrote: > > > > > > > +static int sun50i_i2s_set_soc_fmt(const struct sun4i_i2s *i2= s, > > > > > > > + unsigned int fmt) > > > > > > > > > > > > The alignment is off here > > > > > > > > > > > > > +{ > > > > > > > + u32 mode, val; > > > > > > > + u8 offset; > > > > > > > + > > > > > > > + /* > > > > > > > + * DAI clock polarity > > > > > > > + * > > > > > > > + * The setup for LRCK contradicts the datasheet, but un= der a > > > > > > > + * scope it's clear that the LRCK polarity is reversed > > > > > > > + * compared to the expected polarity on the bus. > > > > > > > + */ > > > > > > > > > > > > Did you check this or has it been copy-pasted? > > > > > > > > > > copy-pasted, I will check this. > > > > > > > > It's not going to be easy to do this if you only have a board with = HDMI. If you > > > > can't test that easily, just remove the comment (or make it explici= t that you > > > > copy pasted it?), no comment is better than a wrong one. > > > > > > I have talked with Marcus Cooper it may be able to test this this wee= k-end. > > > Also this can explain why we need the " > > > simple-audio-card,frame-inversion;" in the device-tree. > > > > > > If think this fix has been introduced by you, correct? Could you say > > > on which SoC did you see this issue? > > > > This was seen on an H3 >=20 > Just two more questions: > - Did you observe this issue on both TDM and I2S mode? > - On which DAI node? This is fairly fuzzy now and I don't remember if I tested it in I2S. Let's assume I didn't. And similarly, I'm not sure what the exact controller was,= but it was one of the regular controllers (so not either connected to the codec= or the HDMI, one that goes out of the SoC). We had pretty much the same issue on the A33 in I2S for the codec though: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/s= ound/soc/sunxi/sun8i-codec.c?id=3D18c1bf35c1c09bca05cf70bc984a4764e0b0372b I didn't think of it that way then, but it might very well have been the i2s controller suffering the same issue. > Since recent change in sun4i-i2s.c, we had to introduce the > "simple-audio-card,frame-inversion" in LibreElec tree. Do you have a link to that commit ? I couldn't find anything on libreelec's github repo. > H3 boards are quite common in LibreElec community so I think: > - This fix is only needed in TDM mode > - Or this fix is not required for the HDMI DAI node (HDMI DAI is a > little bit different compare to other DAI but I think the first guess > is more likely) Given what we know about the A33, I'd be inclined to say the latter. I'd do= n't have the tools to check anymore, but if you have even a cheap logical analy= zer, i2s being pretty slow you can definitely see it. Maxime --m7fwqhxu5jri276t Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXrAGBgAKCRDj7w1vZxhR xSkHAP4v8wD7S9lG0CmZac6gP5WY97N+CaOtPYTZiajfe48fqQEAy+VK7JRCf5OU L+GaaCtSkSV6kzT4EKtLSbT6ROmKZQ4= =xwQn -----END PGP SIGNATURE----- --m7fwqhxu5jri276t-- --===============3179878356431296660== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3179878356431296660==--