From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFE7FC28CBC for ; Wed, 6 May 2020 15:00:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD9F120A8B for ; Wed, 6 May 2020 15:00:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CsQrcF43" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD9F120A8B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gZ+F7RjboiUydQtO2ieKV4ZoTn7hnr5AAyP8HT0y4i0=; b=CsQrcF43fi392h AQUXeULqrJiOIhn/oOEKkS9Xwp3Xywdf/s9AWcnw+loPsgE/qhfHu91OiuYluJYJqtd6HAaeGWd5G SPfjSnzFqKMPNbQ3au7IkDEskAM6tEsPVGYlcmno2NJx6enXHEkt2SaU+TzRGdSYdgmydrX0dd6i+ CrByQ/df0UMQcy365oiRegZ3I26ou8/rvFD41j+B6ciaCjYDlW/fe5/jVME+yfxtvepaDV5BmU+n6 uLDzGrcrdoI002sw781Bwsn0iLZcnkAjPo0idS35O4XagFPUF7k0lAKoGBjkzk9yGmAr9Qhk8at2E xNljrpcvr7zFUC5eokqg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWLX9-0000Fi-Gi; Wed, 06 May 2020 15:00:27 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWLWx-0007nk-9j for linux-arm-kernel@lists.infradead.org; Wed, 06 May 2020 15:00:17 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E1C59D6E; Wed, 6 May 2020 08:00:12 -0700 (PDT) Received: from gaia (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 59DE63F68F; Wed, 6 May 2020 08:00:11 -0700 (PDT) Date: Wed, 6 May 2020 16:00:01 +0100 From: Catalin Marinas To: Amit Daniel Kachhap Subject: Re: [PATCH v2 1/4] arm64: cpufeature: Extract meta-capability scope from list Message-ID: <20200506145959.GF2878@gaia> References: <1586842314-19527-1-git-send-email-amit.kachhap@arm.com> <1586842314-19527-2-git-send-email-amit.kachhap@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1586842314-19527-2-git-send-email-amit.kachhap@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200506_080015_437830_E3050D4B X-CRM114-Status: GOOD ( 13.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kees Cook , Suzuki K Poulose , Kristina Martsenko , Mark Brown , James Morse , Vincenzo Frascino , Will Deacon , Dave Martin , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 14, 2020 at 11:01:51AM +0530, Amit Daniel Kachhap wrote: > This fixes the earlier commit 3ff047f6971d3c ("arm64: cpufeature: Fix > meta-capability cpufeature check"). This patch was added to fix the > dependency of individual meta-cpucaps checks on the array entry order. This > dependency was specifically added for cpufeature of system scope. > > However this dependency can occur for cpufeature of boot scope such as > ARM64_HAS_ADDRESS_AUTH so this patch renames the helper function > __system_matches_cap to __cpufeature_matches_cap and invokes the match > handler with the scope fetched from the cpufeatures array list. > > Fixes: 3ff047f6971d3c ("arm64: cpufeature: Fix meta-capability cpufeature check") > Signed-off-by: Amit Daniel Kachhap Does this patch need to be merged in 5.7? The fixed commit went in 5.7-rc1 but it doesn't look to me like we'd have a problem without this fix. Basically we read the sanitised regs with SYSTEM_SCOPE rather than the current CPU regs. These are already populated correctly to the register values of the boot CPU. Otherwise I'm fine with the patch, just disputing the Fixes tag. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel