From: Mike Rapoport <rppt@linux.ibm.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Doug Berger <opendmb@gmail.com>, Arnd Bergmann <arnd@arndb.de>,
sboyd@kernel.org, Kevin Cernekee <cernekee@gmail.com>,
rmk+kernel@armlinux.org.uk, Gregory Fong <gregory.0xf0@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: Allow either FLATMEM or SPARSEMEM on the multiplatform build
Date: Thu, 7 May 2020 10:27:11 +0300 [thread overview]
Message-ID: <20200507072711.GB683243@linux.ibm.com> (raw)
In-Reply-To: <20200506235009.25023-3-f.fainelli@gmail.com>
On Wed, May 06, 2020 at 04:50:09PM -0700, Florian Fainelli wrote:
> From: Gregory Fong <gregory.0xf0@gmail.com>
>
> ARMv7 chips with LPAE can often benefit from SPARSEMEM, as portions of
> system memory can be located deep in the 36-bit address space. Allow
> FLATMEM or SPARSEMEM to be selectable at compile time; FLATMEM remains
> the default.
>
> This is based on Kevin's "[PATCH 3/3] ARM: Allow either FLATMEM or
> SPARSEMEM on the multi-v7 build" from [1] and shamelessly rips off his
> commit message text above. As Arnd pointed out at [2] there doesn't
> seem to be any reason to tie this specifically to ARMv7, so this has
> been changed to apply to all multiplatform kernels.
>
> [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-September/286837.html
> [2] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-October/298950.html
>
> Cc: Kevin Cernekee <cernekee@gmail.com>
> Tested-by: Stephen Boyd <sboyd@codeaurora.org>
> Signed-off-by: Gregory Fong <gregory.0xf0@gmail.com>
> Signed-off-by: Doug Berger <opendmb@gmail.com>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> arch/arm/Kconfig | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 5986277296c3..7bb5264a9c3a 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -312,6 +312,8 @@ choice
> config ARCH_MULTIPLATFORM
> bool "Allow multiple platforms to be selected"
> depends on MMU
> + select ARCH_FLATMEM_ENABLE
> + select ARCH_SPARSEMEM_ENABLE
The logic in mm/Kconfig is quite convoluted, so selecting
ARCH_SPARSEMEM_ENABLE will automatically make SPARSEMEM the only option.
On top of this you would need to enable ARCH_SELECT_MEMORY_MODEL, e.g.
something like:
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 7bb5264a9c3a..b6eb1a28ca27 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -314,6 +314,7 @@ config ARCH_MULTIPLATFORM
depends on MMU
select ARCH_FLATMEM_ENABLE
select ARCH_SPARSEMEM_ENABLE
+ select ARCH_SELECT_MEMORY_MODEL
select ARM_HAS_SG_CHAIN
select ARM_PATCH_PHYS_VIRT
select AUTO_ZRELADDR
@@ -1523,6 +1524,9 @@ config ARCH_FLATMEM_ENABLE
config ARCH_SPARSEMEM_ENABLE
bool
+config ARCH_SELECT_MEMORY_MODEL
+ bool
+
config HAVE_ARCH_PFN_VALID
def_bool ARCH_HAS_HOLES_MEMORYMODEL || !SPARSEMEM
> select ARM_HAS_SG_CHAIN
> select ARM_PATCH_PHYS_VIRT
> select AUTO_ZRELADDR
> @@ -1515,6 +1517,9 @@ config OABI_COMPAT
> config ARCH_HAS_HOLES_MEMORYMODEL
> bool
>
> +config ARCH_FLATMEM_ENABLE
> + bool
> +
> config ARCH_SPARSEMEM_ENABLE
> bool
>
> --
> 2.17.1
>
--
Sincerely yours,
Mike.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-07 7:27 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 23:50 [PATCH 0/2] Allow either FLATMEM or SPARSEMEM on the multiplatform build Florian Fainelli
2020-05-06 23:50 ` [PATCH 1/2] ARM: Remove redundant ARCH_SPARSEMEM_DEFAULT setting Florian Fainelli
2020-05-07 7:27 ` Mike Rapoport
2020-05-07 10:30 ` Russell King - ARM Linux admin
2020-05-07 17:25 ` Florian Fainelli
2020-05-07 18:50 ` Russell King - ARM Linux admin
2020-05-07 19:38 ` Florian Fainelli
2020-05-07 20:08 ` [PATCH] arm: use SPARSMEM_STATIC when SPARSEMEM is enabled (Was: [PATCH 1/2] ARM: Remove redundant ARCH_SPARSEMEM_DEFAULT setting) Mike Rapoport
2020-05-08 20:20 ` Florian Fainelli
2020-05-07 20:29 ` [PATCH 1/2] ARM: Remove redundant ARCH_SPARSEMEM_DEFAULT setting Mike Rapoport
2020-05-07 20:47 ` Florian Fainelli
2020-05-08 21:41 ` Mike Rapoport
2020-05-08 21:45 ` Florian Fainelli
2020-05-06 23:50 ` [PATCH 2/2] ARM: Allow either FLATMEM or SPARSEMEM on the multiplatform build Florian Fainelli
2020-05-07 7:27 ` Mike Rapoport [this message]
2020-05-07 20:11 ` Florian Fainelli
2020-05-18 15:58 ` Florian Fainelli
2020-05-18 19:45 ` Mike Rapoport
2020-05-19 7:59 ` Arnd Bergmann
2020-05-19 14:43 ` Mike Rapoport
2020-05-19 15:04 ` Russell King - ARM Linux admin
2020-05-19 15:27 ` Mike Rapoport
2020-05-19 15:32 ` Arnd Bergmann
2020-05-19 16:54 ` Russell King - ARM Linux admin
2020-05-19 17:59 ` Mike Rapoport
2020-05-19 20:42 ` Arnd Bergmann
2020-05-21 2:45 ` Florian Fainelli
2020-05-21 7:47 ` Arnd Bergmann
2020-05-07 8:14 ` [PATCH 0/2] " Russell King - ARM Linux admin
2020-05-07 10:09 ` Mike Rapoport
2020-05-21 8:18 [PATCH 0/2] ARM: " Mike Rapoport
2020-05-21 8:18 ` [PATCH 2/2] " Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200507072711.GB683243@linux.ibm.com \
--to=rppt@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=cernekee@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=gregory.0xf0@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=opendmb@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).