From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F02CC38A2A for ; Thu, 7 May 2020 16:01:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E55202082E for ; Thu, 7 May 2020 16:01:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eqHKsNJO"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ck3JfrNR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E55202082E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6qOJn3InIwXGv8idJAuuWX4w/Uzi4k5neKgCtc6Y4Ck=; b=eqHKsNJO2890pR ZSd8H3HGUM2Z8yRfXpipgrS/i/ujUznJw4xTAPLBKYkuyaEmpdCEaRSl3UV+ml4rrl+vJ8ulG1AJi yfNQDBA+/0c1l+n+gEfJDm0ChHGjInwYoMcPs0v/lZHDwPjqnqjjzonD+N8uwUSpkWB6DtOFyS2P6 tRlalYIY9tLaDE/OlBUlwKGA8UFP0HmfzFSBj8XtIHTEoBFnnaijWFscNdsh49/l/xgyAsjkrN7aJ OaxxAFsWegiOI6rohUjVOkgSxr5KB8+OArA1fe+zcNDWtSm/+no7a/ffEo3au3KZ7r75w24qJpigf 5flApOSX4pwFHJGxVMVQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWixe-0006Nk-Gj; Thu, 07 May 2020 16:01:22 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWixb-0006L6-1L for linux-arm-kernel@lists.infradead.org; Thu, 07 May 2020 16:01:20 +0000 Received: by mail-pg1-x542.google.com with SMTP id j21so2993173pgb.7 for ; Thu, 07 May 2020 09:01:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Qb1yn5t1IPTyFXfHjM+vtDPWSLy9RS5I827KfmdCCPo=; b=Ck3JfrNRWLl4iKhvrbrwAo0aqn2iznGCOPLQN7AZB/I6QIqhcf3pbDchgXrgdxsUQZ r09bBzmYp0r9JmGWIo+471PZRPGKWNqRKYmQcv0AWtZQeweBK//Zkc92SQm0LU/TKDRK cjaTyCgRetkk61Zos0idJaFJ8Uc22QzAahcybaafa3ZFz9Vmg/rbNgBfZ1LiQ6Gc2SSH f+PzK5YUS6X+9FiOIykPkrxpfpEPbSqwIsYXna7y5JukxEIAe25gCn5auYl0BnYGouvU Iu/s7vL+POy1Yz8gtgmUB7kqFQttbdsL2otyzz41gvINlKeOaaLCgpeJP4iCsURPZZb4 EluA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Qb1yn5t1IPTyFXfHjM+vtDPWSLy9RS5I827KfmdCCPo=; b=oHf/aBrcZnER/cNvDsmY5YY0DUlYwOcsMji9jR3yAyfEuIvxBKWIrNOKvTQXz+2ojW t6BM1aMWHySY0GFAliE/pg/MLmrLUPjG3PjQfyFwAFnB4/vXhedh4EdgVJ6YFvCSQAxe M80DG1lSDYhpn7X7kTYFJGxPvlqRGbOYSw0ot7cxe3ptOoBrwGDiruFreRaQXlDdCWF6 O/Q+4r4M0dvbpOBksD5CypgHC0c5VXdO7y0iPNM90GZD2Nw3TviE8ZQSA+LgNor5Nt9N 37NYRfhWNgyXmiOB7CZ/vjBndWtLgISon8FtaDQ2h6p0/A5xDOovm9Ka2/U459roIpvA nGRA== X-Gm-Message-State: AGi0PuZ2aqNoDmPhBboYmSfUmC5R0Dz/Wc0HzgLfFXa3AsVgorQ4NlqI 0YY9dlF9A+iplpZCh9LsruXn4Qip X-Google-Smtp-Source: APiQypIwGDuQgimi4V/sjeD/CcQ9q76z4XBPPy4eInhw8zbWKN+NgHOwT1svgrCLdMyW4GrW/Ppe3w== X-Received: by 2002:a62:7d8c:: with SMTP id y134mr15435058pfc.231.1588867276268; Thu, 07 May 2020 09:01:16 -0700 (PDT) Received: from dtor-ws ([2620:15c:202:201:3c2a:73a9:c2cf:7f45]) by smtp.gmail.com with ESMTPSA id e11sm5321395pfl.85.2020.05.07.09.01.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2020 09:01:15 -0700 (PDT) Date: Thu, 7 May 2020 09:01:13 -0700 From: Dmitry Torokhov To: Chuhong Yuan Subject: Re: [PATCH] Input: stmfts - add missed input_unregister_device Message-ID: <20200507160113.GG89269@dtor-ws> References: <20200507151147.792578-1-hslester96@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200507151147.792578-1-hslester96@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200507_090119_099627_B6764707 X-CRM114-Status: UNSURE ( 8.97 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Torgue , linux-kernel@vger.kernel.org, Maxime Coquelin , linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 07, 2020 at 11:11:47PM +0800, Chuhong Yuan wrote: > This driver calls input_register_device() in probe, but misses > input_unregister_device() in probe failure and remove. > Add the missed function calls to fix it. The input device in question is devm-managed and therefore does not need explicit unregistering. Thanks. -- Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel