From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D70CC433E1 for ; Wed, 13 May 2020 15:47:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C4BF206F5 for ; Wed, 13 May 2020 15:47:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Tb2PM7gZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C4BF206F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xO+IgScr800E4SWJHYf4MN7v1rsw9JN0vMr38UmVoYw=; b=Tb2PM7gZwCqcCR s8ZjVVojCVnXzpptbLa3aCVrNGJP9ZVoW2wlwAOdGczQV/xUiMquMXtulhq7f/6B/D40iShRCMefz aW+Jozi7f/AvMiPO4JwmKY7vl4vgrwZHL/rympdSOEYD3Z/FSfD9PiNgOyMJ3bQInU0aOumi4Pzik +ZvPzE1VjUvrPTsyOB8JnwKQKvcjpb5ChBB7sQdssg2WpLiCemxl/McDX5ca/sgkZmKwM1weXkBaz AmyoHOR5Xk+GNlyVmdPzg3xuRDFM/DcG1ngJseI1U/5XZ+0uMRNT8nCxoB3Cbflhc1YT0eEdX6zoY 6KQGNWjylqnOHsGmgU9w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYtbX-0002U7-O2; Wed, 13 May 2020 15:47:31 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYtbT-0002Rz-6A; Wed, 13 May 2020 15:47:28 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A8EE931B; Wed, 13 May 2020 08:47:26 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0513B3F305; Wed, 13 May 2020 08:47:24 -0700 (PDT) Date: Wed, 13 May 2020 16:47:19 +0100 From: Lorenzo Pieralisi To: Nicolas Saenz Julienne Subject: Re: [PATCH v8 0/4] USB: pci-quirks: Add Raspberry Pi 4 quirk Message-ID: <20200513154719.GA3486@e121166-lin.cambridge.arm.com> References: <20200505161318.26200-1-nsaenzjulienne@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200505161318.26200-1-nsaenzjulienne@suse.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200513_084727_415542_119ACA38 X-CRM114-Status: GOOD ( 20.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , f.fainelli@gmail.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, tim.gover@raspberrypi.org, helgaas@kernel.org, wahrenst@gmx.net, linux-pci@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 05, 2020 at 06:13:13PM +0200, Nicolas Saenz Julienne wrote: > On the Raspberry Pi 4, after a PCI reset, VL805's firmware may either be > loaded directly from an EEPROM or, if not present, by the SoC's > co-processor, VideoCore. This series adds support for the later. > > Note that there are a set of constraints we have to consider: > - We need to make sure the VideoCore firmware interface is up and > running before running the VL805 firmware load call. > > - There is no way to discern RPi4's VL805 chip from other platforms', > so we need the firmware load to happen *before* running > quirk_usb_handoff_xhci(). Failure to do so results in an unwarranted > 5 second wait while the fixup code polls xHC's non-existing state. > > By Florian's suggestion I've been spending some time exploring the device > link[1] API in order to see if that could save us from explicitly creating > probe dependencies between pcie-brcmstb and firmware/raspberrypi (patch #3). > Technically these dependencies could be inferred from DT. It turns out Saravana > Kannan has been looking at this already. A new boot mechanism, activated with > fw_devlink=on takes care of the device probe ordering on devices with > consumer/supplier relationships. For now this relationship is created based on > the usage of generic DT properties, but has no support for vendor-specifc DT > properties, which we'd be forced to use in order to create a relationship > between our two devices since our setup is highly non generic. There will > probably be at some point support for such properties, and we will then be able > to revisit some of this code. > > All this is based on the work by Tim Gover in RPi's downstream > kernel[2]. > > [1] https://www.kernel.org/doc/html/v4.13/driver-api/device_link.html > [2] https://github.com/raspberrypi/linux/commit/9935b4c7e360b4494b4cb6e3ce797238a1ab78bd > > --- > > Changes since v7: > - Address Stefan's comments > > Changes since v6: > - Make rpi_firmware_init_vl805() more robust > - Rewrite comments and patch descriptions to be more accessible to non RPi > fluent people > - Removed Florian's Reviewed-by in patch #2 as function changed > substantially > - Tested with/witout u-boot > > Changes since v5: > - Fix issues reported by Kbuild test robot > > Changes since v4: > - Addressed Sergei's comments > - Fix potential warning in patch #2 > > Changes since v3: > - Addressed Greg's comments > > There was no v2, my bad. > > Changes since v1: > - Addressed Floarians comments > > Nicolas Saenz Julienne (4): > soc: bcm2835: Add notify xHCI reset property > firmware: raspberrypi: Introduce vl805 init routine > PCI: brcmstb: Wait for Raspberry Pi's firmware when present > USB: pci-quirks: Add Raspberry Pi 4 quirk > > drivers/firmware/Kconfig | 3 +- > drivers/firmware/raspberrypi.c | 61 ++++++++++++++++++++++ > drivers/pci/controller/pcie-brcmstb.c | 17 ++++++ > drivers/usb/host/pci-quirks.c | 16 ++++++ > include/soc/bcm2835/raspberrypi-firmware.h | 9 +++- > 5 files changed, 104 insertions(+), 2 deletions(-) Applied to pci/brcmstb, thanks ! Lorenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel