From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A4DEC433E0 for ; Mon, 18 May 2020 03:49:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 532BA20787 for ; Mon, 18 May 2020 03:49:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QHZLQF14" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 532BA20787 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XAIsDyqPj/bvNbt2NssikuIfkKknkZYD0mb1bbRNrlY=; b=QHZLQF14nb0u+H cm44q47Cp1sGMihALAmKo9tKYnqkqGASeMJLL7qw4GwIL7gtf5DifZcy0bGKkmMJHgo29cqUB8Bqv CnbzoSiRxn417STWG9ZYA4vJAFDDTTmw8mEfgRbhbOEwmK2VPdUtXw/pvpif1EfyI47qFSBAopRQs 5EER04ix3xSdIHRRYRlq9ZbkGsZnT2m3xkhHRbYrTw3q0jJj+AiQVNwxMuHKZ9xJyeuRWVePHYFKo yFLMJ4/PhXdGZ2Z7DEGsbrTUfXhvjmaYaBP+5VbWlsmWkcSgQRH34SlB9resfj+ySxQ6rjGHKOsK7 qPSRHWiS6J36wM0fiFhA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jaWmf-0000BG-QM; Mon, 18 May 2020 03:49:45 +0000 Received: from mga14.intel.com ([192.55.52.115]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jaWmc-0000Ap-Fl; Mon, 18 May 2020 03:49:44 +0000 IronPort-SDR: hLY7IlTYqFkVpGkkWIkBMy1QEJLtzA2L8XGsm5OEpz8QP9SRR4JEh/uesd7W3ROvgONO1J8U4a KNa+zkS40kSA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2020 20:49:40 -0700 IronPort-SDR: QZjHgmmyJD5wcejwNXYudRxBmBXktkRK66clSGT09vVfYOCh2mQO0TRV8oDbLvZwqQC7nEa8om xW1Fi6/1MBPA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,405,1583222400"; d="scan'208";a="263820256" Received: from iweiny-desk2.sc.intel.com ([10.3.52.147]) by orsmga003.jf.intel.com with ESMTP; 17 May 2020 20:49:39 -0700 Date: Sun, 17 May 2020 20:49:39 -0700 From: Ira Weiny To: Guenter Roeck Subject: Re: [PATCH V3 07/15] arch/kunmap_atomic: Consolidate duplicate code Message-ID: <20200518034938.GA3023182@iweiny-DESK2.sc.intel.com> References: <20200507150004.1423069-1-ira.weiny@intel.com> <20200507150004.1423069-8-ira.weiny@intel.com> <20200516223306.GA161252@roeck-us.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200516223306.GA161252@roeck-us.net> User-Agent: Mutt/1.11.1 (2018-12-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200517_204942_536393_7BC63E2B X-CRM114-Status: GOOD ( 15.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Zijlstra , Benjamin Herrenschmidt , Dave Hansen , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, "James E.J. Bottomley" , Max Filippov , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Dan Williams , Helge Deller , x86@kernel.org, linux-csky@vger.kernel.org, Christoph Hellwig , Ingo Molnar , linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, Borislav Petkov , Al Viro , Andy Lutomirski , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Chris Zankel , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Koenig , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, May 16, 2020 at 03:33:06PM -0700, Guenter Roeck wrote: > On Thu, May 07, 2020 at 07:59:55AM -0700, ira.weiny@intel.com wrote: > > From: Ira Weiny > > = > > Every single architecture (including !CONFIG_HIGHMEM) calls... > > = > > pagefault_enable(); > > preempt_enable(); > > = > > ... before returning from __kunmap_atomic(). Lift this code into the > > kunmap_atomic() macro. > > = > > While we are at it rename __kunmap_atomic() to kunmap_atomic_high() to > > be consistent. > > = > > Reviewed-by: Christoph Hellwig > > Signed-off-by: Ira Weiny > = > This patch results in: > = > Starting init: /bin/sh exists but couldn't execute it (error -14) > = > when trying to boot microblazeel:petalogix-ml605 in qemu. Thanks for the report. I'm not readily seeing the issue. Do you have a kernel config? Specifically is CONFIG_HIGHMEM set? > = > Bisect log attached. > = > Guenter > = > --- > # bad: [bdecf38f228bcca73b31ada98b5b7ba1215eb9c9] Add linux-next specific= files for 20200515 > # good: [2ef96a5bb12be62ef75b5828c0aab838ebb29cb8] Linux 5.7-rc5 > git bisect start 'HEAD' 'v5.7-rc5' > # good: [3674d7aa7a8e61d993886c2fb7c896c5ef85e988] Merge remote-tracking = branch 'crypto/master' > git bisect good 3674d7aa7a8e61d993886c2fb7c896c5ef85e988 > # good: [87f6f21783522e6d62127cf33ae5e95f50874beb] Merge remote-tracking = branch 'spi/for-next' > git bisect good 87f6f21783522e6d62127cf33ae5e95f50874beb > # good: [5c428e8277d5d97c85126387d4e00aa5adde4400] Merge remote-tracking = branch 'staging/staging-next' > git bisect good 5c428e8277d5d97c85126387d4e00aa5adde4400 > # good: [f68de67ed934e7bdef4799fd7777c86f33f14982] Merge remote-tracking = branch 'hyperv/hyperv-next' > git bisect good f68de67ed934e7bdef4799fd7777c86f33f14982 > # bad: [54acd2dc52b069da59639eea0d0c92726f32fb01] mm/memblock: fix a typo= in comment "implict"->"implicit" > git bisect bad 54acd2dc52b069da59639eea0d0c92726f32fb01 > # good: [784a17aa58a529b84f7cc50f351ed4acf3bd11f3] mm: remove the pgprot = argument to __vmalloc > git bisect good 784a17aa58a529b84f7cc50f351ed4acf3bd11f3 > # good: [6cd8137ff37e9a37aee2d2a8889c8beb8eab192f] khugepaged: replace th= e usage of system(3) in the test > git bisect good 6cd8137ff37e9a37aee2d2a8889c8beb8eab192f > # bad: [6987da379826ed01b8a1cf046b67cc8cc10117cc] sparc: remove unnecessa= ry includes > git bisect bad 6987da379826ed01b8a1cf046b67cc8cc10117cc > # good: [bc17b545388f64c09e83e367898e28f60277c584] mm/hugetlb: define a g= eneric fallback for is_hugepage_only_range() > git bisect good bc17b545388f64c09e83e367898e28f60277c584 > # bad: [9b5aa5b43f957f03a1f4a9aff5f7924e2ebbc011] arch-kmap_atomic-consol= idate-duplicate-code-checkpatch-fixes > git bisect bad 9b5aa5b43f957f03a1f4a9aff5f7924e2ebbc011 > # good: [0941a38ff0790c1004270f952067a5918a4ba32d] arch/kmap: remove redu= ndant arch specific kmaps > git bisect good 0941a38ff0790c1004270f952067a5918a4ba32d > # good: [56e635a64c2cbfa815c851af10e0f811e809977b] arch-kunmap-remove-dup= licate-kunmap-implementations-fix > git bisect good 56e635a64c2cbfa815c851af10e0f811e809977b > # bad: [60f96b2233c790d4f1c49317643051f1670bcb29] arch/kmap_atomic: conso= lidate duplicate code > git bisect bad 60f96b2233c790d4f1c49317643051f1670bcb29 > # good: [7b3708dc3bf72a647243064fe7ddf9a76248ddfd] {x86,powerpc,microblaz= e}/kmap: move preempt disable > git bisect good 7b3708dc3bf72a647243064fe7ddf9a76248ddfd > # first bad commit: [60f96b2233c790d4f1c49317643051f1670bcb29] arch/kmap_= atomic: consolidate duplicate code I'm confused by this. This points to an earlier commit being bad? commit 60f96b2233c790d4f1c49317643051f1670bcb29 = = Author: Ira Weiny = = Date: Thu May 14 13:39:54 2020 +1000 = = = = arch/kmap_atomic: consolidate duplicate code = = = = Every arch has the same code to ensure atomic operations and a check fo= r = !HIGHMEM page. = = = = Remove the duplicate code by defining a core kmap_atomic() which only = = calls the arch specific kmap_atomic_high() when the page is high memory= . = = = Link: http://lkml.kernel.org/r/20200507150004.1423069-7-ira.weiny@intel= .com = Signed-off-by: Ira Weiny = = Reviewed-by: Christoph Hellwig = = Cc: Al Viro = = Cc: Andy Lutomirski = = Cc: Benjamin Herrenschmidt = = Cc: Borislav Petkov = = Cc: Christian K=F6nig = = Cc: Chris Zankel = = Cc: Daniel Vetter = = Cc: Dan Williams = = Cc: Dave Hansen = = Cc: "David S. Miller" = = Cc: Helge Deller = = Cc: "H. Peter Anvin" = = Cc: Ingo Molnar = = Cc: "James E.J. Bottomley" = = Cc: Max Filippov = = Cc: Paul Mackerras = = Cc: Peter Zijlstra = = Cc: Thomas Bogendoerfer = = Cc: Thomas Gleixner = = Signed-off-by: Andrew Morton = = Signed-off-by: Stephen Rothwell = = Any idea which one it is? Ira _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel