Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 0/2] add generic DT binding for RTS/CTS
@ 2020-05-20 13:39 Erwan Le Ray
  2020-05-20 13:39 ` [PATCH 1/2] dt-bindings: serial: add generic DT binding for announcing RTS/CTS lines Erwan Le Ray
  2020-05-20 13:39 ` [PATCH 2/2] serial: stm32: Use " Erwan Le Ray
  0 siblings, 2 replies; 6+ messages in thread
From: Erwan Le Ray @ 2020-05-20 13:39 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Mark Rutland, Maxime Coquelin,
	Alexandre Torgue, Sumit Semwal
  Cc: linux-kernel, dri-devel, linaro-mm-sig, Erwan Le Ray,
	linux-serial, Fabrice Gasnier, linux-stm32, linux-arm-kernel,
	linux-media

Add support of generic DT binding for annoucing RTS/CTS lines. The initial
binding 'st,hw-flow-control' is not needed anymore since generic binding
is available, but is kept for backward compatibility.

Erwan Le Ray (2):
  dt-bindings: serial: add generic DT binding for announcing RTS/CTS
    lines
  serial: stm32: Use generic DT binding for announcing RTS/CTS lines

 Documentation/devicetree/bindings/serial/st,stm32-uart.yaml | 4 +++-
 drivers/tty/serial/stm32-usart.c                            | 5 +++--
 2 files changed, 6 insertions(+), 3 deletions(-)

-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] dt-bindings: serial: add generic DT binding for announcing RTS/CTS lines
  2020-05-20 13:39 [PATCH 0/2] add generic DT binding for RTS/CTS Erwan Le Ray
@ 2020-05-20 13:39 ` Erwan Le Ray
  2020-06-27 14:18   ` Greg Kroah-Hartman
  2020-05-20 13:39 ` [PATCH 2/2] serial: stm32: Use " Erwan Le Ray
  1 sibling, 1 reply; 6+ messages in thread
From: Erwan Le Ray @ 2020-05-20 13:39 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Mark Rutland, Maxime Coquelin,
	Alexandre Torgue, Sumit Semwal
  Cc: linux-kernel, dri-devel, linaro-mm-sig, Erwan Le Ray,
	linux-serial, Fabrice Gasnier, linux-stm32, linux-arm-kernel,
	linux-media

Add support of generic DT binding for annoucing RTS/CTS lines. The initial
binding 'st,hw-flow-control' is not needed anymore since generic binding
is available, but is kept for backward compatibility.

Signed-off-by: Erwan Le Ray <erwan.leray@st.com>

diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
index 75b8521eb7cb..06d5f251ec88 100644
--- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
+++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
@@ -35,9 +35,11 @@ properties:
     description: label associated with this uart
 
   st,hw-flow-ctrl:
-    description: enable hardware flow control
+    description: enable hardware flow control (deprecated)
     $ref: /schemas/types.yaml#/definitions/flag
 
+  uart-has-rtscts: true
+
   dmas:
     minItems: 1
     maxItems: 2
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 2/2] serial: stm32: Use generic DT binding for announcing RTS/CTS lines
  2020-05-20 13:39 [PATCH 0/2] add generic DT binding for RTS/CTS Erwan Le Ray
  2020-05-20 13:39 ` [PATCH 1/2] dt-bindings: serial: add generic DT binding for announcing RTS/CTS lines Erwan Le Ray
@ 2020-05-20 13:39 ` Erwan Le Ray
  1 sibling, 0 replies; 6+ messages in thread
From: Erwan Le Ray @ 2020-05-20 13:39 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Mark Rutland, Maxime Coquelin,
	Alexandre Torgue, Sumit Semwal
  Cc: linux-kernel, dri-devel, linaro-mm-sig, Erwan Le Ray,
	linux-serial, Fabrice Gasnier, linux-stm32, linux-arm-kernel,
	linux-media

Add support of generic DT binding for annoucing RTS/CTS lines. The initial
binding 'st,hw-flow-control' is not needed anymore since generic binding
is available, but is kept for backward compatibility.

Signed-off-by: Erwan Le Ray <erwan.leray@st.com>

diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c
index 17c2f3276888..9cfcf355567a 100644
--- a/drivers/tty/serial/stm32-usart.c
+++ b/drivers/tty/serial/stm32-usart.c
@@ -1033,8 +1033,9 @@ static struct stm32_port *stm32_of_get_stm32_port(struct platform_device *pdev)
 	if (WARN_ON(id >= STM32_MAX_PORTS))
 		return NULL;
 
-	stm32_ports[id].hw_flow_control = of_property_read_bool(np,
-							"st,hw-flow-ctrl");
+	stm32_ports[id].hw_flow_control =
+		of_property_read_bool (np, "st,hw-flow-ctrl") /*deprecated*/ ||
+		of_property_read_bool (np, "uart-has-rtscts");
 	stm32_ports[id].port.line = id;
 	stm32_ports[id].cr1_irq = USART_CR1_RXNEIE;
 	stm32_ports[id].cr3_irq = 0;
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] dt-bindings: serial: add generic DT binding for announcing RTS/CTS lines
  2020-05-20 13:39 ` [PATCH 1/2] dt-bindings: serial: add generic DT binding for announcing RTS/CTS lines Erwan Le Ray
@ 2020-06-27 14:18   ` Greg Kroah-Hartman
  2020-06-29  8:13     ` Erwan LE RAY
  2020-06-30 18:35     ` Rob Herring
  0 siblings, 2 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2020-06-27 14:18 UTC (permalink / raw)
  To: Erwan Le Ray
  Cc: Mark Rutland, Maxime Coquelin, Alexandre Torgue, linux-kernel,
	dri-devel, linux-stm32, linaro-mm-sig, Rob Herring, linux-serial,
	Fabrice Gasnier, Sumit Semwal, linux-arm-kernel, linux-media

On Wed, May 20, 2020 at 03:39:31PM +0200, Erwan Le Ray wrote:
> Add support of generic DT binding for annoucing RTS/CTS lines. The initial
> binding 'st,hw-flow-control' is not needed anymore since generic binding
> is available, but is kept for backward compatibility.
> 
> Signed-off-by: Erwan Le Ray <erwan.leray@st.com>
> 
> diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> index 75b8521eb7cb..06d5f251ec88 100644
> --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> @@ -35,9 +35,11 @@ properties:
>      description: label associated with this uart
>  
>    st,hw-flow-ctrl:
> -    description: enable hardware flow control
> +    description: enable hardware flow control (deprecated)
>      $ref: /schemas/types.yaml#/definitions/flag
>  
> +  uart-has-rtscts: true
> +
>    dmas:
>      minItems: 1
>      maxItems: 2
> -- 
> 2.17.1
> 

Did this get ignored by the DT maintainers?  :(

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] dt-bindings: serial: add generic DT binding for announcing RTS/CTS lines
  2020-06-27 14:18   ` Greg Kroah-Hartman
@ 2020-06-29  8:13     ` Erwan LE RAY
  2020-06-30 18:35     ` Rob Herring
  1 sibling, 0 replies; 6+ messages in thread
From: Erwan LE RAY @ 2020-06-29  8:13 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring
  Cc: Mark Rutland, Maxime Coquelin, Alexandre TORGUE, linux-kernel,
	dri-devel, Sumit Semwal, linaro-mm-sig, linux-serial,
	Fabrice GASNIER, linux-stm32, linux-arm-kernel, linux-media


On 6/27/20 4:18 PM, Greg Kroah-Hartman wrote:
> On Wed, May 20, 2020 at 03:39:31PM +0200, Erwan Le Ray wrote:
>> Add support of generic DT binding for annoucing RTS/CTS lines. The initial
>> binding 'st,hw-flow-control' is not needed anymore since generic binding
>> is available, but is kept for backward compatibility.
>>
>> Signed-off-by: Erwan Le Ray <erwan.leray@st.com>
>>
>> diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
>> index 75b8521eb7cb..06d5f251ec88 100644
>> --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
>> +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
>> @@ -35,9 +35,11 @@ properties:
>>       description: label associated with this uart
>>   
>>     st,hw-flow-ctrl:
>> -    description: enable hardware flow control
>> +    description: enable hardware flow control (deprecated)
>>       $ref: /schemas/types.yaml#/definitions/flag
>>   
>> +  uart-has-rtscts: true
>> +
>>     dmas:
>>       minItems: 1
>>       maxItems: 2
>> -- 
>> 2.17.1
>>
> Did this get ignored by the DT maintainers?  :(

Hi Rob,

Gentle reminder. Could you please provide your feedback on this patch ?

Best Regards, Erwan.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] dt-bindings: serial: add generic DT binding for announcing RTS/CTS lines
  2020-06-27 14:18   ` Greg Kroah-Hartman
  2020-06-29  8:13     ` Erwan LE RAY
@ 2020-06-30 18:35     ` Rob Herring
  1 sibling, 0 replies; 6+ messages in thread
From: Rob Herring @ 2020-06-30 18:35 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Mark Rutland, Fabrice Gasnier, Maxime Coquelin, linux-kernel,
	dri-devel, linux-stm32, linaro-mm-sig,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	open list:SERIAL DRIVERS, Linux Media Mailing List, Sumit Semwal,
	Erwan Le Ray, Alexandre Torgue

On Sat, Jun 27, 2020 at 8:18 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Wed, May 20, 2020 at 03:39:31PM +0200, Erwan Le Ray wrote:
> > Add support of generic DT binding for annoucing RTS/CTS lines. The initial
> > binding 'st,hw-flow-control' is not needed anymore since generic binding
> > is available, but is kept for backward compatibility.
> >
> > Signed-off-by: Erwan Le Ray <erwan.leray@st.com>
> >
> > diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> > index 75b8521eb7cb..06d5f251ec88 100644
> > --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> > +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> > @@ -35,9 +35,11 @@ properties:
> >      description: label associated with this uart
> >
> >    st,hw-flow-ctrl:
> > -    description: enable hardware flow control
> > +    description: enable hardware flow control (deprecated)
> >      $ref: /schemas/types.yaml#/definitions/flag
> >
> > +  uart-has-rtscts: true
> > +
> >    dmas:
> >      minItems: 1
> >      maxItems: 2
> > --
> > 2.17.1
> >
>
> Did this get ignored by the DT maintainers?  :(

When it doesn't go to the DT list, you are playing roulette whether I
happen to see it. :(

Anyways,

Reviewed-by: Rob Herring <robh@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-20 13:39 [PATCH 0/2] add generic DT binding for RTS/CTS Erwan Le Ray
2020-05-20 13:39 ` [PATCH 1/2] dt-bindings: serial: add generic DT binding for announcing RTS/CTS lines Erwan Le Ray
2020-06-27 14:18   ` Greg Kroah-Hartman
2020-06-29  8:13     ` Erwan LE RAY
2020-06-30 18:35     ` Rob Herring
2020-05-20 13:39 ` [PATCH 2/2] serial: stm32: Use " Erwan Le Ray

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org
	public-inbox-index linux-arm-kernel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git