From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 668DEC433E0 for ; Thu, 21 May 2020 09:14:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3CDB22070A for ; Thu, 21 May 2020 09:14:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="A9v5Ud4v"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="MaaiESZ6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3CDB22070A Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Oix0jnQbt0oVjB+zILKV19vRJUoSEMtmasybwlIbbfs=; b=A9v5Ud4v8Lo9td BR6Cj3Xp0IVRB3YIk1BEByqfEndMp7pQGhrKzA6Yi1jMyJ0NiL7DJKDiM45/SbrVo7fNfi+dDE9Gx Qm0Io7hN5/r2uFoKfAIoaEnh7jdYV0kgXqun3WNrvE74hpVsMIvKylUdQGPWhqzeGallh1ire64bf 5x/YRnwf/XSXSCOXqEThXtrtkWT2ySQelQFgLuMumrp4iISZh8SAcfvW/fymaNjKxKjrV+uyZ1/60 fv/ucAJNVCeebuXc78J3oTop+OU19u9AKERBaBvf33MmajEAWIBoxGljW6UaqZJx2jp72o+82BiRf A8gabyY2IaDNV7T0FPmA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbhHx-00084z-QE; Thu, 21 May 2020 09:14:53 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbhHu-00084Z-CH; Thu, 21 May 2020 09:14:51 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 04L9EdMR013665; Thu, 21 May 2020 04:14:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1590052479; bh=6TWapEuxg8nAckEhBpE445YKmDj0TJ/xlqg6Fj94UN0=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=MaaiESZ6aMqcrpmJHO1mfIi6xcBPy89FLOWsTC7LaSKeRbpKblQVGffGtUkHPmsGz KtTJ6G2zE9wgGcvBYU37tyagCvHpizRCMMgOcroPyoWwWwrT8AucyU/I2e2Pw/IwO9 c3yoOkpPkfW2mWbh18+Ej1+oCaJOw0jBQh2uczPA= Received: from DFLE108.ent.ti.com (dfle108.ent.ti.com [10.64.6.29]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 04L9EdvO010693 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 21 May 2020 04:14:39 -0500 Received: from DFLE108.ent.ti.com (10.64.6.29) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Thu, 21 May 2020 04:14:39 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Thu, 21 May 2020 04:14:39 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 04L9EcT0062434; Thu, 21 May 2020 04:14:39 -0500 Date: Thu, 21 May 2020 14:44:36 +0530 From: Pratyush Yadav To: Subject: Re: [PATCH v5 09/19] mtd: spi-nor: sfdp: parse xSPI Profile 1.0 table Message-ID: <20200521091434.rigqlyuwszyyikj4@ti.com> References: <20200519142642.24131-1-p.yadav@ti.com> <20200519142642.24131-10-p.yadav@ti.com> <20200520085534.yra4f5ww5xs23c4j@ti.com> <20200520103728.jtbslowdfrv3o5yz@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200521_021450_517525_5FDE6658 X-CRM114-Status: GOOD ( 22.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Vignesh Raghavendra , Tudor Ambarus , juliensu@mxic.com.tw, Richard Weinberger , Mark Brown , Sekhar Nori , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Ludovic Desroches , Boris Brezillon , linux-mediatek@lists.infradead.org, Miquel Raynal , Matthias Brugger , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21/05/20 04:09PM, masonccyang@mxic.com.tw wrote: > > Hi Pratyush, > > > > > > > + /* Get 8D-8D-8D fast read opcode and dummy cycles. */ > > > > > > + opcode = FIELD_GET(PROFILE1_DWORD1_RD_FAST_CMD, table[0]); > > > > > > + > > > > > > + /* > > > > > > + * Update the fast read settings. We set the default dummy > > > cycles to > > > > > 20 > > > > > > + * here. Flashes can change this value if they need to when > > > enabling > > > > > > + * octal mode. > > > > > > + */ > > > > > > + > spi_nor_set_read_settings(¶ms->reads[SNOR_CMD_READ_8_8_8_DTR], > > > > > > + 0, 20, opcode, > > > > > > + SNOR_PROTO_8_8_8_DTR); > > > > > > + > > > > > > > > > > > > > > > I thought we have a agreement that only do parse here, no other > read > > > > > parameters setting. > > > > > > > > Yes, and I considered it. But it didn't make much sense to me to > > > > introduce an extra member in struct spi_nor just to make this call > in > > > > some other function later. > > > > > > > > Why exactly do you think doing this here is bad? The way I see it, > we > > > > avoid carrying around an extra member in spi_nor and this also > allows > > > > flashes to change the read settings easily in a post-sfdp hook. The > > > > 4bait parsing function does something similar. > > > > > > I think it's not a question for good or bad. > > > > > > 4bait parsing function parse the 4-Byte Address Instruction Table > > > and set up read/pp parameters there for sure. > > > > > > Here we give the function name spi_nor_parse_profile1() but also > > > > But the function that parses 4bait table is also called > > spi_nor_parse_4bait(). > > > > > do others setting that has nothing to do with it, > > > > Why has setting read opcode and dummy cycles got nothing to do with it? > > The purpose of the Profile 1.0 table is to tell us the Read Fast > > command and dummy cycles, among other things. I think it _does_ have > > something to do with it. > > As you know I mean this function just do parse parameter of profile 1 > table > and keep these value data for later usage. > > A device supports xSPI profile table could work in either 8S-8S-8S or > 8D-8D-8D mode. > It seems to setup these parameters somewhere out here is betters. As far as I know, the Profile 1.0 table only describes 8D-8D-8D mode. I see no mention of 8S-8S-8S in JESD251 or JESD216D.01. No field in the table describes anything related to 8S. In fact, searching for "8S" in the JESD251 spec yields 0 results. Anyway, you should set up 8S parameters in SNOR_CMD_READ_8_8_8, not SNOR_CMD_READ_8_8_8_DTR. 8D configuration is independent of 8S configuration. PS: If you have any more comments, please send them now. The merge window is getting close, and I'd like to see this make it in. -- Regards, Pratyush Yadav Texas Instruments India _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel