From: Andrey Konovalov <andrey.konovalov@linaro.org>
To: mchehab@kernel.org, sakari.ailus@iki.fi,
manivannan.sadhasivam@linaro.org
Cc: devicetree@vger.kernel.org, c.barrett@framos.com,
linux-kernel@vger.kernel.org, a.brela@framos.com,
peter.griffin@linaro.org,
Andrey Konovalov <andrey.konovalov@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: [PATCH v3 00/10] Improvements to IMX290 CMOS driver
Date: Sun, 24 May 2020 22:24:55 +0300 [thread overview]
Message-ID: <20200524192505.20682-1-andrey.konovalov@linaro.org> (raw)
This patchset adds improvements to the existing media driver for IMX290
CMOS sensor from Sony. The major changes are adding 2 lane support,
configurable link frequency & pixel rate, test pattern generation, and
RAW12 mode support.
The link frequency & pixel rate combinations depend on various factors like
lane count, resolution and image format as per the datasheet.
Also fixes for the following issues in the existing driver are included:
* the current_format field in the struct imx290 can be used before
initialization,
* the reset signal to IMX290 isn't handled correctly,
* the bus_type field of v4l2_fwnode_endpoint structure passed as the
argument to v4l2_fwnode_endpoint_alloc_parse() function is not
initiaized.
Changes in v3:
* The review comments from Sakari are addressed
https://lkml.org/lkml/2019/12/19/705
As a part of those changes:
. null ptr checks are added to imx290_set_fmt() so that it can be called
early in the probe() function to set the default format, and to
initialize imx290->current_mode and imx290->bpp - these last two must be
set before imx290_calc_pixel_rate() is called when creating the controls
. setting imx290->bpp removed from imx290_write_current_format(). Now this
function only writes to the camera sensor registers. The call to
imx290_write_current_format() is moved from imx290_set_fmt() back to
imx290_start_streaming(): imx290_set_fmt() can be called when the sensor
is powered off, and writes to the sensor registers would fail.
. in imx290_set_ctrl() in the 12 bpp case the value the BLKLEVEL register
is restored to when the test pattern is disabled is made consistent with
imx290_12bit_settings[]
* The "IMX290 sensor driver fixes" patchset included
https://patchwork.kernel.org/cover/11407347/
* Added a patch to set the bus_type field of v4l2_fwnode_endpoint structure
before calling v4l2_fwnode_endpoint_alloc_parse()
Andrey Konovalov (4):
media: i2c: imx290: set the format before VIDIOC_SUBDEV_G_FMT is
called
media: i2c: imx290: fix the order of the args in SET_RUNTIME_PM_OPS()
media: i2c: imx290: fix reset GPIO pin handling
media: i2c: imx290: set bus_type before calling
v4l2_fwnode_endpoint_alloc_parse()
Manivannan Sadhasivam (6):
media: i2c: imx290: Add support for 2 data lanes
media: i2c: imx290: Add configurable link frequency and pixel rate
media: i2c: imx290: Add support for test pattern generation
media: i2c: imx290: Add RAW12 mode support
media: i2c: imx290: Add support to enumerate all frame sizes
media: i2c: imx290: Move the settle time delay out of loop
drivers/media/i2c/imx290.c | 358 ++++++++++++++++++++++++++++++-------
1 file changed, 297 insertions(+), 61 deletions(-)
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2020-05-24 19:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-24 19:24 Andrey Konovalov [this message]
2020-05-24 19:24 ` [PATCH v3 01/10] media: i2c: imx290: set the format before VIDIOC_SUBDEV_G_FMT is called Andrey Konovalov
2020-05-24 19:24 ` [PATCH v3 02/10] media: i2c: imx290: fix the order of the args in SET_RUNTIME_PM_OPS() Andrey Konovalov
2020-05-24 19:24 ` [PATCH v3 03/10] media: i2c: imx290: fix reset GPIO pin handling Andrey Konovalov
2020-05-24 19:24 ` [PATCH v3 04/10] media: i2c: imx290: Add support for 2 data lanes Andrey Konovalov
2020-05-26 9:01 ` Sakari Ailus
2020-05-26 9:14 ` Andrey Konovalov
2020-05-26 9:16 ` Sakari Ailus
2020-05-24 19:25 ` [PATCH v3 05/10] media: i2c: imx290: Add configurable link frequency and pixel rate Andrey Konovalov
2020-05-26 9:12 ` Sakari Ailus
2020-05-26 9:27 ` Andrey Konovalov
2020-05-26 9:58 ` Sakari Ailus
2020-05-27 14:43 ` kbuild test robot
2020-05-24 19:25 ` [PATCH v3 06/10] media: i2c: imx290: Add support for test pattern generation Andrey Konovalov
2020-05-24 19:25 ` [PATCH v3 07/10] media: i2c: imx290: Add RAW12 mode support Andrey Konovalov
2020-05-26 16:05 ` Dave Stevenson
2020-05-27 8:42 ` Andrey Konovalov
2020-05-24 19:25 ` [PATCH v3 08/10] media: i2c: imx290: Add support to enumerate all frame sizes Andrey Konovalov
2020-05-26 9:17 ` Sakari Ailus
2020-06-07 16:28 ` Andrey Konovalov
2020-06-08 8:00 ` Sakari Ailus
2020-05-24 19:25 ` [PATCH v3 09/10] media: i2c: imx290: Move the settle time delay out of loop Andrey Konovalov
2020-05-24 19:25 ` [PATCH v3 10/10] media: i2c: imx290: set bus_type before calling v4l2_fwnode_endpoint_alloc_parse() Andrey Konovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200524192505.20682-1-andrey.konovalov@linaro.org \
--to=andrey.konovalov@linaro.org \
--cc=a.brela@framos.com \
--cc=c.barrett@framos.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mchehab@kernel.org \
--cc=peter.griffin@linaro.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).