From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99555C433E0 for ; Fri, 29 May 2020 08:05:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6873C206A4 for ; Fri, 29 May 2020 08:05:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pEEAVoTm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6873C206A4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gondor.apana.org.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Iwqi4VSKbS00bgQJa5E7GczRWM/BPspPec027koYzVw=; b=pEEAVoTmZ2PFf6 4k3SKti+GJ1TzuAYyrNG7QtCDSMybGfBBiFeeUAK7FpcNRISOB+cODvjzCvSB250w3gPuDlwFnLtx eFmr3Lla8r+5BfEv0fVZqcRRjYyBs3zGCekXPixm14Pt7M92GZqgYvt83Q+c0vBjjD63rcrX6Zi2R NfqkYrI86c9r5dWTW+Z8L/Jq3MjrtoCazcv8OwSUFPn8K4OaJhjK7+AQzmPucPcvqQ9ub9rExxngr w4LEvSPmsrVCFY9nXamzA91eoZnqMp7BMhBbojNsDKj2uD1jHrOpCkcTPYYyt9VFbJeyY5sDahfah 2oVQHPurliR4phq1gOOw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jea1F-0004ee-RC; Fri, 29 May 2020 08:05:33 +0000 Received: from [216.24.177.18] (helo=fornost.hmeau.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jea1D-0004dQ-8L for linux-arm-kernel@lists.infradead.org; Fri, 29 May 2020 08:05:32 +0000 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1jea0q-00009x-S2; Fri, 29 May 2020 18:05:09 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 29 May 2020 18:05:08 +1000 Date: Fri, 29 May 2020 18:05:08 +1000 From: Herbert Xu To: Ard Biesheuvel Subject: Re: [RFC/RFT PATCH 0/2] crypto: add CTS output IVs for arm64 and testmgr Message-ID: <20200529080508.GA2880@gondor.apana.org.au> References: <20200519190211.76855-1-ardb@kernel.org> <20200528073349.GA32566@gondor.apana.org.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200529_010531_294553_CEC06518 X-CRM114-Status: GOOD ( 10.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eric Biggers , Stephan Mueller , Linux Crypto Mailing List , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 28, 2020 at 10:33:25AM +0200, Ard Biesheuvel wrote: > > The reason we return output IVs for CBC is because our generic > implementation of CTS can wrap any CBC implementation, and relies on > this output IV rather than grabbing it from the ciphertext directly > (which may be tricky and is best left up to the CBC code) No that's not the main reason. The main user of chaining is algif_skcipher. > So if you are saying that we should never split up algif_skcipher > requests into multiple calls into the underlying skcipher, then I > agree with you. Even if the generic CTS seems to work more or less as > expected by, e.g., the NIST validation tool, this is unspecified > behavior, and definitely broken in various other places. I was merely suggesting that requests to CTS/XTS shouldn't be split up. Doing it for others would be a serious regression. However, having looked at this it would seem that the effort in marking CTS/XTS is not that different to just adding support to hold the last two blocks of data so that CTS/XTS can support chaining. I'll work on this. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel