* [PATCH] arm64: dts: rockchip: fix rk3399-puma vcc5v0-host gpio
@ 2020-06-04 9:12 Heiko Stuebner
2020-06-17 8:37 ` Heiko Stuebner
0 siblings, 1 reply; 2+ messages in thread
From: Heiko Stuebner @ 2020-06-04 9:12 UTC (permalink / raw)
To: linux-rockchip
Cc: Heiko Stuebner, klaus.goger, heiko, linux-arm-kernel, christoph.muellner
From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
The puma vcc5v0_host regulator node currently uses opposite active-values
for the enable pin. The gpio-declaration uses active-high while the
separate enable-active-low property marks the pin as active low.
While on the kernel side this works ok, other DT users may get
confused - as seen with uboot right now.
So bring this in line and make both properties match, similar to the
gmac fix.
Fixes: 2c66fc34e945 ("arm64: dts: rockchip: add RK3399-Q7 (Puma) SoM")
Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
---
arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi
index 531520e771e7..72c06abd27ea 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi
@@ -101,7 +101,7 @@ vcc3v3_sys: vcc3v3-sys {
vcc5v0_host: vcc5v0-host-regulator {
compatible = "regulator-fixed";
- gpio = <&gpio4 RK_PA3 GPIO_ACTIVE_HIGH>;
+ gpio = <&gpio4 RK_PA3 GPIO_ACTIVE_LOW>;
enable-active-low;
pinctrl-names = "default";
pinctrl-0 = <&vcc5v0_host_en>;
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: fix rk3399-puma vcc5v0-host gpio
2020-06-04 9:12 [PATCH] arm64: dts: rockchip: fix rk3399-puma vcc5v0-host gpio Heiko Stuebner
@ 2020-06-17 8:37 ` Heiko Stuebner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2020-06-17 8:37 UTC (permalink / raw)
To: linux-rockchip, Heiko Stuebner
Cc: Heiko Stuebner, klaus.goger, linux-arm-kernel, christoph.muellner
On Thu, 4 Jun 2020 11:12:39 +0200, Heiko Stuebner wrote:
> The puma vcc5v0_host regulator node currently uses opposite active-values
> for the enable pin. The gpio-declaration uses active-high while the
> separate enable-active-low property marks the pin as active low.
>
> While on the kernel side this works ok, other DT users may get
> confused - as seen with uboot right now.
>
> [...]
Applied, thanks!
[1/1] arm64: dts: rockchip: fix rk3399-puma vcc5v0-host gpio
commit: 7a7184f6cfa9279f1a1c10a1845d247d7fad54ff
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-17 8:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-04 9:12 [PATCH] arm64: dts: rockchip: fix rk3399-puma vcc5v0-host gpio Heiko Stuebner
2020-06-17 8:37 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).