From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F77CC433DF for ; Mon, 15 Jun 2020 07:06:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6486520707 for ; Mon, 15 Jun 2020 07:06:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SoSiZp+3"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="NGt9H7nP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6486520707 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eJ8l9n2haPFaw+yYRaD+iEtcKOWkZhNYDzveSIdgbLs=; b=SoSiZp+3MUid7Huj0xnmTNZjS +dyM+Btqd4KT/SpB6fCJGfoDrz4g21n6/NocvU6sCLkjKBdjIFnx2Udka8fuKWXsRZaWKzPA9Lp47 KnHp6mP/wyj2aQSjjriOmy78EVMiaOIBUTl7MDoe/FKGseMmyINoHhkw9VUTGhBFvpmkQiG8vbaPs oa0ZPHDzrNPNHFJZofvFNF5KmvxMjPBayzLm16Ghl8FhZ0D8SL9qYcRMqm+PD3dFasw4ScZoedDrQ 8JWu3KmWaSnJ8psZeFlgzA1fH3B4eTL6TO+pDA4FlEGCXDZoEPVkvrCrput8iwgbzc0HWRdGOIUwa joiJicTJQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jkjCJ-00004y-V9; Mon, 15 Jun 2020 07:06:23 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jkjCG-0008WE-SB for linux-arm-kernel@lists.infradead.org; Mon, 15 Jun 2020 07:06:22 +0000 Received: from localhost (p54b333b6.dip0.t-ipconnect.de [84.179.51.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0060C206D7; Mon, 15 Jun 2020 07:06:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592204780; bh=fUQNCAAb6DjGomvNl4eNFS4GZ/iZOIWKfiriaaglQf4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NGt9H7nPgvZ32vSDoQGNlVzCidRta/sIu4S/AmYHx+omviqGOlI7rqBOrBomhSabw odKfQDbf/MwUe5m2rlbgggpyE7/rDmDwe2IGiw+N6nfMmlxjKDzT8UnkOvCjmA9xi4 3HP1Lh/ZIcwsuvpACy6Cczd7m27IFY44y/ETSLR8= Date: Mon, 15 Jun 2020 09:06:13 +0200 From: Wolfram Sang To: Aisheng Dong Subject: Re: [PATCH] [v3] i2c: imx-lpi2c: Fix runtime PM imbalance on error Message-ID: <20200615070613.GA1497@kunai> References: <20200601061640.27632-1-dinghao.liu@zju.edu.cn> <20200614091203.GC2878@kunai> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200615_000620_924182_AA98C25A X-CRM114-Status: GOOD ( 16.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Andy Duan , Pengutronix Kernel Team , "linux-pm@vger.kernel.org" , Fabio Estevam , Sascha Hauer , "Rafael J . Wysocki" , "kjlu@umn.edu" , "linux-kernel@vger.kernel.org" , Markus Elfring , dl-linux-imx , Dinghao Liu , Shawn Guo , "linux-arm-kernel@lists.infradead.org" , "linux-i2c@vger.kernel.org" Content-Type: multipart/mixed; boundary="===============3037081795987686743==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3037081795987686743== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zYM0uCDKw75PZbzx" Content-Disposition: inline --zYM0uCDKw75PZbzx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 15, 2020 at 06:33:40AM +0000, Aisheng Dong wrote: > > From: Wolfram Sang > > Sent: Sunday, June 14, 2020 5:12 PM > >=20 > > On Mon, Jun 01, 2020 at 02:16:40PM +0800, Dinghao Liu wrote: > > > pm_runtime_get_sync() increments the runtime PM usage counter even the > > > call returns an error code. Thus a corresponding decrement is needed > > > on the error handling path to keep the counter balanced. > >=20 > > Can you point me to a discussion where it was decided that this is a pr= oper fix? > > I'd think we rather should fix pm_runtime_get_sync() but maybe there are > > technical reasons against it. >=20 > I had the same feeling. > Copy pm guys to comments. I started a seperate thread: https://lkml.org/lkml/2020/6/14/76 Still, on-going discussion if the proper fix is to remove the error check. --zYM0uCDKw75PZbzx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl7nHeEACgkQFA3kzBSg KbbAbA/9FTQMd1gpGi6tiS2NPZ+sd1kxs7t0vnUK9MLKKpgEC0Do/6JBFttvRoN6 So/PITa5zgqjUYeNzRtrbMjXmQVSbCanAhMOBGX2/8w6aMUJnGPbm6sDT26oQkSP T0jzir2gR3Mw9bh07kXbszx4vJGOFJDOlH31BjxvN/9lZZRCILiEpfoTxGNAOXyV 73BiU6Ez6AMB01363BL8vMC/l4W82YeitG6xrxvz+Fzw5/OQ7qFlOrDfEFbP10tU wlbk5gUjyWEzhzh0qqGPuRVDeuBxGDgrDQDpFGScJBfZ1oH7lqSyg7fjdOIG3fNH RPSgvvoPkJkY1WL9wbt3lOpt+F/rBJYy7iDMwY9CgYnaF4bP+peLtUzazK83Wzhb F4N5A7AP550rmEYEZV1sJqNHacQFqcXXdremSzKjMEp1XVp4CqncjIGrC9qy+BAQ VZi3L8ExCY36TWYPi5lBqJ76vv3nB2q+GhYkU9CaBok/rQ12LmgGS4Z27X9YjdS4 3CwpsXCrl+/4tsbxFxbWqRvvCMYQwtbIJ3EWGG6ga277+OtYDSSnn3QLFt4GUQ3F xnWTt0+xvPRHfI/b2ffkQBYINd9kqEy5c7H6OSN67NtdREktPmtbS8OHhEoTx1gy 2Ly8984MP9JzxermLmvQ0mvvtJFrr1TA80UCmQev6XsMoQ/xCUg= =g8OW -----END PGP SIGNATURE----- --zYM0uCDKw75PZbzx-- --===============3037081795987686743== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3037081795987686743==--