From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6488C433DF for ; Wed, 24 Jun 2020 23:23:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6FF3B2078E for ; Wed, 24 Jun 2020 23:23:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nhpjDiDw"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="R9IB6Osr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6FF3B2078E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dAJAqhkJ+7OwmXYR7uEM+OemZBm0xo/q5Iz6zIKPDM8=; b=nhpjDiDwyPPuIuw6n4jylh+Jy GbhTHOGZ+mEGUT1SEgquhmInVxBX+Lzh0RSgJFOV8uYbN73HQyrzYirjj/shykRgvHhHAC9Pza0AQ OZmflsbKvMmi+Wpb2ChIrKNyBwV34r/awxZiDQnGcFHm94ecrKFm7Dxn+6WxSGkgJu/jsWWuWz1Qc SRVEhJ5UqVeWBDHNOr942tPhps5KN3CnUjkvx9F9JdzZcp67sFGB+amwo93cV3vsDKusa4713jiOe jLNBMYCI0FtWJRljOPMwqXPyPxn3EN1vgztnpxJtg1U2a/LSesPYnJTTMnmo4V/rAVKA24k3RTbEs 19SrvZ31A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joEiD-0003iv-Jw; Wed, 24 Jun 2020 23:21:49 +0000 Received: from mail-pj1-x1042.google.com ([2607:f8b0:4864:20::1042]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joEi9-0003gg-VS for linux-arm-kernel@lists.infradead.org; Wed, 24 Jun 2020 23:21:47 +0000 Received: by mail-pj1-x1042.google.com with SMTP id q90so1440540pjh.3 for ; Wed, 24 Jun 2020 16:21:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=XsZH2ZlxCr6iT3L+49rRTJJnEJ39rkW4+RYUadIzOtA=; b=R9IB6Osrb2qY+Afwa3MRErRuIdvIh83bCWGDGkn1jNRVAI7V/i8wm4cDEgG3oqoLAv ELOwYrGok06AlaYBhZeZ+3IfjuhQsuGjYu2XatVJ/71OLiUAIZZySCSiajaFHNciHcFf e0IKPhqtq2BJSLy0T3JT47Wx5ej+SaC5oLqz/thfZAX/s5DAQJIfcE/zGNUmp4i50yLi wUXNjKP97yKO1chFosjCP6jHbHl9M5gNbhQQQZuBjkNuOh9sE2u/RnliQkupdRrTnB78 ensm1H7mTXgoQvxbhovdB3WMbvG5GPp88KUT1PvrdRHxTRQ8uR2fd7wNsVlZSXgqslAt PztA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XsZH2ZlxCr6iT3L+49rRTJJnEJ39rkW4+RYUadIzOtA=; b=tQcsWg6oHd1t/1MCEWRywOTpNzos5ghj593EJYr1d2PMZnOsy4Uh0fpFcibDdK8Q9s sOW7uKZ0OYIft+hABJc8xc/TtUtzG9Wn38TcgoKdcipmVcS5/vhsdIPTl6dyhloTQO+W agIwo3/T4MfCg2ZelTQHvXZ2NGa4ROHwIUfW20j9TEXsG1n9hNVZVDTCqhmdbffpuYgp 9EDCLShTE7zTV9RiUohOK6KhGVx2dN0N6BgwdRL/Xf672CzsO3fGKvt4qdhbhT4I5orI LHLmyh0RmNDCdXNeInFB2d+YK3Qkpg2Sa9gN3z4nS1bTM+1RVeIlKcPk+vNUMkm8ubbN AG4g== X-Gm-Message-State: AOAM53342pexACWKX7aqu9jYiMDRZBXS+0s6WIfEOdu4fWaJa42z7fGS f+uGUh/fkxjm8tRFui3O61Dp7Q== X-Google-Smtp-Source: ABdhPJyQvGPhhCDkDPs//GgXdG4S7pu68Q1Tt12Ksb/sgYYUwtokZaIU62eANn1ZR6ZjIyAunxBX0w== X-Received: by 2002:a17:90a:ea18:: with SMTP id w24mr186844pjy.158.1593040903445; Wed, 24 Jun 2020 16:21:43 -0700 (PDT) Received: from google.com ([2620:15c:201:2:ce90:ab18:83b0:619]) by smtp.gmail.com with ESMTPSA id u61sm6452415pjb.7.2020.06.24.16.21.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 16:21:42 -0700 (PDT) Date: Wed, 24 Jun 2020 16:21:37 -0700 From: Sami Tolvanen To: Nick Desaulniers Subject: Re: [PATCH 11/22] pci: lto: fix PREL32 relocations Message-ID: <20200624232137.GA243469@google.com> References: <20200624203200.78870-12-samitolvanen@google.com> <202006250618.DQj64eMK%lkp@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , kbuild-all@lists.01.org, kernel test robot , "Paul E. McKenney" , Kernel Hardening , Greg Kroah-Hartman , Masahiro Yamada , clang-built-linux , Will Deacon , Linux ARM , Kees Cook Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 24, 2020 at 04:03:48PM -0700, Nick Desaulniers wrote: > On Wed, Jun 24, 2020 at 3:50 PM kernel test robot wrote: > > > > Hi Sami, > > > > Thank you for the patch! Perhaps something to improve: > > > > [auto build test WARNING on 26e122e97a3d0390ebec389347f64f3730fdf48f] > > > > url: https://github.com/0day-ci/linux/commits/Sami-Tolvanen/add-support-for-Clang-LTO/20200625-043816 > > base: 26e122e97a3d0390ebec389347f64f3730fdf48f > > config: i386-alldefconfig (attached as .config) > > compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 > > reproduce (this is a W=1 build): > > # save the attached .config to linux build tree > > make W=1 ARCH=i386 > > Note: W=1 ^ > > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > > > All warnings (new ones prefixed by >>): > > > > In file included from arch/x86/kernel/pci-dma.c:9: > > >> include/linux/compiler-gcc.h:72:45: warning: no previous prototype for '__UNIQUE_ID_via_no_dac190' [-Wmissing-prototypes] > > 72 | #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) > > | ^~~~~~~~~~~~ > > include/linux/pci.h:1914:7: note: in definition of macro '___DECLARE_PCI_FIXUP_SECTION' > > 1914 | void stub(struct pci_dev *dev) { hook(dev); } \ > > | ^~~~ > > Should `stub` be qualified as `static inline`? https://godbolt.org/z/cPBXxW > Or should stub be declared in this header, but implemented in a .c > file? (I'm guessing the former, since the `hook` callback comes from > the macro). Does static inline guarantee that the compiler won't rename the symbol? The purpose of this change is to have a stable symbol name, which we can safely use in inline assembly. Sami _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel