From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75BD5C433E0 for ; Mon, 29 Jun 2020 08:42:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 42C0F23371 for ; Mon, 29 Jun 2020 08:42:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="2jPTRAMS"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="VfCp9hE0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 42C0F23371 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gSG01kP/dT0sSgGd9f137IxyYumC2VE3F10CiFVAgM4=; b=2jPTRAMSo4yGkoUOSsqTm7IUG JGnp1dIWxspdPkruwnpNGzuw1twHZcxkIo1SCks1SILyLX6YFUGADY/dMw/v6etZhocXrJ9c+HELe 0VCd7LcSo76U7p1J4Z9PmN3KkTtE9M/X9THOlobkOx4QlJAnmaKfKJ2zFZiRNET2A2XEldAd5dzIp eYfilpbAzP4MG8uqTrARVAcTkgyCtsbI7PhKZVFl+QJm/JO2SGIezCXYCqeRICVGblYs3zI0vnFIe cFQ1mkYJ6+vDFVfZOHnLbK5cFaR+ZN0FU03OBmPXL9F9OlrbfLtUMEOxeIBaW28/PYa/SAH/YhFov FVRrrx3qw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jppLe-0000j4-Py; Mon, 29 Jun 2020 08:41:06 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jppLb-0000ib-Im; Mon, 29 Jun 2020 08:41:04 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9501723370; Mon, 29 Jun 2020 08:41:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593420062; bh=NgETdEp/TPGsMKNJQFJucR9ZSygTH08g48sTzqUJy8M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VfCp9hE0U1V55QP8CtGkrKq/7ClTTCkOVeDpojaZzjd7aUXx+6pITg+YyxFaYu4jr naHIJq0reLlZHSS6rTDqZoD6oWcAgnDmap4zDCam+du0CHBSo+I67WBnoXL2IzwO6f 66sWli0Vhn6A4ZyHu6XwMOh6ciaE6hDAN4crXajo= Date: Mon, 29 Jun 2020 10:40:51 +0200 From: Greg KH To: Andy Shevchenko Subject: Re: [PATCH v4] tty: serial: don't do termios for BTIF Message-ID: <20200629084051.GA1234189@kroah.com> References: <78efa2b1e2599deff4d838b05b4054ec5ac2976a.1592595601.git.sean.wang@mediatek.com> <20200627141222.GC1901451@kroah.com> <20200629082927.GA3703480@smile.fi.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200629082927.GA3703480@smile.fi.intel.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, heikki.krogerus@linux.intel.com, david@lechnology.com, arnd@arndb.de, linux-serial@vger.kernel.org, Steven Liu , jan.kiszka@siemens.com, sean.wang@mediatek.com, hpeter@gmail.com, linux-kernel@vger.kernel.org, tthayer@opensource.altera.com, Ryder Lee , robh+dt@kernel.org, linux-mediatek@lists.infradead.org, joel@jms.id.au, p.zabel@pengutronix.de, jslaby@suse.com, matthias.bgg@gmail.com, robert.jarzmik@free.fr, linux-arm-kernel@lists.infradead.org, vigneshr@ti.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 29, 2020 at 11:29:27AM +0300, Andy Shevchenko wrote: > On Sat, Jun 27, 2020 at 04:12:22PM +0200, Greg KH wrote: > > On Sat, Jun 20, 2020 at 03:59:14AM +0800, sean.wang@mediatek.com wrote: > > > From: Sean Wang > > > > > > Bluetooth Interface (BTIF) is designed dedicatedly for MediaTek SOC with > > > BT in order to be instead of the UART interface between BT module and Host > > > CPU, and not exported to user space to access. > > > > > > As the UART design, BTIF will be an APB slave and can transmit or receive > > > data by MCU access, but doesn't provide termios function like baudrate and > > > flow control setup. > > > > > > Even LCR on offset 0xC that is just a FAKELCR > > > a. If FAKELCR[7] is equaled to 1, RBR(0x00), THR(0x00), IER(0x04) > > > will not be readable/writable. > > > > > > b. If FAKELCR is equaled to 0xBF, RBR(0x00), THR(0x00), IER(0x04), > > > IIR(0x08), and LSR(0x14) will not be readable/writable. > > > > > > So adding a new capability 'UART_CAP_NTIO' for the unusual unsupported > > > case. > > > > > > The bluetooth driver would use BTIF device as a serdev. So the termios > > > still function would be called in kernelspace from ttyport_open in > > > drivers/tty/serdev/serdev-ttyprt.c. > > > > +#define UART_CAP_NTIO (1 << 18) /* UART doesn't do termios */ > > > > Naming is hard. I will never remember what "NTIO" is, how about we make > > it explicit: > > define UART_CAP_IGNORE_TERMIOS > > > > And the _CAP_ name is getting out of hand, this isn't a "capability", > > it's a "quirk for this port" but that's a battle to worry about later... > > For quirks we have a separate field in struct uart_port. Perhaps that can be used? That would be much nicer, if possible. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel