From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27C33C433E0 for ; Mon, 29 Jun 2020 20:06:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9A2120760 for ; Mon, 29 Jun 2020 20:05:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="imyi3wGC"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="iyegTPlb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9A2120760 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8I9sXIhi7HhKL9hEEE6agfqCPSrjQeuVvJyZgr+dW2E=; b=imyi3wGCjwga106tBINqW6sbC wPQ51tz5zErr+QKePTdjUM9xuBaQxZloD52EkoJNB94syS+sqTEtdDI5CAcsotdKgO0mt0zav23G/ OoDR5dkk5l6PEcZjwMwDDFq4DL+pv+3O1gFv/YtMFhkJJSW078MUZSBsByjdoreOjBCjqoL9M9evV I185J+N9FXcYwEY2wTamdS9jFoxG3rMIJWkefH/D6PXyJGyeU32SYn8CYS9hE/phnUyKCa9XZ2mKR 8Geh3Z7jEPWLjgSyEfdVNvDWR3DvYvVZF7PCXKWo+fXtCxBY7T5+YkYyBKqfyneT8tUqSuJogst0o mZZL3nk0g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jq018-0002Mn-5o; Mon, 29 Jun 2020 20:04:38 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jq015-0002LH-IH for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 20:04:36 +0000 Received: by mail-pf1-x441.google.com with SMTP id j1so8358942pfe.4 for ; Mon, 29 Jun 2020 13:04:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=dTLUsyi9EoNBvYop+SAQkhC6GYIREzqCPpDVHlef0N4=; b=iyegTPlbjhn5HlYQVhbZw8XqrIU7lJKRRk5bmuxEeuSQzinLKXX6CuU8egSe3yPdKD hN4x0leCH3AyDKiaTF3Nb59aff4r2LF1aPPEwtqGfIEB+oZD9/0TJ9jhmlHrykRvmJnl a6cjSj2v7FpsBA9YWOnvcv54vPdfr5mhHAKW4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dTLUsyi9EoNBvYop+SAQkhC6GYIREzqCPpDVHlef0N4=; b=dOoT9gN28B2Pjj8ALrAn40XBTFZ7FVJwKbsktDohVku+Vey8KMTRryRwbm23vf6Pf6 6bUkpreM2HjXoT9qB+RBhiB3k0nVheuEKn60F0xSQH0Ta8t69Yzr33DTqZmK5+HnICIJ eyDNNJXB5UpNJvDSUyJYKkGlw7znNbrwkLjdAg81phWIJNK3It1ndWSRBNnFDkrg4m1d pmilmAtwQP/c/OviEgiUgTlSb9u8v2PgoG/RNolrSen8TBDCRyHXXQC0MMEpURCTT1x8 tK0K5vcEnWhvd3dKMA8Oy9iRpZAm/qZ5gv94kfTXeWP11u0bEaWN+7gjzu/1nEPxNJlR mEeg== X-Gm-Message-State: AOAM531f7xrIzYgpHXz54k7AueXAEXKaccGJ6o8J0xBVrOoKnZym7j0K pVRh+OyV1XKCFZc1FSjuJpN9lw== X-Google-Smtp-Source: ABdhPJzdUinj83wjxemEYOkw00z16gQNGulknaX544OOjyQoDtiBgCLUR8nqCuc5q1pH8hR406oB2w== X-Received: by 2002:a63:4c08:: with SMTP id z8mr11413821pga.201.1593461073426; Mon, 29 Jun 2020 13:04:33 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id h130sm446526pfe.200.2020.06.29.13.04.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 13:04:32 -0700 (PDT) Date: Mon, 29 Jun 2020 13:04:31 -0700 From: Kees Cook To: Nick Desaulniers Subject: Re: [PATCH v4 08/17] arm64/mm: Remove needless section quotes Message-ID: <202006291301.46FEF3B7@keescook> References: <20200629061840.4065483-1-keescook@chromium.org> <20200629061840.4065483-9-keescook@chromium.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-arch , linux-efi , Arnd Bergmann , Peter Collingbourne , Catalin Marinas , Masahiro Yamada , "maintainer:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)" , Russell King , LKML , Nathan Chancellor , clang-built-linux , Arvind Sankar , Ingo Molnar , James Morse , Joe Perches , Thomas Gleixner , Borislav Petkov , Will Deacon , Ard Biesheuvel , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 29, 2020 at 12:53:47PM -0700, Nick Desaulniers wrote: > On Sun, Jun 28, 2020 at 11:18 PM Kees Cook wrote: > > > > Fix a case of needless quotes in __section(), which Clang doesn't like. > > > > Acked-by: Will Deacon > > Signed-off-by: Kees Cook > > Yep, I remember bugs from this. Probably should scan the kernel for > other instances of this. +Joe for checkpatch.pl validation. I think the others are safe because they're in macros: $ git grep -4 '__section("' include/linux/compiler.h-# define KENTRY(sym) \ include/linux/compiler.h- extern typeof(sym) sym; \ include/linux/compiler.h- static const unsigned long __kentry_##sym \ include/linux/compiler.h- __used \ include/linux/compiler.h: __section("___kentry" "+" #sym ) \ include/linux/compiler.h- = (unsigned long)&sym; -- include/linux/export.h-#define __ksym_marker(sym) \ include/linux/export.h: static int __ksym_marker_##sym[0] __section(".discard.ksym") __used -- include/linux/srcutree.h-# define __DEFINE_SRCU(name, is_static) \ include/linux/srcutree.h- is_static struct srcu_struct name; \ include/linux/srcutree.h- struct srcu_struct * const __srcu_struct_##name \ include/linux/srcutree.h: __section("___srcu_struct_ptrs") = &name > Reviewed-by: Nick Desaulniers Thanks! -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel