From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93A4DC433E0 for ; Tue, 30 Jun 2020 15:36:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64CA220675 for ; Tue, 30 Jun 2020 15:36:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ibi1tPEW"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="PM1OchYC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64CA220675 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SKifYOq0Z/EVIS9aWh890ta6uc39BnKZabcf1GeMrGk=; b=Ibi1tPEWVDv1x4yP2GbPrIsXd wVDGxinmB1+DrSF7W5ivz1UTclGMg14uj6bbK4Ar6FAcLB55yE4YOutZ9Lw8FTFLURELKFLtB2q5q 4iXzzAB5RynWLVL5o7I5HZk7lsIyGZevPWlHtfdOF5EPTVTAduyB3m5n8c/WALcLnBbc5wfKFnE+C FdQJ1QrXVUR2YS4vnOnE7IiTxwnO52ioqtdxPhp42+ZUpkQvGCIvKttdRjV0lnhd00jW6+Oi2FMYh nJYhAk226832rZmLm5bEf4tez4Uq8J8iZZnu+mvwfYq5QiGjIqDrOoMvax9dpVkuYid7DFRyDQ1z+ iTW1RH8dA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqII2-0002WH-0Z; Tue, 30 Jun 2020 15:35:18 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqIHs-0002Um-T9 for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 15:35:14 +0000 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0B8862074F; Tue, 30 Jun 2020 15:35:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593531307; bh=hbapiSFW66hXpzycU06z2LcbaJeuNN3dsr4X1PHfJVA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PM1OchYCo5d7s/0dHTzAp4CR34sFUpC/KwQRFA1wf5y3DgJ2TDfgOnlwhKQSjt68Y hGrO/f+IG48lqXSwCdDKdqlNMgvJstS2UzryEls8XBeYvuq0lwKeyFxIeHZy8y9h6y nIaWMRzoHl88lgYKQ8prc/16WQ2SfzW9DP0I5b3w= Date: Tue, 30 Jun 2020 16:35:05 +0100 From: Mark Brown To: Andrzej Hajda Subject: Re: [PATCH v7 1/4] driver core: add device probe log helper Message-ID: <20200630153505.GM5272@sirena.org.uk> References: <20200629112242.18380-1-a.hajda@samsung.com> <20200629112242.18380-2-a.hajda@samsung.com> MIME-Version: 1.0 In-Reply-To: <20200629112242.18380-2-a.hajda@samsung.com> X-Cookie: Walk softly and carry a megawatt laser. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200630_113509_057239_CECB2AF8 X-CRM114-Status: GOOD ( 12.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , "Rafael J. Wysocki" , Greg Kroah-Hartman , Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org, "open list:DRM DRIVERS" , Russell King - ARM Linux , Neil Armstrong , Jonas Karlman , andy.shevchenko@gmail.com, Laurent Pinchart , Daniel Vetter , linux-arm-kernel@lists.infradead.org, Marek Szyprowski Content-Type: multipart/mixed; boundary="===============8572339022082562541==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8572339022082562541== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="MsEL38XAg4rx1uDx" Content-Disposition: inline --MsEL38XAg4rx1uDx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jun 29, 2020 at 01:22:39PM +0200, Andrzej Hajda wrote: > During probe every time driver gets resource it should usually check for > error printk some message if it is not -EPROBE_DEFER and return the error. > This pattern is simple but requires adding few lines after any resource > acquisition code, as a result it is often omitted or implemented only > partially. Reviewed-by: Mark Brown --MsEL38XAg4rx1uDx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl77W6gACgkQJNaLcl1U h9BzwQf+JzNlmtiYmNXjlnt8XG+LzxdVCambFM2BriTiK4kqcAHo44/jTnkfgO/7 uc78IN9CohQgalmFe21k1ST2/FBz5Iy6HgnDbPiakilZHPLqNjS9NaEzo7w2tumc Ntr1S9+KjvSYaosJdrhbr+OAKPWEVyt5yZ2wGVwoPNgKu3txHYCXFXNJtLsXcg0b 82yJY6BXSpzj26nm02UwZ/eDDtfQaoNDhcrAh9JmmZd/DytsbC2fBayDqrhmF2PS 4vRHYPFIArvxTGY/4RQjw9AWYy+Q7Ns+nYDbzxKBfIMremBWu8E9mr741PkPdKVV LXVRLnx3tFUTwOl7loakReFTTCRx2w== =yPu7 -----END PGP SIGNATURE----- --MsEL38XAg4rx1uDx-- --===============8572339022082562541== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8572339022082562541==--